From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>,
iyzsong@envs.net, 65550@debbugs.gnu.org
Cc: 宋文武 <iyzsong@member.fsf.org>
Subject: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages.
Date: Sun, 27 Aug 2023 09:34:36 +0200 [thread overview]
Message-ID: <87edjp546r.fsf@jpoiret.xyz> (raw)
In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
Hi everyone,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> I think this patch misses the most obvious use case of the out:lib
> split. I also think that hardcoding this list is bound to fail.
>
> Instead, we could for the time being solve this with yet another
> package property.
> '((propagate-inputs-from "lib")) ; but not out
> '((propagate-inputs-from . ("lib"))) ; same meaning, different style
> '((propagate-inputs-from "out" "lib")) ; but not doc
> If the property is missing, we still propagate from all outputs, as is
> currently done.
>
> WDYT?
I don't really like the hackiness of this (yet another weird thing for
independent contributors to learn), but I also understand the need.
This one LGTM, but maybe we should think a bit more about simpler
solutions before committing to this.
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
next prev parent reply other threads:[~2023-08-27 7:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 11:36 Don't add propagated-inputs for all outputs 宋文武
2023-08-26 13:53 ` [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages iyzsong--- via Guix-patches via
2023-08-26 14:21 ` Liliana Marie Prikler
2023-08-27 7:30 ` 宋文武 via Guix-patches via
2023-08-27 9:31 ` Liliana Marie Prikler
2023-08-29 10:24 ` 宋文武 via Guix-patches via
2023-08-29 17:01 ` Liliana Marie Prikler
2023-08-30 10:55 ` 宋文武 via Guix-patches via
2023-09-01 2:16 ` [bug#65550] Don't add propagated-inputs for all outputs Maxim Cournoyer
2023-08-27 7:34 ` Josselin Poiret via Guix-patches via [this message]
2023-09-01 2:34 ` Maxim Cournoyer
2023-09-01 12:53 ` 宋文武 via Guix-patches via
2023-09-01 15:03 ` Maxim Cournoyer
2023-09-02 0:43 ` bug#65550: " 宋文武 via Guix-patches via
2023-09-09 10:38 ` [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edjp546r.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=65550@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=iyzsong@envs.net \
--cc=iyzsong@member.fsf.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.