From: Giovanni Biscuolo <g@xelera.eu>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Simon Tournier <zimon.toutoune@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [workflow] Automatically close bug report when a patch is committed
Date: Thu, 14 Sep 2023 12:48:14 +0200 [thread overview]
Message-ID: <87a5tp9gk1.fsf@xelera.eu> (raw)
In-Reply-To: <877cotv4px.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2232 bytes --]
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
[...]
> I like the 'Closes: ' trailer idea; it's simple. However, it'd need to
> be something added locally, either the user typing it out (unlikely for
> most contributors) or via some mumi wizardry (it's unlikely that all
> users will use mumi), which means its usage (and value) would depend on
> how motivated individuals are to learn these new tricks.
I agree: the ratio, or better usecase, of my /trivial/ (in design, not
in implementation) initial proposal [1] was to try to help committers
closing bugs "in one go" by adding proper information to the commit
message, e.g. "Closes: #NNNNN"
It was _not_ intended for contributors, also because they could _not_
know that **specific** patch in a patch series will really close a
**whole** bug report: that's only a judgement of the committer.
Also, my ratio was influenced by my misunderstanding of a series of bug
closing actions performed by Vagrant (see [1] for details): the problem
in the majority (all?) of those cases was **not** that the committer
simply forgot to close the related bug report /but/ that bug reports
containing (different) patches for the _same_ package were not linked
each other: the solution to this class of problems in obviously not
"Automatically close bug report when a patch is committed", it's
something else [2]
> On the other hands, having Change-Ids added by a pre-commit hook
> automatically would means the user doesn't need to do anything special
> other than using git, and we could still infer useful information at any
> time (in a server hook, or as a batch process).
>
> For this reason, I think we could have both (why not? Change-Ids by
> themselves provide some value already -- traceability between our git
> history and guix-patches).
I agree: just having 'Change-Ids' alone already provide some added
value, even if we still miss the tooling (server side git hook, batch
processing
Thanks! Gio'
[1] id:8734zrn1sc.fsf@xelera.eu https://yhetil.org/guix/8734zrn1sc.fsf@xelera.eu/
[2] id:87msxyfhmv.fsf@xelera.eu https://yhetil.org/guix/87msxyfhmv.fsf@xelera.eu
--
Giovanni Biscuolo
Xelera IT Infrastructures
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
next prev parent reply other threads:[~2023-09-14 10:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 8:28 [workflow] Automatically close bug report when a patch is committed Giovanni Biscuolo
2023-09-06 9:45 ` Christopher Baines
2023-09-07 9:38 ` [workflow] Triaging issues (was Automatically close bug report when a patch is committed) Giovanni Biscuolo
2023-09-07 15:41 ` Vagrant Cascadian
2023-09-11 7:37 ` Giovanni Biscuolo
2023-09-11 15:29 ` Simon Tournier
2023-09-11 17:08 ` Giovanni Biscuolo
2023-09-06 16:14 ` [workflow] Automatically close bug report when a patch is committed Maxim Cournoyer
2023-09-07 0:23 ` Simon Tournier
2023-09-07 2:01 ` Maxim Cournoyer
2023-09-07 9:58 ` Simon Tournier
2023-09-09 23:43 ` Maxim Cournoyer
2023-09-07 13:11 ` Giovanni Biscuolo
2023-09-09 23:39 ` Maxim Cournoyer
2023-09-11 7:53 ` Giovanni Biscuolo
2023-09-11 14:01 ` Maxim Cournoyer
2023-09-11 17:10 ` Giovanni Biscuolo
2023-09-07 11:08 ` Giovanni Biscuolo
2023-09-07 11:58 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-07 13:09 ` Maxim Cournoyer
2023-09-07 15:52 ` Vagrant Cascadian
2023-09-09 23:50 ` Maxim Cournoyer
2023-09-11 11:00 ` Simon Tournier
2023-09-11 13:46 ` Maxim Cournoyer
2023-09-11 14:11 ` Simon Tournier
2023-09-11 15:33 ` Maxim Cournoyer
2023-09-13 2:46 ` Vagrant Cascadian
2023-09-13 15:49 ` Maxim Cournoyer
2023-09-14 16:30 ` Vagrant Cascadian
2023-09-14 18:02 ` Maxim Cournoyer
2023-09-07 13:19 ` Giovanni Biscuolo
2023-09-07 10:40 ` Giovanni Biscuolo
2023-09-07 13:49 ` Giovanni Biscuolo
2023-09-27 14:36 ` Christopher Baines
2023-09-07 16:12 ` Vagrant Cascadian
2023-09-07 16:28 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-09 23:59 ` Liliana Marie Prikler
2023-09-11 8:09 ` Giovanni Biscuolo
2023-09-11 13:59 ` Maxim Cournoyer
2023-09-11 17:55 ` Liliana Marie Prikler
2023-09-11 18:36 ` Maxim Cournoyer
2023-09-11 18:51 ` Liliana Marie Prikler
2023-09-11 20:41 ` Maxim Cournoyer
2023-09-12 13:55 ` Giovanni Biscuolo
2023-09-13 15:19 ` Maxim Cournoyer
2023-09-14 9:42 ` Giovanni Biscuolo
2023-09-14 16:58 ` Liliana Marie Prikler
2023-09-12 17:03 ` Liliana Marie Prikler
2023-09-13 9:37 ` Giovanni Biscuolo
2023-09-13 15:27 ` Maxim Cournoyer
2023-09-13 19:14 ` Liliana Marie Prikler
2023-09-13 22:12 ` Simon Tournier
2023-09-14 3:00 ` Maxim Cournoyer
2023-09-14 10:48 ` Giovanni Biscuolo [this message]
2023-09-15 21:46 ` Vagrant Cascadian
2023-09-19 16:41 ` Giovanni Biscuolo
2023-09-14 10:27 ` Giovanni Biscuolo
2023-09-14 12:25 ` Simon Tournier
2023-09-15 7:16 ` Giovanni Biscuolo
2023-09-15 9:03 ` Simon Tournier
2023-09-15 14:37 ` The already complicated (complex?) process for contributing Giovanni Biscuolo
2023-09-15 16:43 ` Simon Tournier
2023-09-16 7:33 ` Giovanni Biscuolo
2023-09-16 8:33 ` Simon Tournier
2023-09-14 7:20 ` [workflow] Automatically close bug report when a patch is committed Andreas Enge
2023-09-14 10:25 ` Giovanni Biscuolo
2023-09-14 22:51 ` Vagrant Cascadian
2023-09-15 4:23 ` Liliana Marie Prikler
2023-09-15 21:30 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5tp9gk1.fsf@xelera.eu \
--to=g@xelera.eu \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.