From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Giovanni Biscuolo <g@xelera.eu>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Vagrant Cascadian <vagrant@debian.org>
Cc: guix-devel@gnu.org
Subject: Re: [workflow] Automatically close bug report when a patch is committed
Date: Thu, 14 Sep 2023 18:58:25 +0200 [thread overview]
Message-ID: <bb78b60a08cd230078ee553700f56e00151ce3d5.camel@gmail.com> (raw)
In-Reply-To: <87il8d9jl8.fsf@xelera.eu>
Am Donnerstag, dem 14.09.2023 um 11:42 +0200 schrieb Giovanni Biscuolo:
> OK! :-) Let's see how this relates to the 2 use cases we are talking
> about:
>
> 1. Use "Fixes:" (et al) in commit msg to tell "the hook" to close the
> bug.
>
> This "action" implies that the commit we are pushing upstream
> "Applies:" to that bug report; it has no added value.
>
> 2. Use 'Change-Id'...
>
> This also implies that the commit we are pushing upstream "Applies:"
> to that bug report related to that [PATCH]; no added value also.
>
> So, when and only when we will implement a 'Change-Id' requirement
> adding an 'Applies' metadata is not useful for linking [PATCH]es to a
> bug report.
>
> Did I miss something?
On "Fixes:" vs. "Applies:" etc: the point of having more keywords is
that "Fixes:" implies a bug, whereas more general wording is preferable
when pushing a patch that simply updates a package. I just wrote some
example wordings and wanted all of us to agree on the one that makes
"the most sense"; alas it got misinterpreted.
>
> > Maybe if Vagrant put something like:
> >
> > Fixes: <debbugs.debian.org/NNNNN> that could cause problems? But
> > then the URL is different, so we could filter out these, so I don't
> > see the problem, if we use URLs.
>
> Yes we are saying the same thing! :-)
>
> Sorry I've made confusion but Vagrant's concern was expressed
> _before_ someone proposed (maybe Liliana) to use namespaced URIs.
>
> Vagrant please: do you confirm that using URLs "Fixes:
> <issues.guix.gnu.org/NNNNNN>" is OK for your usecase?
I actually prefer cool URLs myself, my format was
"Fixes: [optional description] <URL>"
> >
> To be cristal clear: I think that "the other proposal" (that is use
> "Fixes:" and alike in commit msg to close the provided bug num) will
> be **superseeded** when all the tools to manage (first of all: CLI
> query tool) the 'Change-Id' preudo-header/footer :-D
Well I still very much prefer human readable footers, but I'm perhaps a
little lonely in this debate.
Cheers
> > >
next prev parent reply other threads:[~2023-09-14 16:59 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 8:28 [workflow] Automatically close bug report when a patch is committed Giovanni Biscuolo
2023-09-06 9:45 ` Christopher Baines
2023-09-07 9:38 ` [workflow] Triaging issues (was Automatically close bug report when a patch is committed) Giovanni Biscuolo
2023-09-07 15:41 ` Vagrant Cascadian
2023-09-11 7:37 ` Giovanni Biscuolo
2023-09-11 15:29 ` Simon Tournier
2023-09-11 17:08 ` Giovanni Biscuolo
2023-09-06 16:14 ` [workflow] Automatically close bug report when a patch is committed Maxim Cournoyer
2023-09-07 0:23 ` Simon Tournier
2023-09-07 2:01 ` Maxim Cournoyer
2023-09-07 9:58 ` Simon Tournier
2023-09-09 23:43 ` Maxim Cournoyer
2023-09-07 13:11 ` Giovanni Biscuolo
2023-09-09 23:39 ` Maxim Cournoyer
2023-09-11 7:53 ` Giovanni Biscuolo
2023-09-11 14:01 ` Maxim Cournoyer
2023-09-11 17:10 ` Giovanni Biscuolo
2023-09-07 11:08 ` Giovanni Biscuolo
2023-09-07 11:58 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-07 13:09 ` Maxim Cournoyer
2023-09-07 15:52 ` Vagrant Cascadian
2023-09-09 23:50 ` Maxim Cournoyer
2023-09-11 11:00 ` Simon Tournier
2023-09-11 13:46 ` Maxim Cournoyer
2023-09-11 14:11 ` Simon Tournier
2023-09-11 15:33 ` Maxim Cournoyer
2023-09-13 2:46 ` Vagrant Cascadian
2023-09-13 15:49 ` Maxim Cournoyer
2023-09-14 16:30 ` Vagrant Cascadian
2023-09-14 18:02 ` Maxim Cournoyer
2023-09-07 13:19 ` Giovanni Biscuolo
2023-09-07 10:40 ` Giovanni Biscuolo
2023-09-07 13:49 ` Giovanni Biscuolo
2023-09-27 14:36 ` Christopher Baines
2023-09-07 16:12 ` Vagrant Cascadian
2023-09-07 16:28 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-09 23:59 ` Liliana Marie Prikler
2023-09-11 8:09 ` Giovanni Biscuolo
2023-09-11 13:59 ` Maxim Cournoyer
2023-09-11 17:55 ` Liliana Marie Prikler
2023-09-11 18:36 ` Maxim Cournoyer
2023-09-11 18:51 ` Liliana Marie Prikler
2023-09-11 20:41 ` Maxim Cournoyer
2023-09-12 13:55 ` Giovanni Biscuolo
2023-09-13 15:19 ` Maxim Cournoyer
2023-09-14 9:42 ` Giovanni Biscuolo
2023-09-14 16:58 ` Liliana Marie Prikler [this message]
2023-09-12 17:03 ` Liliana Marie Prikler
2023-09-13 9:37 ` Giovanni Biscuolo
2023-09-13 15:27 ` Maxim Cournoyer
2023-09-13 19:14 ` Liliana Marie Prikler
2023-09-13 22:12 ` Simon Tournier
2023-09-14 3:00 ` Maxim Cournoyer
2023-09-14 10:48 ` Giovanni Biscuolo
2023-09-15 21:46 ` Vagrant Cascadian
2023-09-19 16:41 ` Giovanni Biscuolo
2023-09-14 10:27 ` Giovanni Biscuolo
2023-09-14 12:25 ` Simon Tournier
2023-09-15 7:16 ` Giovanni Biscuolo
2023-09-15 9:03 ` Simon Tournier
2023-09-15 14:37 ` The already complicated (complex?) process for contributing Giovanni Biscuolo
2023-09-15 16:43 ` Simon Tournier
2023-09-16 7:33 ` Giovanni Biscuolo
2023-09-16 8:33 ` Simon Tournier
2023-09-14 7:20 ` [workflow] Automatically close bug report when a patch is committed Andreas Enge
2023-09-14 10:25 ` Giovanni Biscuolo
2023-09-14 22:51 ` Vagrant Cascadian
2023-09-15 4:23 ` Liliana Marie Prikler
2023-09-15 21:30 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb78b60a08cd230078ee553700f56e00151ce3d5.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=g@xelera.eu \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.