From: "Ludovic Courtès" <ludo@gnu.org>
To: Remco van 't Veer <remco@remworks.net>
Cc: 54352@debbugs.gnu.org
Subject: [bug#54352] [PATCH] services: dnsmasq: Add more options.
Date: Sat, 19 Mar 2022 11:54:53 +0100 [thread overview]
Message-ID: <878rt6nreq.fsf@gnu.org> (raw)
In-Reply-To: <20220312154813.5538-1-remco@remworks.net> (Remco van t. Veer's message of "Sat, 12 Mar 2022 16:48:13 +0100")
Hi,
Remco van 't Veer <remco@remworks.net> skribis:
> * gnu/services/dns.scm (<dnsmasq-configuration>): Add bogus-priv?,
> strict-order? and add-cpe-id options.
> (dnsmasq-shepherd-service): Pass bogus-priv, strict-order and add-cpe-id
> to the service.
> * doc/guix.texi (Guix Services): Document options added to dnsmasq.
I don’t use dnsmasq, but overall that LGTM, and a welcome addition.
Nitpick:
> + (bogus-priv? dnsmasq-configuration-bogus-priv?
> + (default #f)) ;boolean
I’d rather avoid the abbreviation and use something more descriptive,
even if that doesn’t match the name used in the config file. Maybe
something like ‘forward-private-reverse-lookup?’ (I’m making it up based
on the doc you wrote.) WDYT?
> + (add-cpe-id dnsmasq-configuration-add-cpe-id
> + (default #t)) ;string
Maybe ‘additional-cpe-id’ or ‘extra-cpe-id’ or ‘cpe-id’?
> (($ <dnsmasq-configuration> package
> no-hosts?
> port local-service? listen-addresses
> - resolv-file no-resolv? servers
> - addresses cache-size negative-cache?
> + resolv-file no-resolv? bogus-priv?
> + strict-order? servers addresses cache-size
> + negative-cache? add-cpe-id
Not a blocker for this patch, but we should change that to
‘match-record’, which is less error-prone.
Let me know what you think; you can send an updated patch if the
suggestions make sense to you.
Thanks!
Ludo’.
next prev parent reply other threads:[~2022-03-19 10:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 15:48 [bug#54352] [PATCH] services: dnsmasq: Add more options Remco van 't Veer
2022-03-19 10:54 ` Ludovic Courtès [this message]
2022-03-20 11:42 ` Remco van 't Veer
2022-03-20 11:44 ` [bug#54352] [PATCH v2] " Remco van 't Veer
2022-03-20 11:56 ` Maxime Devos
2022-03-20 12:22 ` Remco van 't Veer
2022-03-20 12:30 ` Maxime Devos
2022-03-20 13:04 ` Remco van 't Veer
2022-03-21 15:22 ` [bug#54352] [PATCH] " Ludovic Courtès
2022-03-21 18:36 ` Maxime Devos
2022-03-22 7:36 ` Remco van 't Veer
2022-03-22 10:02 ` Ludovic Courtès
2022-03-23 7:09 ` Remco van 't Veer
2022-03-20 12:31 ` [bug#54352] [PATCH v2] " Maxime Devos
2022-03-20 12:58 ` Remco van 't Veer
2022-03-20 12:32 ` Maxime Devos
2022-03-20 12:57 ` Remco van 't Veer
2022-03-20 13:16 ` Maxime Devos
2022-03-22 7:54 ` Remco van 't Veer
2022-03-20 12:36 ` Maxime Devos
2022-03-20 13:15 ` Remco van 't Veer
2022-03-20 13:17 ` Maxime Devos
2022-03-22 7:48 ` Remco van 't Veer
2022-03-20 13:20 ` Maxime Devos
2022-03-22 7:40 ` Remco van 't Veer
2022-03-23 7:07 ` [bug#54352] [PATCH v3] " Remco van 't Veer
2022-03-24 11:22 ` bug#54352: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rt6nreq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54352@debbugs.gnu.org \
--cc=remco@remworks.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.