all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54352@debbugs.gnu.org, Remco van 't Veer <remco@remworks.net>
Subject: [bug#54352] [PATCH] services: dnsmasq: Add more options.
Date: Mon, 21 Mar 2022 16:22:36 +0100	[thread overview]
Message-ID: <8735jbjpoj.fsf_-_@gnu.org> (raw)
In-Reply-To: <d718ef347744dee1adef0b66dc87a083bfb92126.camel@telenet.be> (Maxime Devos's message of "Sun, 20 Mar 2022 12:56:22 +0100")

Hi Maxime,

Maxime Devos <maximedevos@telenet.be> skribis:

> Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]:
>> +  (forward-private-reverse-lookup?
>> +   dnsmasq-configuration-forward-private-reverse-lookup?
>> +                    (default #t))       ;boolean
>> +  (strict-order?    dnsmasq-configuration-strict-order?
>> +                    (default #f))       ;boolean
>
> It would be nice to verify that these are, in fact, booleans,
> using field sanitizers.  See, e.g., ensure-setuid-program-list
> in (gnu system).

I think this suggestion is beyond the scope of this review: we’ve never
used sanitizers like this before (or almost), and this particular piece
of code doesn’t use them.

Also, with the recent discussion about the introduction of contracts,
I’d rather wait an use contracts everywhere once they’re available.

Thoughts?

Thanks,
Ludo’.




  parent reply	other threads:[~2022-03-21 15:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12 15:48 [bug#54352] [PATCH] services: dnsmasq: Add more options Remco van 't Veer
2022-03-19 10:54 ` Ludovic Courtès
2022-03-20 11:42   ` Remco van 't Veer
2022-03-20 11:44 ` [bug#54352] [PATCH v2] " Remco van 't Veer
2022-03-20 11:56   ` Maxime Devos
2022-03-20 12:22     ` Remco van 't Veer
2022-03-20 12:30       ` Maxime Devos
2022-03-20 13:04         ` Remco van 't Veer
2022-03-21 15:22     ` Ludovic Courtès [this message]
2022-03-21 18:36       ` [bug#54352] [PATCH] " Maxime Devos
2022-03-22  7:36         ` Remco van 't Veer
2022-03-22 10:02           ` Ludovic Courtès
2022-03-23  7:09             ` Remco van 't Veer
2022-03-20 12:31   ` [bug#54352] [PATCH v2] " Maxime Devos
2022-03-20 12:58     ` Remco van 't Veer
2022-03-20 12:32   ` Maxime Devos
2022-03-20 12:57     ` Remco van 't Veer
2022-03-20 13:16       ` Maxime Devos
2022-03-22  7:54         ` Remco van 't Veer
2022-03-20 12:36   ` Maxime Devos
2022-03-20 13:15     ` Remco van 't Veer
2022-03-20 13:17       ` Maxime Devos
2022-03-22  7:48         ` Remco van 't Veer
2022-03-20 13:20       ` Maxime Devos
2022-03-22  7:40         ` Remco van 't Veer
2022-03-23  7:07 ` [bug#54352] [PATCH v3] " Remco van 't Veer
2022-03-24 11:22   ` bug#54352: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735jbjpoj.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=54352@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=remco@remworks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.