From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UG+tJMu2NWIpkgAAgWs5BA (envelope-from ) for ; Sat, 19 Mar 2022 11:56:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oA5JIcu2NWKAuQAAauVa8A (envelope-from ) for ; Sat, 19 Mar 2022 11:56:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44045165AC for ; Sat, 19 Mar 2022 11:56:11 +0100 (CET) Received: from localhost ([::1]:46352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVWkj-0000jH-UD for larch@yhetil.org; Sat, 19 Mar 2022 06:56:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVWkc-0000j9-3S for guix-patches@gnu.org; Sat, 19 Mar 2022 06:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVWkb-00035D-RK for guix-patches@gnu.org; Sat, 19 Mar 2022 06:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVWkb-0006Yr-Jz for guix-patches@gnu.org; Sat, 19 Mar 2022 06:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54352] [PATCH] services: dnsmasq: Add more options. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Mar 2022 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Remco van 't Veer Cc: 54352@debbugs.gnu.org Received: via spool by 54352-submit@debbugs.gnu.org id=B54352.164768731525160 (code B ref 54352); Sat, 19 Mar 2022 10:56:01 +0000 Received: (at 54352) by debbugs.gnu.org; 19 Mar 2022 10:55:15 +0000 Received: from localhost ([127.0.0.1]:59137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVWjq-0006Xk-UA for submit@debbugs.gnu.org; Sat, 19 Mar 2022 06:55:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVWjp-0006XU-7d for 54352@debbugs.gnu.org; Sat, 19 Mar 2022 06:55:13 -0400 Received: from [2001:470:142:3::e] (port=59436 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVWjb-0002oN-S1; Sat, 19 Mar 2022 06:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XERT+/Xa1+m7AW7bQ17guaOF5hklH0z3eiYk468Imhs=; b=kUpp/AIpbDSbH7YWZE5G fh8VfeTsSkvn/TasiOsO1wyVNFApxl1OpSuszYSh6YaMmf2U387FkFPYB4qVu1iyjC/QNjR8OB8qV We0YXTZNlDi1RH4HFD7fo/py10T8T6eUXhW2y+Q1wxxwEXkHVLuYCCcGXrsVGiDFYNO7MegKlxk6P jEmCDgxVriE2yOORz5zUdcun3ArVLVzq45a4XINvJyNAN1W64TqyqPZJpWq+nnpHuD4D6+t3d35oD 8F0IE49gxxmIIl4AEZTS4PrZUf3rpCKEFKq8uuk+KBVwCQw7nF5gA8ri3wEtkQ7OPTFNcdsUJadk3 naSdKFO5U4dYZQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56173 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVWjW-0001gN-LY; Sat, 19 Mar 2022 06:54:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220312154813.5538-1-remco@remworks.net> Date: Sat, 19 Mar 2022 11:54:53 +0100 In-Reply-To: <20220312154813.5538-1-remco@remworks.net> (Remco van t. Veer's message of "Sat, 12 Mar 2022 16:48:13 +0100") Message-ID: <878rt6nreq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647687371; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XERT+/Xa1+m7AW7bQ17guaOF5hklH0z3eiYk468Imhs=; b=JsvzRHRz6jKrbB1nl7ctQB/OAB9qVgeP1BWMRGdJ6qa0qu245nQOLDOV95/ScdqDndmUKB kc0CtgTdf5ZGXOaRWnUbeR3LAtiXsszXYRGeLPJdwkdemeLk3DgBItvcN1TUP+riLMLjfd soF0rX93X+JLOFP4iQxqlPIRHhltK+ec70wCO+JrfAtsqaMUC5qM+aj1jQmZSmhw8/c/1A 5HobMDVHMco/U30VUd+K7BoSxcVmx4QgzkIWE0zu/vv3z6oVVRffipocMtbvWhFsuS2EOm 57va3KpdHV2PfRQWN7Ks+T1KeSOMMs82mqWkpe+YSFO/d9mxOUYTgr5UDRfWpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647687371; a=rsa-sha256; cv=none; b=VaZGTyUBX3NBg9NjaCQH+0u6S0tKBCM/bZ5VDXpRIv6QznR8BFLe+3siv8F7i1mev2rD7D +Rrps3cvBqA1UFd5P6KkRx+5n74DXZ6+NAUu/5x5bBgo3BlbKZ/pkRRhkEBZGWIMxeTkU+ vH8f3ZsA1luinvB07UPkAqROtiuSu3LRkcwQGNWdP7+GjMCEARh1IHQoNS+ktQH1T1Ja4h zHfoH4bZUdJtGt51/nzDEnsRPZrAy2ElbgcEGtikjV/4i3cGVf1Bug/NviRU3bLrBd1+g0 Hi744MmyAQ9nssmqlSvj3e/4v586Tq9Tu+Wt9fNCKzC3dib9OvVvX/tl/nrU1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="kUpp/AIp"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.74 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="kUpp/AIp"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 44045165AC X-Spam-Score: -3.74 X-Migadu-Scanner: scn1.migadu.com X-TUID: aksts/fCuUCB Hi, Remco van 't Veer skribis: > * gnu/services/dns.scm (): Add bogus-priv?, > strict-order? and add-cpe-id options. > (dnsmasq-shepherd-service): Pass bogus-priv, strict-order and add-cpe-id > to the service. > * doc/guix.texi (Guix Services): Document options added to dnsmasq. I don=E2=80=99t use dnsmasq, but overall that LGTM, and a welcome addition. Nitpick: > + (bogus-priv? dnsmasq-configuration-bogus-priv? > + (default #f)) ;boolean I=E2=80=99d rather avoid the abbreviation and use something more descriptiv= e, even if that doesn=E2=80=99t match the name used in the config file. Maybe something like =E2=80=98forward-private-reverse-lookup?=E2=80=99 (I=E2=80= =99m making it up based on the doc you wrote.) WDYT? > + (add-cpe-id dnsmasq-configuration-add-cpe-id > + (default #t)) ;string Maybe =E2=80=98additional-cpe-id=E2=80=99 or =E2=80=98extra-cpe-id=E2=80=99= or =E2=80=98cpe-id=E2=80=99? > (($ package > no-hosts? > port local-service? listen-addresses > - resolv-file no-resolv? servers > - addresses cache-size negative-cache? > + resolv-file no-resolv? bogus-priv? > + strict-order? servers addresses cache-si= ze > + negative-cache? add-cpe-id Not a blocker for this patch, but we should change that to =E2=80=98match-record=E2=80=99, which is less error-prone. Let me know what you think; you can send an updated patch if the suggestions make sense to you. Thanks! Ludo=E2=80=99.