From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kPCENsoPiWPu7wAAbAwnHQ (envelope-from ) for ; Thu, 01 Dec 2022 21:34:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qI1/NsoPiWOjAAAA9RJhRA (envelope-from ) for ; Thu, 01 Dec 2022 21:34:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14BB1E6AB for ; Thu, 1 Dec 2022 21:34:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0qFv-0007p2-Jz; Thu, 01 Dec 2022 15:34:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0qFu-0007og-4D for bug-guix@gnu.org; Thu, 01 Dec 2022 15:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0qFt-0003bU-Qn for bug-guix@gnu.org; Thu, 01 Dec 2022 15:34:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0qFt-0001VM-MM for bug-guix@gnu.org; Thu, 01 Dec 2022 15:34:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Dec 2022 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59423@debbugs.gnu.org, Pierre Langlois Received: via spool by 59423-submit@debbugs.gnu.org id=B59423.16699267985775 (code B ref 59423); Thu, 01 Dec 2022 20:34:01 +0000 Received: (at 59423) by debbugs.gnu.org; 1 Dec 2022 20:33:18 +0000 Received: from localhost ([127.0.0.1]:41763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0qFC-0001V5-A3 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 15:33:18 -0500 Received: from mout.gmx.net ([212.227.15.18]:42669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0qF9-0001Uz-0S for 59423@debbugs.gnu.org; Thu, 01 Dec 2022 15:33:16 -0500 Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MRTN9-1pNkJi3c7Z-00NTmD; Thu, 01 Dec 2022 21:33:07 +0100 References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> <87fse6fmrq.fsf@gmail.com> <87cz995wwu.fsf@gmx.com> <87o7stw2gz.fsf@gmail.com> <87pmd7ceck.fsf@gnu.org> <87sfi2svb9.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Pierre Langlois Date: Thu, 01 Dec 2022 20:29:23 +0000 In-reply-to: <87sfi2svb9.fsf@gmail.com> Message-ID: <878rjqg8zh.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:tJelljKDSakBjaEQRTdMmaSdH6iYWM1bnw9YImvHTQadlhAve9K ym4gBFSfVSy0WV3t76WZvXhhROyXTuNQ6HhqNREelVXjJ9u1CXnBEN2BNadm/Ww5nHz2Xye 03+oRXc1ABpzxIzKI4GjuQkl4n1OFxrTyaFDltEQym8dai8+GU6XWIsEgTAOk3h0/Daan8R YE2MPAVjoq8uBziUGytsw== UI-OutboundReport: notjunk:1;M01:P0:5P+KtyT6yT4=;z2clTlYhPcz65DM47OZVFgWjVfK 6m72hZVa+XySrAPLzkDoCstMh2E5T4YoGbAyWL+Y2hYwe39vLIwog7yekaxAdT5ugyn8dq7q8 ojVv3tZzk9XNMlUz8bRLD9HAPvQLIvOJbn+YieRM/Fv+uAHukTP7WU0QUoWWa3akTJwNR5yMZ UVBZoUTkq8f++VvcHETpvlHlasqnofD/ET6oW1mVAUOS2SGQn0ICIadFdOcU3Bl4Io10HcGP9 csunojbT2rztA+KkMuSlGc59gOIY1ZQ78oOySGx5PXeqoj5l+OITHY3v+pmZ2AwDbZ2YAl83h PAcu0ccQBDbWBY6Io9W6/HGJHH8gAcjwwAqYEr5RKAZbEglsWxMfyCksoyyWyE3YR2NKUZK+X zSUB+IH8wSY0dMoFN2dAIqccFKnPzp8vbSVWzR47p1v6I5WinddXjd9N4pUMCK9apbJ4byw/8 kCkqlX32WLA3kIyHnQvwOQJCMi7q0+zwbsOBdGSP4LjDIITddiqXmd7U9Mnyb5FJaPjNB0SN2 Bozo1wWFBg0dHTv5zkXgcd61hBB0VJVNYpw7OTrmNqL8O2LPmg4PpGucLTcf+U++M6KTITpSm K9WnjiLLqUpA9k6T0gpsCASrs3YMmc5/ikGpVeI3gtKuODgFBPjCBmQ3iJAd3pKAK3yNf2uiy i3dJjMqA4145I7asgpHlUzeYCGgthVm2lhJFQT2rKhFURe1Bk8xNkEDO36yyjsomlDzLhMGkK FrVHrMOJQ3S9d3Q0i8+HUSiTjuuEf7utxNmuaQUfZAWtVse1YQSrsw4PdwqZE4vH75ol+xbmu 8TJjKRqH2S+CAS4k8sULPtDeQJhSiv3PXIEfO5OrHUgVjgOibWdgcOTMjVUvs0e5HpL3dh/Lx Wl9GIx/1BMBiSP1j18c7532SGynYHYamOUMmFddn3O6y8dZM7ZZmh8j426pNniw8tO8Qr1+VO 7qgKvg4KLAxhHTxmc6g0FMmsqSI= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-TUID: INfNx0tHOJW6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > Hi Ludovic, > > Ludovic Court=C3=A8s writes: > >> Hi, >> >> Maxim Cournoyer skribis: >> >>>>> The issue seems to be with the serialization of the >>>>> object nested in the >>>>> record. I tried this at the REPL: >>>>> >>>>> scheme@(guile-user)> ,m (gnu services mail) >>>>> scheme@(gnu services mail)> (namespace-configuration (name "inbox")) >>>>> $8 =3D #< name: "inbox" type: "private" >>>>> separator: "" prefix: "" location: "" inbox?: #f hidden?: #f >>>>> list?: #t subscriptions?: #t mailboxes: () %location: #f> >>>>> scheme@(gnu services mail)> (serialize-configuration $8 namespace-con= figuration-fields) >>>>> name=3Dinbox >>>>> type=3Dprivate >>>>> separator=3D >>>>> prefix=3D >>>>> location=3D#f >>>> >>>> The location here should probably be empty rather than `#f' no? It loo= ks >>>> as though the value is coming from the internal %location, rather than >>>> the user-provided location. >> >> Uh. >> >>>> I'll if I can find anything the macro, it looks quite complex to me :-= ). >>> >>> It's not only to you, if that helps. It's rather... intimidating ^^'. >> >> [...] >> >>> Ludovic, would you have an idea of where the %location field or its >>> CONFIGURATION-location accessor come into play? >> >> We have this: >> >> (define-record-type* #,(id #'stem #'< #'stem #'>) >> stem >> #,(id #'stem #'make- #'stem) >> #,(id #'stem #'stem #'?) >> #,@(map (lambda (name getter def) >> #`(#,name #,getter (default #,def) >> (sanitize >> #,(id #'stem #'validate- #'stem #'- name= )))) >> #'(field ...) >> #'(field-getter ...) >> #'(field-default ...)) >> (%location #,(id #'stem #'stem #'-location) >> (default (and=3D> (current-source-location) >> source-properties->location)) >> (innate))) >> >> That generates two accessors called =E2=80=98namespace-configuration-loc= ation=E2=80=99. >> The second one shadows the first one. > > Yes. You didn't address my question directly though, so let me ask it > again: where is this %location field access (named "location") used? It > seems nowhere. Thus, we can simply rename it without impacting > anything, right (except theoretical usages in the wild, since in the > API). > >> With commit 44554e7133aa60e1b453436be1e80394189cabd9, the second one >> is the =E2=80=9Cwrong=E2=80=9D one: =E2=80=98namespace-configuration-loc= ation=E2=80=99 now returns the >> =E2=80=98%location=E2=80=99 field, not the user-specified =E2=80=98locat= ion=E2=80=99 field. (I >> reported that issue in .) >> >> What do you think of reverting 44554e7133aa60e1b453436be1e80394189cabd9? > > No. If we revert something, it won't be that whole commit, but just the > moving of the field in the define-configuration produced record. If we don't have an obvious solution to the issue and it may need more time, how do you feel about reverting the changes? Unless there is a work around that could be applied until a nicer more permanent solution is found (although those temporary fixes do tend to stick around sometimes :-) ). Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmOJD4IYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UdmEIAKCNdfejC57nQg0O6it/1Dnb lblErihr6bIM/GDJTAztq6gMz5l6uAJDclk29tdNYhX9DYnLq204icIi6AwgOgqO HPMZFulMkyUtpv3DEgw+nnA1Nxc3qvi8Ypar8Di7zGKMWkc+pGYhNNsS4NEDFkNQ 36RP4c3qrwSippf56dLhXnHezrQs7rv5rgBqDXHXQdDFnnr0iqKOELoBzXCLQW1K uMeVlynhXgi3FuabpV2qBK2n3iUWhhuXurxxh89p1vcSGzqCmwk1jIZIUgML/9LK pajihOFEVjIjZpC+SomZwfDCUFVTmoWGnbJolte9Cj59SPcQIRqlNn1i0muv6+U= =YENY -----END PGP SIGNATURE----- --=-=-=--