From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 39786@debbugs.gnu.org
Subject: [bug#39786] [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 17:46:17 +0100 [thread overview]
Message-ID: <877dzd8xly.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <f1eff2393c8504d3d55ff08b82d57b69a05e3472.camel@zrythm.org> (Alexandros Theodotou's message of "Tue, 25 Feb 2020 15:20:12 +0000")
Hello,
Alexandros Theodotou <alex@zrythm.org> writes:
> This patch adds dragonfly reverb, a popular reverb plugin.
Thank you!
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (vst (string-append out "/lib/vst"))
> + (lv2 (string-append out "/lib/lv2")))
> + (mkdir-p bin)
> + (mkdir-p vst)
> + (mkdir-p lv2)
> +
> + ;; Install VST
> + (for-each
> + (lambda (file)
> + (install-file file vst))
> + (find-files "bin" "\\-vst.so$"))
Since you use `install-file' you don't need to `mkdir-p' beforehand,
i.e., you can drop (mkdir-p vst) above.
> + ;; Install standalone
> + (install-file "bin/DragonflyRoomReverb" bin)
> + (install-file "bin/DragonflyHallReverb" bin)
Ditto, you can drop (mkdir-p bin).
> + #t))))))
> + (inputs
> + `(("jack" ,jack-1)
> + ("libx11" ,libx11)
> + ("mesa" ,mesa)))
> + (native-inputs
> + `(("lv2" ,lv2)
> + ("pkg-config" ,pkg-config)))
> + (synopsis "Concert hall reverb and room reverb effects")
> + (description
> + "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as VST and LV2 plugins,
You need to add two spaces after full stops.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-21 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 15:20 [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
2020-02-26 21:49 ` [bug#39786] Acknowledgement ([PATCH] Add dragonfly-reverb.) Alexandros Theodotou
2020-03-21 16:46 ` Nicolas Goaziou [this message]
2020-03-21 19:09 ` [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
2020-03-21 20:55 ` bug#39786: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dzd8xly.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=39786@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.