From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51398)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFhH5-0001oi-6n
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:47:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFhH4-0003gY-8t
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:47:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41928)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFhH4-0003gR-5D
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFhH4-00077r-36
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:47:02 -0400
Subject: [bug#39786] [PATCH] Add dragonfly-reverb.
Resent-Message-ID: <handler.39786.B39786.158480918727314@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <f1eff2393c8504d3d55ff08b82d57b69a05e3472.camel@zrythm.org>
Date: Sat, 21 Mar 2020 17:46:17 +0100
In-Reply-To: <f1eff2393c8504d3d55ff08b82d57b69a05e3472.camel@zrythm.org>
 (Alexandros Theodotou's message of "Tue, 25 Feb 2020 15:20:12 +0000")
Message-ID: <877dzd8xly.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 39786@debbugs.gnu.org

Hello,

Alexandros Theodotou <alex@zrythm.org> writes:

> This patch adds dragonfly reverb, a popular reverb plugin.

Thank you!

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out   (assoc-ref outputs "out"))
> +                    (bin   (string-append out "/bin"))
> +                    (vst   (string-append out "/lib/vst"))
> +                    (lv2   (string-append out "/lib/lv2")))
> +               (mkdir-p bin)
> +               (mkdir-p vst)
> +               (mkdir-p lv2)
> +
> +               ;; Install VST
> +               (for-each
> +                 (lambda (file)
> +                   (install-file file vst))
> +                 (find-files "bin" "\\-vst.so$"))

Since you use `install-file' you don't need to `mkdir-p' beforehand,
i.e., you can drop (mkdir-p vst) above.

> +               ;; Install standalone
> +               (install-file "bin/DragonflyRoomReverb" bin)
> +               (install-file "bin/DragonflyHallReverb" bin)

Ditto, you can drop (mkdir-p bin).

> +               #t))))))
> +    (inputs
> +     `(("jack" ,jack-1)
> +       ("libx11" ,libx11)
> +       ("mesa" ,mesa)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as VST and LV2 plugins,

You need to add two spaces after full stops.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou