From: Alexandros Theodotou <alex@zrythm.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39786@debbugs.gnu.org
Subject: [bug#39786] [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 19:09:48 +0000 [thread overview]
Message-ID: <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org> (raw)
In-Reply-To: <877dzd8xly.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 1951 bytes --]
Hi,
Thanks for the feedback.
Attaching the updated patch. I also removed some unneeded dependencies.
Thanks,
Alex
2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました:
> Hello,
>
> Alexandros Theodotou <alex@zrythm.org> writes:
>
> > This patch adds dragonfly reverb, a popular reverb plugin.
>
> Thank you!
>
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (vst (string-append out "/lib/vst"))
> > + (lv2 (string-append out "/lib/lv2")))
> > + (mkdir-p bin)
> > + (mkdir-p vst)
> > + (mkdir-p lv2)
> > +
> > + ;; Install VST
> > + (for-each
> > + (lambda (file)
> > + (install-file file vst))
> > + (find-files "bin" "\\-vst.so$"))
>
> Since you use `install-file' you don't need to `mkdir-p' beforehand,
> i.e., you can drop (mkdir-p vst) above.
>
> > + ;; Install standalone
> > + (install-file "bin/DragonflyRoomReverb" bin)
> > + (install-file "bin/DragonflyHallReverb" bin)
>
> Ditto, you can drop (mkdir-p bin).
>
> > + #t))))))
> > + (inputs
> > + `(("jack" ,jack-1)
> > + ("libx11" ,libx11)
> > + ("mesa" ,mesa)))
> > + (native-inputs
> > + `(("lv2" ,lv2)
> > + ("pkg-config" ,pkg-config)))
> > + (synopsis "Concert hall reverb and room reverb effects")
> > + (description
> > + "Dragonfly Reverb is a bundle of two free audio effects: a
> > concert
> > +hall reverb and a room reverb. Both are available as VST and LV2
> > plugins,
>
> You need to add two spaces after full stops.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #1.2: 0001-gnu-Add-dragonfly-reverb.patch --]
[-- Type: text/x-patch, Size: 2824 bytes --]
From 194140d3bb34df369c585968c5ee2c93a4b41f15 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Tue, 25 Feb 2020 15:17:10 +0000
Subject: [PATCH] gnu: Add dragonfly-reverb
* gnu/packages/music.scm (dragonfly-reverb): New variable.
---
gnu/packages/music.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 16e69840df..1bdd905f77 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5189,3 +5189,55 @@ featureful and easy to use. It offers unlimited automation options, LV2
plugin support, JACK support and chord assistance.")
(home-page "https://www.zrythm.org")
(license license:agpl3+)))
+
+(define-public dragonfly-reverb
+ (package
+ (name "dragonfly-reverb")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/michaelwillis/dragonfly-reverb.git")
+ (commit version)
+ ;; bundles a specific commit of the DISTRHO plugin framework
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1qrbv4kk5v6ynx424h1i54qj0w8v6vpw81b759jawxvzzprpgq72"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no check target
+ #:make-flags (list "CC=gcc")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure target
+ (replace 'install ; no install target
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (lv2 (string-append out "/lib/lv2")))
+ ;; Install LV2
+ (for-each
+ (lambda (file)
+ (copy-recursively file (string-append lv2 "/"
+ (basename file))))
+ (find-files "bin" "\\.lv2$" #:directories? #t))
+ ;; Install standalone
+ (install-file "bin/DragonflyRoomReverb" bin)
+ (install-file "bin/DragonflyHallReverb" bin)
+ #t))))))
+ (inputs
+ `(("jack" ,jack-1)
+ ("libx11" ,libx11)
+ ("mesa" ,mesa)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (synopsis "Concert hall reverb and room reverb effects")
+ (description
+ "Dragonfly Reverb is a bundle of two free audio effects: a concert
+hall reverb and a room reverb. Both are available as LV2 plugins as well
+as JACK standalone applications.")
+ (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
+ (license license:gpl3+)))
--
2.25.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-21 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 15:20 [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
2020-02-26 21:49 ` [bug#39786] Acknowledgement ([PATCH] Add dragonfly-reverb.) Alexandros Theodotou
2020-03-21 16:46 ` [bug#39786] [PATCH] Add dragonfly-reverb Nicolas Goaziou
2020-03-21 19:09 ` Alexandros Theodotou [this message]
2020-03-21 20:55 ` bug#39786: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org \
--to=alex@zrythm.org \
--cc=39786@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.