From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 39619-done@debbugs.gnu.org
Subject: bug#39619: [v2] Re: bug#39619: Acknowledgement ([PATCH 0/4] Add nheko matrix client)
Date: Sun, 23 Feb 2020 00:48:34 +0100 [thread overview]
Message-ID: <875zfydvzh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zhdbk3ib.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> ("Nicolò Balzarotti"'s message of "Fri, 21 Feb 2020 22:57:16 +0100")
Hello,
Nicolò Balzarotti <anothersms@gmail.com> writes:
> lmdbxx was patch #3, but I created some noise sending replying to
> guix-patches and creating multiple issues. I'm sending it again with
> other fixes applied.
OK. I applied your patches with the two small changes below:
> + (add-before 'configure 'disable-network-tests
> + (lambda _
> + (substitute* "CMakeLists.txt"
> + (("add_test\\([BasicConnectivity|ClientAPI|MediaAPI|Encryption]")
> + "# add_test"))
I changed the regexp to:
"add_test\\((BasicConnectivity|ClientAPI|MediaAPI|Encryption)"
instead.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/drycpp/lmdbxx.git")
> + (commit (string-append version))))
I removed the `string-append' call.
I also added copyright lines for you in "cpp.scm" and "databases.scm".
Thank you!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-02-22 23:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 21:23 [bug#39619] [PATCH 0/4] Add nheko matrix client nixo
[not found] ` <handler.39619.B.158180183921379.ack@debbugs.gnu.org>
2020-02-15 21:30 ` [bug#39619] [PATCH 1/4] gnu: Add mtxclient nixo
2020-02-15 21:30 ` [bug#39619] [PATCH 2/4] gnu: Add tweeny nixo
[not found] ` <handler.39621.B.158180225922123.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39621: Acknowledgement ([PATCH 2/4] gnu: Add tweeny.) Nicolò Balzarotti
2020-02-15 21:30 ` [bug#39622] [PATCH 3/4] gnu: Add lmdbxx nixo
[not found] ` <handler.39622.B.158180225922130.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39622: Acknowledgement ([PATCH 3/4] gnu: Add lmdbxx.) Nicolò Balzarotti
2020-02-15 21:30 ` [bug#39623] [PATCH 4/4] gnu: Add nheko nixo
[not found] ` <handler.39623.B.158180226322189.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39623: Acknowledgement ([PATCH 4/4] gnu: Add nheko.) Nicolò Balzarotti
[not found] ` <handler.39620.B.158180225622091.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39620: Acknowledgement ([PATCH 1/4] gnu: Add mtxclient.) Nicolò Balzarotti
2020-02-16 0:09 ` [bug#39619] Acknowledgement ([PATCH 0/4] Add nheko matrix client) Nicolò Balzarotti
2020-02-18 9:22 ` [bug#39619] [v2] Re: bug#39619: " Nicolò Balzarotti
2020-02-21 16:58 ` Nicolas Goaziou
2020-02-21 21:57 ` Nicolò Balzarotti
2020-02-22 23:48 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zfydvzh.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=39619-done@debbugs.gnu.org \
--cc=anothersms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.