From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 39619@debbugs.gnu.org
Subject: [bug#39619] [v2] Re: bug#39619: Acknowledgement ([PATCH 0/4] Add nheko matrix client)
Date: Fri, 21 Feb 2020 17:58:19 +0100 [thread overview]
Message-ID: <874kvjg9n8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87pnecs0zx.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> ("Nicolò Balzarotti"'s message of "Tue, 18 Feb 2020 10:22:58 +0100")
Hello,
Nicolò Balzarotti <anothersms@gmail.com> writes:
> I just noticed that nlohmann-json-cpp is deprecated for json-modern-cxx,
> fixed it in the two patches that were using it.
Thank you for the patches.
Unfortunately, I cannot build nheko because of a missing lmdbxx input.
Some comments follow.
> + (lambda _
> + (substitute* "CMakeLists.txt"
> + (("add_test\\(BasicConnectivity") "# add_test")
> + (("add_test\\(ClientAPI") "# add_test")
> + (("add_test\\(MediaAPI") "# add_test")
> + (("add_test\\(Encryption") "# add_test"))
Nitpick: I suggest to use a single regexp for these.
> + (inputs
> + `(("boost" ,boost)
> + ("libolm" ,libolm)
> + ("libsodium" ,libsodium)
> + ("openssl" ,openssl)
> + ("json-modern-cxx" ,json-modern-cxx)
> + ("spdlog" ,spdlog)
> + ("zlib" ,zlib)))
Could you re-order inputs alphabetically?
> + (description "@code{mtxclient} is a C++ library that implements client API
> +for the Matrix protocol. It's built on to of @code{Boost.Asio}.")
Nitpick: "It's" -> "It is".
> + (license license:expat)))
> +
> (define-public quaternion
> (package
> (name "quaternion")
> @@ -1795,8 +1849,8 @@ QMatrixClient project.")
> (origin
> (method git-fetch)
> (uri (git-reference
> - (url "https://github.com/QMatrixClient/Quaternion")
> - (commit version)))
> + (url "https://github.com/QMatrixClient/Quaternion")
> + (commit version)))
This change is unrelated to the patch. Could you remove it?
> + (inputs
> + `(("boost" ,boost)
> + ("cmark" ,cmark)
> + ("libolm" ,libolm)
> + ("lmdb" ,lmdb)
> + ("lmdbxx" ,lmdbxx)
What is that?
> + ("mtxclient" ,mtxclient)
> + ("openssl" ,openssl)
> + ("json-modern-cxx" ,json-modern-cxx)
> + ("qtbase" ,qtbase)
> + ("qtsvg" ,qtsvg)
> + ("qtmultimedia" ,qtmultimedia)
> + ("spdlog" ,spdlog)
> + ("tweeny" ,tweeny)
> + ("zlib" ,zlib)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("qtlinguist" ,qttools)))
Isn't it a bit confusing?
> + (build-system qt-build-system)
Nitpick: usually, build-system is above inputs and arguments.
> + (home-page "https://github.com/Nheko-Reborn/nheko")
> + (synopsis "Desktop client for Matrix using Qt and C++14")
> + (description "@code{Nheko} want to provide a native desktop app for the
> +Matrix protocol that feels more like a mainstream chat app and less like an IRC
> +client.
"that feels more..." sounds link marketing buzz. Maybe we could remove it.
> +Most of the features you would expect from a chat application are missing right
> +now but we are getting close to a more feature complete client.
I'm not sure this part is warranted either.
> Specifically
> +there is support for:
> +@itemize
> +@item E2E encryption (text messages only: attachments are currently sent unencrypted).
> +@item User registration.
> +@item Creating, joining & leaving rooms.
> +@item Sending & receiving invites.
> +@item Sending & receiving files and emoji.
> +@item Typing notifications.
> +@item Username auto-completion.
> +@item Message & mention notifications.
> +@item Redacting messages.
> +@item Read receipts.
> +@item Basic communities support.
> +@item Room switcher (@key{ctrl-K}).
> +@item Light, Dark & System themes.
> +@end itemize\n")
No need for the final newline.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-02-21 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 21:23 [bug#39619] [PATCH 0/4] Add nheko matrix client nixo
[not found] ` <handler.39619.B.158180183921379.ack@debbugs.gnu.org>
2020-02-15 21:30 ` [bug#39619] [PATCH 1/4] gnu: Add mtxclient nixo
2020-02-15 21:30 ` [bug#39619] [PATCH 2/4] gnu: Add tweeny nixo
[not found] ` <handler.39621.B.158180225922123.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39621: Acknowledgement ([PATCH 2/4] gnu: Add tweeny.) Nicolò Balzarotti
2020-02-15 21:30 ` [bug#39622] [PATCH 3/4] gnu: Add lmdbxx nixo
[not found] ` <handler.39622.B.158180225922130.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39622: Acknowledgement ([PATCH 3/4] gnu: Add lmdbxx.) Nicolò Balzarotti
2020-02-15 21:30 ` [bug#39623] [PATCH 4/4] gnu: Add nheko nixo
[not found] ` <handler.39623.B.158180226322189.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39623: Acknowledgement ([PATCH 4/4] gnu: Add nheko.) Nicolò Balzarotti
[not found] ` <handler.39620.B.158180225622091.ack@debbugs.gnu.org>
2020-02-15 21:34 ` bug#39620: Acknowledgement ([PATCH 1/4] gnu: Add mtxclient.) Nicolò Balzarotti
2020-02-16 0:09 ` [bug#39619] Acknowledgement ([PATCH 0/4] Add nheko matrix client) Nicolò Balzarotti
2020-02-18 9:22 ` [bug#39619] [v2] Re: bug#39619: " Nicolò Balzarotti
2020-02-21 16:58 ` Nicolas Goaziou [this message]
2020-02-21 21:57 ` Nicolò Balzarotti
2020-02-22 23:48 ` bug#39619: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kvjg9n8.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=39619@debbugs.gnu.org \
--cc=anothersms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.