From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56226)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5eW8-0000t8-8s
 for guix-patches@gnu.org; Sat, 22 Feb 2020 18:49:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5eW7-0007Ig-7J
 for guix-patches@gnu.org; Sat, 22 Feb 2020 18:49:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:44247)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j5eW6-0007Hp-3k
 for guix-patches@gnu.org; Sat, 22 Feb 2020 18:49:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5eW6-00079c-2H
 for guix-patches@gnu.org; Sat, 22 Feb 2020 18:49:02 -0500
Subject: bug#39619: [v2] Re: bug#39619: Acknowledgement ([PATCH 0/4] Add nheko
 matrix client)
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.39619.D39619.158241532427468.done@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200215212305.20862-1-nicolo@nixo.xyz>
 <handler.39619.B.158180183921379.ack@debbugs.gnu.org>
 <87pnecs0zx.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
 <874kvjg9n8.fsf@nicolasgoaziou.fr>
 <87zhdbk3ib.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sun, 23 Feb 2020 00:48:34 +0100
In-Reply-To: <87zhdbk3ib.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
 ("=?UTF-8?Q?Nicol=C3=B2?= Balzarotti"'s message of "Fri, 21 Feb 2020
 22:57:16 +0100")
Message-ID: <875zfydvzh.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti <anothersms@gmail.com>
Cc: 39619-done@debbugs.gnu.org

Hello,

Nicol=C3=B2 Balzarotti <anothersms@gmail.com> writes:

> lmdbxx was patch #3, but I created some noise sending replying to
> guix-patches and creating multiple issues.  I'm sending it again with
> other fixes applied.

OK. I applied your patches with the two small changes below:
> +         (add-before 'configure 'disable-network-tests
> +           (lambda _
> +             (substitute* "CMakeLists.txt"
> +               (("add_test\\([BasicConnectivity|ClientAPI|MediaAPI|Encry=
ption]")
> +                "# add_test"))

I changed the regexp to:

  "add_test\\((BasicConnectivity|ClientAPI|MediaAPI|Encryption)"

instead.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/drycpp/lmdbxx.git")
> +                    (commit (string-append version))))

I removed the `string-append' call.

I also added copyright lines for you in "cpp.scm" and "databases.scm".

Thank you!

Regards,

--=20
Nicolas Goaziou