From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 41181@debbugs.gnu.org
Cc: rdes@protonmail.com
Subject: [bug#41181] adds emacs-interleave
Date: Mon, 11 May 2020 09:10:25 +0200 [thread overview]
Message-ID: <875zd3x7z2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <Adm0HTLwEn9xKescmC35WTpS2d1P5dDE70m0dgz-HaHQuYy4R9PbAL-5-2TmWSS3KhX3wo4hpytXs-i7hsfQAkt2F2gZuQ31_hbTalaLekg=@protonmail.com> (rdes via Guix-patches via's message of "Sun, 10 May 2020 19:35:17 +0000")
Hello,
rdes via Guix-patches via <guix-patches@gnu.org> writes:
> The attached patch adds the emacs-interleave package.
Thank you! Some comments follow.
> Subject: [PATCH] gnu: Add emacs-interleave
Your commit message should conform to Guix rules. Here, you need to add
* gnu/packages/emacs-xyz.scm (emacs-interleave): New variable.
> +(define-public emacs-interleave
> +(package
Indentation seems wrong.
> + (name "emacs-interleave")
> + (version "20191129.958")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://melpa.org/packages/interleave-"
> + version
> + ".el"))
We do not use MELPA sources. Instead, you could use `git-fetch' and
extract the latest stable release from here:
https://github.com/rudolfochrist/interleave/releases
> + (sha256
> + (base32
> + "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8"))))
Nitpick: could you move the string on the same line as `base32'?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/rudolfochrist/interleave")
Ditto. Could you move the string on the line above?
> + (synopsis "Interleaving text books since 2015")
I think this synopsis needs to be reworded. As it is, it may not be
useful.
> + (description
> + "Interleave presents your PDF side by side to an [[http://orgmode.org][Org Mode]]
Description uses Texinfo syntax, not Org syntax. In this case, however,
I think "side by side to an Org buffer" is sufficient.
> +buffer with your notes, narrowing down to just those passages that are relevant to
> +the particular page in the document viewer.
> +")
You don't need to end the description with a final newline. It would be
nice to expound it a bit. For example, it could be interesting to know
this is a minor mode.
Don't forget to add a copyright line with your name at the top of the file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-11 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 19:35 [bug#41181] adds emacs-interleave rdes via Guix-patches via
2020-05-11 7:10 ` Nicolas Goaziou [this message]
2020-05-15 20:56 ` rdes via Guix-patches via
2020-05-17 13:18 ` rdes via Guix-patches via
2020-05-17 23:00 ` Nicolas Goaziou
2020-05-22 1:42 ` rdes via Guix-patches via
2020-05-25 11:43 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zd3x7z2.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41181@debbugs.gnu.org \
--cc=rdes@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.