From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Xg4iD4T6uF5RCwAA0tVLHw (envelope-from ) for ; Mon, 11 May 2020 07:11:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2CpSBZL6uF7cJQAA1q6Kng (envelope-from ) for ; Mon, 11 May 2020 07:11:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A551941220 for ; Mon, 11 May 2020 07:11:11 +0000 (UTC) Received: from localhost ([::1]:56456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jY2ak-0004Ic-PX for larch@yhetil.org; Mon, 11 May 2020 03:11:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY2ad-0004GW-8L for guix-patches@gnu.org; Mon, 11 May 2020 03:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jY2ac-0000eg-UO for guix-patches@gnu.org; Mon, 11 May 2020 03:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jY2ac-0004wo-Q1 for guix-patches@gnu.org; Mon, 11 May 2020 03:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 May 2020 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 41181@debbugs.gnu.org Cc: rdes@protonmail.com X-Debbugs-Original-To: rdes via Guix-patches via X-Debbugs-Original-Cc: 41181@debbugs.gnu.org, rdes Received: via spool by 41181-submit@debbugs.gnu.org id=B41181.158918103318958 (code B ref 41181); Mon, 11 May 2020 07:11:02 +0000 Received: (at 41181) by debbugs.gnu.org; 11 May 2020 07:10:33 +0000 Received: from localhost ([127.0.0.1]:51062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY2a9-0004vd-Fl for submit@debbugs.gnu.org; Mon, 11 May 2020 03:10:33 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY2a8-0004vI-JQ for 41181@debbugs.gnu.org; Mon, 11 May 2020 03:10:32 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5D790240003; Mon, 11 May 2020 07:10:25 +0000 (UTC) From: Nicolas Goaziou References: Date: Mon, 11 May 2020 09:10:25 +0200 In-Reply-To: (rdes via Guix-patches via's message of "Sun, 10 May 2020 19:35:17 +0000") Message-ID: <875zd3x7z2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53930976515085]; HAS_XOIP(0.00)[]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.07), country: US(-0.00), ip: 209.51.188.17(-0.54)]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email,melpa.org:url,orgmode.org:url]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; FREEMAIL_CC(0.00)[protonmail.com]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: Eszfm5jmPKof Hello, rdes via Guix-patches via writes: > The attached patch adds the emacs-interleave package. Thank you! Some comments follow. > Subject: [PATCH] gnu: Add emacs-interleave Your commit message should conform to Guix rules. Here, you need to add * gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > +(define-public emacs-interleave > +(package Indentation seems wrong. > + (name "emacs-interleave") > + (version "20191129.958") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://melpa.org/packages/interleave-" > + version > + ".el")) We do not use MELPA sources. Instead, you could use `git-fetch' and extract the latest stable release from here: https://github.com/rudolfochrist/interleave/releases > + (sha256 > + (base32 > + "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8")))) Nitpick: could you move the string on the same line as `base32'? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/rudolfochrist/interleave") Ditto. Could you move the string on the line above? > + (synopsis "Interleaving text books since 2015") I think this synopsis needs to be reworded. As it is, it may not be useful. > + (description > + "Interleave presents your PDF side by side to an [[http://orgmode.org][Org Mode]] Description uses Texinfo syntax, not Org syntax. In this case, however, I think "side by side to an Org buffer" is sufficient. > +buffer with your notes, narrowing down to just those passages that are relevant to > +the particular page in the document viewer. > +") You don't need to end the description with a final newline. It would be nice to expound it a bit. For example, it could be interesting to know this is a minor mode. Don't forget to add a copyright line with your name at the top of the file. Could you send an updated patch? Regards, -- Nicolas Goaziou