From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: rdes <rdes@protonmail.com>
Cc: 41181@debbugs.gnu.org
Subject: [bug#41181] adds emacs-interleave
Date: Mon, 18 May 2020 01:00:33 +0200 [thread overview]
Message-ID: <87367ytbe6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> (rdes@protonmail.com's message of "Fri, 15 May 2020 20:56:10 +0000")
Hello,
rdes <rdes@protonmail.com> writes:
> Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
> variable.
Thank you for the updated patch. Some comments follow.
> +(define-public emacs-interleave
> + (package
> + (name "emacs-interleave")
> + (version "1.4.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/rudolfochrist/interleave")
> + (commit (string-append "interleave-" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
Could you move the hash on the line above?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/rudolfochrist/interleave")
Could you move the URI on the line above, too?
> + (synopsis
> + "A minor mode that presents a document buffer next to an orgmode buffer")
A synopsis does not start with "A". You may want to use "guix lint" to
spot this.
You might use the summary from the home page:
(synopsis "Emacs minor mode to interleave notes and text books")
> + (description
> + "Interleave is a minor mode that presents a document viewer side
> +by side to an orgmode buffer with your notes relevant to the current
> page.")
"orgmode buffer" -> "an Org buffer"
Could you send an updated patch and merge this with the copyright line
you sent?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-17 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 19:35 [bug#41181] adds emacs-interleave rdes via Guix-patches via
2020-05-11 7:10 ` Nicolas Goaziou
2020-05-15 20:56 ` rdes via Guix-patches via
2020-05-17 13:18 ` rdes via Guix-patches via
2020-05-17 23:00 ` Nicolas Goaziou [this message]
2020-05-22 1:42 ` rdes via Guix-patches via
2020-05-25 11:43 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87367ytbe6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41181@debbugs.gnu.org \
--cc=rdes@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.