all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: rennes <rennes@openmailbox.org>
Cc: 26582@debbugs.gnu.org
Subject: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 23:27:29 +0200	[thread overview]
Message-ID: <874lxilqgu.fsf@gnu.org> (raw)
In-Reply-To: <7cNcVrtMKJzzpdMgOTPW3i@Jrt62lb7BFa+Aa7uPD4Kw> (rennes@openmailbox.org's message of "Thu, 20 Apr 2017 14:31:51 -0500")

rennes <rennes@openmailbox.org> skribis:

> Hi,
>> Also this
>> 
>> >   ,@(if (hurd-triplet? ((or %current-system
>> >                             %current-target-system)))
>> 
>> should be this
>> 
>> >   ,@(if (hurd-triplet? (or (%current-system)
>> >                            (%current-target-system)))
>> 
>
> Fixed!
>
>> Btw trying to build it with `./pre-inst-env guix build
>> --target=i586-pc-gnu pcre' fails with
>> 
>> ** Cannot --enable-pcregrep-libz because zlib.h was not found
>> 
>> Maybe the inputs should become native-inputs?
>
> I moved zlib and readline to 'native-inputs'.

Are you sure they need to be native inputs?  Both are libraries, so I
imagine they’re used at run time, not at build time; they should be
inputs, in this case.

Thoughts?

Ludo’.

  reply	other threads:[~2017-04-20 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  5:12 bug#26575: [PATCH] gnu: pcre: Fix Check for Hurd systems rennes
2017-04-20 14:08 ` Manolis Ragkousis
2017-04-20 19:31   ` bug#26582: " rennes
2017-04-20 21:27     ` Ludovic Courtès [this message]
2017-04-21  2:38       ` rennes
2017-04-22  2:40       ` rennes
2017-04-22 22:13         ` Ludovic Courtès
2017-04-29 22:25           ` rennes
2017-05-01 13:34             ` rennes
2019-02-13 11:58     ` Manolis Ragkousis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lxilqgu.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26582@debbugs.gnu.org \
    --cc=rennes@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.