From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1JcT-0002bu-QW
	for guix-patches@gnu.org; Thu, 20 Apr 2017 17:28:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1JcQ-00006n-Mc
	for guix-patches@gnu.org; Thu, 20 Apr 2017 17:28:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:32991)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d1JcQ-00006f-JA
	for guix-patches@gnu.org; Thu, 20 Apr 2017 17:28:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d1JcQ-0001AB-Ap
	for guix-patches@gnu.org; Thu, 20 Apr 2017 17:28:02 -0400
Subject: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Resent-Message-ID: <handler.26582.B26582.14927236644445@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <7cNcVrtMKJzzpdMgOTPW3i@Jrt62lb7BFa+Aa7uPD4Kw>
Date: Thu, 20 Apr 2017 23:27:29 +0200
In-Reply-To: <7cNcVrtMKJzzpdMgOTPW3i@Jrt62lb7BFa+Aa7uPD4Kw>
	(rennes@openmailbox.org's message of "Thu, 20 Apr 2017 14:31:51
	-0500")
Message-ID: <874lxilqgu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: rennes <rennes@openmailbox.org>
Cc: 26582@debbugs.gnu.org

rennes <rennes@openmailbox.org> skribis:

> Hi,
>> Also this
>>=20
>> >   ,@(if (hurd-triplet? ((or %current-system
>> >                             %current-target-system)))
>>=20
>> should be this
>>=20
>> >   ,@(if (hurd-triplet? (or (%current-system)
>> >                            (%current-target-system)))
>>=20
>
> Fixed!
>
>> Btw trying to build it with `./pre-inst-env guix build
>> --target=3Di586-pc-gnu pcre' fails with
>>=20
>> ** Cannot --enable-pcregrep-libz because zlib.h was not found
>>=20
>> Maybe the inputs should become native-inputs?
>
> I moved zlib and readline to 'native-inputs'.

Are you sure they need to be native inputs?  Both are libraries, so I
imagine they=E2=80=99re used at run time, not at build time; they should be
inputs, in this case.

Thoughts?

Ludo=E2=80=99.