From: ludo@gnu.org (Ludovic Courtès)
To: rennes <rennes@openmailbox.org>
Cc: 26582@debbugs.gnu.org
Subject: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Sun, 23 Apr 2017 00:13:15 +0200 [thread overview]
Message-ID: <87efwkjdl0.fsf@gnu.org> (raw)
In-Reply-To: <2ExjL3FnTH2ActBCbOgZRN@lTC1VtRxjDOEtGzP2P9M4> (rennes@openmailbox.org's message of "Fri, 21 Apr 2017 21:40:03 -0500")
Hi rennes,
rennes <rennes@openmailbox.org> skribis:
> On 04/20/2017 04:27:29 PM, Ludovic Courtès wrote:
>> >
>> > I moved zlib and readline to 'native-inputs'.
>>
>> Are you sure they need to be native inputs? Both are libraries, so I
>> imagine they’re used at run time, not at build time; they should be
>> inputs, in this case.
>>
> I added system types: "--build=" and "--host=" to 'configure'. Now
> detects correctly the inputs.
>
> Built successfully on Linux x86_64, GNU/Hurd and cross-compiling with
> target 'i586-pc-gnu'.
> Thanks for the guide
>
> From 05f159e343173708b85c5e45b6cfe64e3939c68d Mon Sep 17 00:00:00 2001
> From: rennes <rennes@openmailbox.org>
> Date: Fri, 21 Apr 2017 21:22:08 -0500
> Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.
>
> * gnu/packages/pcre.scm (pcre)[arguments]: Add "--disable-stack-for-recursion".
The patch does more than that. :-)
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs build target #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (assoc-ref outputs "bin"))
> + (doc (assoc-ref outputs "doc")))
> + (setenv "CONFIG_SHELL" (which "bash"))
> + (zero?
> + (system* "./configure"
> + (string-append "--prefix=" out)
> + (string-append "--bindir=" bin)
> + (string-append "--docdir=" doc)
> + (string-append "--build=" build)
> + (string-append "--host=" (or target build))
I would expect the ‘configure’ phase in (guix build gnu-build-system) to
already pass those flags, no? (If that is the case we could keep
#:configure-flags instead of replacing the ‘configure’ phase.)
> + ;; On GNU/Hurd systems FAIL 'RunTest' with 'segmentation
> + ;; fault' in Check phase, to pass the test we can disable
> + ;; "--enable-jit" or set "--disable-stack-for-recursion"
> + ;; argument.
> + ,@(if (hurd-triplet? (or (%current-system)
> + ( %current-target-system)))
> + '("--disable-stack-for-recursion")
> + '())))))))))
This part looks OK to me (even better if you have a pointer to an
upstream bug report or discussion.)
Thanks!
Luodo’.
next prev parent reply other threads:[~2017-04-22 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 5:12 bug#26575: [PATCH] gnu: pcre: Fix Check for Hurd systems rennes
2017-04-20 14:08 ` Manolis Ragkousis
2017-04-20 19:31 ` bug#26582: " rennes
2017-04-20 21:27 ` Ludovic Courtès
2017-04-21 2:38 ` rennes
2017-04-22 2:40 ` rennes
2017-04-22 22:13 ` Ludovic Courtès [this message]
2017-04-29 22:25 ` rennes
2017-05-01 13:34 ` rennes
2019-02-13 11:58 ` Manolis Ragkousis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efwkjdl0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26582@debbugs.gnu.org \
--cc=rennes@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.