[bug#32111] [PATCH] daemon: Allow store names to start with a dot.

[bug#32111] [PATCH] daemon: Allow store names to start with a dot.

[Clément Lassieur]

* nix/libstore/store-api.cc (checkStoreName): Disallow only "." and "..".
---
 nix/libstore/store-api.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/nix/libstore/store-api.cc b/nix/libstore/store-api.cc
index 9e07c67e9..1618f1745 100644
--- a/nix/libstore/store-api.cc
+++ b/nix/libstore/store-api.cc
@@ -58,9 +58,8 @@ string storePathToName(const Path & path)
 void checkStoreName(const string & name)
 {
     string validChars = "+-._?=";
-    /* Disallow names starting with a dot for possible security
-       reasons (e.g., "." and ".."). */
-    if (string(name, 0, 1) == ".")
+    /* Disallow "." and ".." for possible security reasons. */
+    if ((name == ".") || (name == ".."))
         throw Error(format("illegal name: `%1%'") % name);
     foreach (string::const_iterator, i, name)
         if (!((*i >= 'A' && *i <= 'Z') ||
-- 
2.18.0

[bug#32111] [PATCH] daemon: Allow store names to start with a dot.

[Nils Gillmann]

Hi,

Can you provide some context why this is necessary, maybe even
in the commit message?

Clément Lassieur transcribed 883 bytes:
> * nix/libstore/store-api.cc (checkStoreName): Disallow only "." and "..".
> ---
>  nix/libstore/store-api.cc | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/nix/libstore/store-api.cc b/nix/libstore/store-api.cc
> index 9e07c67e9..1618f1745 100644
> --- a/nix/libstore/store-api.cc
> +++ b/nix/libstore/store-api.cc
> @@ -58,9 +58,8 @@ string storePathToName(const Path & path)
>  void checkStoreName(const string & name)
>  {
>      string validChars = "+-._?=";
> -    /* Disallow names starting with a dot for possible security
> -       reasons (e.g., "." and ".."). */
> -    if (string(name, 0, 1) == ".")
> +    /* Disallow "." and ".." for possible security reasons. */
> +    if ((name == ".") || (name == ".."))
>          throw Error(format("illegal name: `%1%'") % name);
>      foreach (string::const_iterator, i, name)
>          if (!((*i >= 'A' && *i <= 'Z') ||
> -- 
> 2.18.0
> 
> 
> 
> 

[bug#32111] [PATCH] daemon: Allow store names to start with a dot.

[Clément Lassieur]

Nils Gillmann <ng0@n0.is> writes:

> Hi,
>
> Can you provide some context why this is necessary, maybe even
> in the commit message?

It's necessary when you want to package a program whose source looks
like file:///home/foo/.bar.

Sure, I'll update the commit message.

Clément

[bug#32111] [PATCH] daemon: Allow store names to start with a dot.

[Ludovic Courtès]

Hello Clément,

Clément Lassieur <clement@lassieur.org> skribis:

> Nils Gillmann <ng0@n0.is> writes:
>
>> Hi,
>>
>> Can you provide some context why this is necessary, maybe even
>> in the commit message?
>
> It's necessary when you want to package a program whose source looks
> like file:///home/foo/.bar.

I’d rather not make this kind of change.  In general, I think we should
be very conservative about changes to the daemon and its protocol,
because that’s the common denominator of all the versions of Guix.

If we change something like it, then we’ll get subtle breakage depending
on the version of the daemon in use.

WDYT?

Ludo’.

bug#32132: daemon store names can't start with a dot

[Clément Lassieur]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello Clément,
>
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> Nils Gillmann <ng0@n0.is> writes:
>>
>>> Hi,
>>>
>>> Can you provide some context why this is necessary, maybe even
>>> in the commit message?
>>
>> It's necessary when you want to package a program whose source looks
>> like file:///home/foo/.bar.
>
> I’d rather not make this kind of change.  In general, I think we should
> be very conservative about changes to the daemon and its protocol,
> because that’s the common denominator of all the versions of Guix.
>
> If we change something like it, then we’ll get subtle breakage depending
> on the version of the daemon in use.
>
> WDYT?

Okay, let's abandon this then :-)

CCing bug-guix because I still think it's a bug; please close it if you
disagree.

Clément

bug#32111: daemon store names can't start with a dot

[Clément Lassieur]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello Clément,
>
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> Nils Gillmann <ng0@n0.is> writes:
>>
>>> Hi,
>>>
>>> Can you provide some context why this is necessary, maybe even
>>> in the commit message?
>>
>> It's necessary when you want to package a program whose source looks
>> like file:///home/foo/.bar.
>
> I’d rather not make this kind of change.  In general, I think we should
> be very conservative about changes to the daemon and its protocol,
> because that’s the common denominator of all the versions of Guix.
>
> If we change something like it, then we’ll get subtle breakage depending
> on the version of the daemon in use.
>
> WDYT?

Okay, let's abandon this then :-)

CCing bug-guix because I still think it's a bug; please close it if you
disagree.

Clément

[bug#32111] daemon store names can't start with a dot

[Ludovic Courtès]

Clément Lassieur <clement@lassieur.org> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello Clément,
>>
>> Clément Lassieur <clement@lassieur.org> skribis:
>>
>>> Nils Gillmann <ng0@n0.is> writes:
>>>
>>>> Hi,
>>>>
>>>> Can you provide some context why this is necessary, maybe even
>>>> in the commit message?
>>>
>>> It's necessary when you want to package a program whose source looks
>>> like file:///home/foo/.bar.
>>
>> I’d rather not make this kind of change.  In general, I think we should
>> be very conservative about changes to the daemon and its protocol,
>> because that’s the common denominator of all the versions of Guix.
>>
>> If we change something like it, then we’ll get subtle breakage depending
>> on the version of the daemon in use.
>>
>> WDYT?
>
> Okay, let's abandon this then :-)
>
> CCing bug-guix because I still think it's a bug; please close it if you
> disagree.

Looks like you already closed it (or was it me?).

Anyway, it’s certainly a limitation, but given that it’s an annoyance
more than a showstopper (in my view at least), I’m in favor keeping
things this way for the sake of compatibility.

Ludo’.

bug#32132: daemon store names can't start with a dot

[Clément Lassieur]

Ludovic Courtès <ludo@gnu.org> writes:

> Looks like you already closed it (or was it me?).

Well, I closed 32111 (guix-patches) but I opened 32132 (bug-guix) with a
wontfix tag, so that people can find it easily if they stumble across
the issue.

> Anyway, it’s certainly a limitation, but given that it’s an annoyance
> more than a showstopper (in my view at least), I’m in favor keeping
> things this way for the sake of compatibility.

Agreed :-)