From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id t+DTIefCwV69AwAA0tVLHw (envelope-from ) for ; Sun, 17 May 2020 23:04:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eIqFHefCwV6xdgAAB5/wlQ (envelope-from ) for ; Sun, 17 May 2020 23:04:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF1E9940275 for ; Sun, 17 May 2020 23:04:06 +0000 (UTC) Received: from localhost ([::1]:53772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaSKD-0006nm-34 for larch@yhetil.org; Sun, 17 May 2020 19:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaSHG-0006hp-0V for guix-patches@gnu.org; Sun, 17 May 2020 19:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaSHF-0004jb-Nk for guix-patches@gnu.org; Sun, 17 May 2020 19:01:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaSHF-0000xJ-NQ for guix-patches@gnu.org; Sun, 17 May 2020 19:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 May 2020 23:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: rdes Cc: 41181@debbugs.gnu.org X-Debbugs-Original-Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.15897564543653 (code B ref -1); Sun, 17 May 2020 23:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2020 23:00:54 +0000 Received: from localhost ([127.0.0.1]:45086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaSH8-0000wr-1k for submit@debbugs.gnu.org; Sun, 17 May 2020 19:00:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:52824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaSH5-0000wj-Qp for submit@debbugs.gnu.org; Sun, 17 May 2020 19:00:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaSH5-0006gY-3j for guix-patches@gnu.org; Sun, 17 May 2020 19:00:51 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaSH1-0004aN-6i for guix-patches@gnu.org; Sun, 17 May 2020 19:00:49 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 2BAEFFF808; Sun, 17 May 2020 23:00:34 +0000 (UTC) From: Nicolas Goaziou References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> Date: Mon, 18 May 2020 01:00:33 +0200 In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> (rdes@protonmail.com's message of "Fri, 15 May 2020 20:56:10 +0000") Message-ID: <87367ytbe6.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 19:00:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: i3mDxHg9zWIu Hello, rdes writes: > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New > variable. Thank you for the updated patch. Some comments follow. > +(define-public emacs-interleave > + (package > + (name "emacs-interleave") > + (version "1.4.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/rudolfochrist/interleave") > + (commit (string-append "interleave-" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb")))) Could you move the hash on the line above? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/rudolfochrist/interleave") Could you move the URI on the line above, too? > + (synopsis > + "A minor mode that presents a document buffer next to an orgmode buffer") A synopsis does not start with "A". You may want to use "guix lint" to spot this. You might use the summary from the home page: (synopsis "Emacs minor mode to interleave notes and text books") > + (description > + "Interleave is a minor mode that presents a document viewer side > +by side to an orgmode buffer with your notes relevant to the current > page.") "orgmode buffer" -> "an Org buffer" Could you send an updated patch and merge this with the copyright line you sent? Regards, -- Nicolas Goaziou