From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +HxiHp6YOGLPDwAAgWs5BA (envelope-from ) for ; Mon, 21 Mar 2022 16:24:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ACw/F56YOGLqXQEAG6o9tA (envelope-from ) for ; Mon, 21 Mar 2022 16:24:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D1AE17F7B for ; Mon, 21 Mar 2022 16:24:14 +0100 (CET) Received: from localhost ([::1]:57106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWJtF-0000W4-2c for larch@yhetil.org; Mon, 21 Mar 2022 11:24:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWJs6-0008MI-Tm for guix-patches@gnu.org; Mon, 21 Mar 2022 11:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWJs6-0007oJ-Lb for guix-patches@gnu.org; Mon, 21 Mar 2022 11:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWJs6-0002Kf-DI for guix-patches@gnu.org; Mon, 21 Mar 2022 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54352] [PATCH] services: dnsmasq: Add more options. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Mar 2022 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54352@debbugs.gnu.org, Remco van 't Veer Received: via spool by 54352-submit@debbugs.gnu.org id=B54352.16478761678930 (code B ref 54352); Mon, 21 Mar 2022 15:23:02 +0000 Received: (at 54352) by debbugs.gnu.org; 21 Mar 2022 15:22:47 +0000 Received: from localhost ([127.0.0.1]:37892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJrr-0002Jy-Fm for submit@debbugs.gnu.org; Mon, 21 Mar 2022 11:22:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWJrp-0002Jm-JC for 54352@debbugs.gnu.org; Mon, 21 Mar 2022 11:22:46 -0400 Received: from [2001:470:142:3::e] (port=44224 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWJrj-0007m6-7J; Mon, 21 Mar 2022 11:22:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+wvuD6wR6lDXtgmXJezOw3nXkXOGFA2ugu2IjUXWeVY=; b=Rh8dpZvVP1VFo+JIvAyp OvIQvGTr/oJWK8KDxmWLyaLNBSbxO8Ysedqedk+Y/sfQnBf2RbgyaeGoJ+yGOMzwUD6uLghfce3PQ ba0xHdaKx51k9WMKxIoZklZOusQRvCdcH3hdq4+K+yqZrC/7RJqtUW2CAc5UHX2r4jUpN1Sa73LyX G7aSfEqTpwdcHGrQkNilGlUl07/jQg8+wGeLB7S9vG5VboRJPXS1oSG6VMlfGizX0oXHMfoVJFRfH ODjs7BVuk8vPYDA4Xy5BKYci4ppo5eoXlKL790+hLji2Q/pGyEZ1mYlvHBzAhbDLG42lwvkfrkO0n 5ygAWjUPjtNOZA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54115 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWJri-0006Xw-RK; Mon, 21 Mar 2022 11:22:39 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> Date: Mon, 21 Mar 2022 16:22:36 +0100 In-Reply-To: (Maxime Devos's message of "Sun, 20 Mar 2022 12:56:22 +0100") Message-ID: <8735jbjpoj.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647876254; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+wvuD6wR6lDXtgmXJezOw3nXkXOGFA2ugu2IjUXWeVY=; b=ilMj7nPQvMef1HMUaQQ1xAguW+INNHqnaobrdD4F4SHCl4h9/dfWWBw1VQn0xz0xIyhM36 dJxIDvRQ9y7qvvDI6RceQjnu5YiWcZ4p6xxoTGEtlF2/4zNyNhgCY7usLGzU/CVL/QrVZd 4DoIMTC6jwDE6xGKv18KvePrahwUiKDp8b0eXB9DyXx2GZfk6fXeH1/RCjKQ9RhosLJsO7 U6r4oD4jIeOzW9a1zHdYDAxWNn3odsrrNKwzKnTEC2YNvIndGgOjP0reMvBqCK5FeK8Lzo yjmUejjjylNVkuzzcdBhUnmTywtXOz/X9YhGMnzV04zo1RErPURnpdRzX4hA2Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647876254; a=rsa-sha256; cv=none; b=f5urm+nY8dKfWsoCnK2QheoEb5cp5Y3XIljMjjxOHf9HeqPiupg4wlTzyhaHzA4U3tcWOW BWCio9nn3gLi3jYY/A3eCXa8Gnm4QQRTC+OZz+YA/+z0XU6stk3bIEbC+Z8FuCs29vLvOL y+5Whv+TpaX4OjsDGvMuNTwW34VFdha8TwC5aeTI4o+dw5Z1XZqXfecu2Rq76Bcb2vynn3 Dni/s6+LkyyzvB7dSJfNVxXbOo49i3URTWxGrtjJPutPusRssgCKDxKgE6Nihpje5+oHQb 3lqMPb+wZF7X6N+nIMNpxEV9GO5Q3qtPuPOsoUyfBAEd0VjaeQVNGbfuePwQdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Rh8dpZvV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Rh8dpZvV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0D1AE17F7B X-Spam-Score: -4.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: MCtHG6IpHJLA Hi Maxime, Maxime Devos skribis: > Remco van 't Veer schreef op zo 20-03-2022 om 12:44 [+0100]: >> +=C2=A0 (forward-private-reverse-lookup? >> +=C2=A0=C2=A0 dnsmasq-configuration-forward-private-reverse-lookup? >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (default #t))=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ;boolean >> +=C2=A0 (strict-order?=C2=A0=C2=A0=C2=A0 dnsmasq-configuration-strict-or= der? >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (default #f))=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ;boolean > > It would be nice to verify that these are, in fact, booleans, > using field sanitizers. See, e.g., ensure-setuid-program-list > in (gnu system). I think this suggestion is beyond the scope of this review: we=E2=80=99ve n= ever used sanitizers like this before (or almost), and this particular piece of code doesn=E2=80=99t use them. Also, with the recent discussion about the introduction of contracts, I=E2=80=99d rather wait an use contracts everywhere once they=E2=80=99re av= ailable. Thoughts? Thanks, Ludo=E2=80=99.