all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Guix search, colors and INSIDE_EMACS
Date: Mon, 24 Feb 2020 22:32:09 +0100	[thread overview]
Message-ID: <871rqjk6xy.fsf@ambrevar.xyz> (raw)
In-Reply-To: <874kvfg103.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2584 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Pierre,
>
> I’m happy to discuss it further (to some extent at least, because there
> are other patches waiting for us to be reviewed :-)), but first, as I
> wrote in another message, I think the topic was not consensual and thus
> the series wasn’t ready to be pushed.

All the points have been addressed and I waited a period of 7 days.

Beyond this consideration, it's such a small patch, it does not break
anything for anyone, and we can always revert.

>> Many command line tools print colors properly in M-x shell.  I think
>> it's a misfeature to disable them in Emacs; I don't see any benefits.
>
> I understand the Eshell use case.  The shell-mode use case is one I’m
> interested in keeping as-is, that is: disable colors when INSIDE_EMACS,
> just like Coreutils, GNU grep, etc. do.

But why?

Colors used to work in Guix.  Now they are gone in Eshell / M-x shell.
It seems like a regression to me.

>> I find that printing just 1 result to be of little use in general.
>> So between printing all results and just 1, I have a preference for
>> printing all results.  But there are other solutions, see below.
>
> It’s not printing one result; it’s printing as many results as can fit
> on the screen.

It's usually just 1 or 2 results then :p

> I understand all this.  However, we’re not optimizing just for Eshell
> and shell-mode;

I was just fixing a bug that occured in Eshell / M-x shell, without
impacting other users.

> in fact, I’d argue that Emacs users should just use
> Emacs-Guix (we need to add M-x guix-search, actually!).

Emacs-Guix is not a drop-in replace for shell commands.  For instance,
guix search lets the user edit the results in an Eshell buffer.

Besides, Emacs-Guix is not really in sync with Guix, e.g. the lack of
channel support.

> For regular terminals, I think the two options that work well are:
>
>   1. Print (by default) as much as fits on the screen.
>
>   2. Automatically start a pager.
>
> I went with option #1, which was submitted at
> <https://issues.guix.gnu.org/issue/36390>.  The suggestion actually came
> from Bruno Haible: <https://issues.guix.gnu.org/issue/35551>.

This is not changed by my patch.

> Just to say that there’s already been some thought put into it, and we
> have to carry the baggage of these past discussions now!

We are, I'm just including further thinking into the process, that is,
Emacs Eshell and M-x shell.

Cheers!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-02-24 21:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 15:23 Guix search, colors and INSIDE_EMACS Pierre Neidhardt
2020-02-04 16:12 ` Ricardo Wurmus
2020-02-04 16:37   ` Pierre Neidhardt
2020-02-04 16:51     ` zimoun
2020-02-04 19:16     ` Ricardo Wurmus
2020-02-04 19:18     ` Ricardo Wurmus
2020-02-06  9:51       ` Pierre Neidhardt
2020-02-13  9:30         ` zimoun
2020-02-13 13:41           ` Alex Griffin
2020-02-13 14:22             ` zimoun
2020-02-14  7:17               ` Pierre Neidhardt
2020-02-14  7:21                 ` Pierre Neidhardt
2020-02-17  7:51                   ` Pierre Neidhardt
2020-02-17  7:54                     ` zimoun
2020-02-17 13:42                       ` Pierre Neidhardt
2020-02-17 18:33                         ` zimoun
2020-02-24 10:19                           ` Pierre Neidhardt
2020-02-24 16:22                     ` Ludovic Courtès
2020-02-24 16:44                       ` Pierre Neidhardt
2020-02-24 17:11                         ` zimoun
2020-02-24 20:54                         ` Ludovic Courtès
2020-02-24 21:32                           ` Pierre Neidhardt [this message]
2020-02-24 16:53                       ` zimoun
2020-02-05 15:13     ` Ludovic Courtès
2020-02-06  9:56       ` Pierre Neidhardt
2020-02-07 21:33         ` Ludovic Courtès
2020-02-08 16:34           ` Pierre Neidhardt
2020-02-04 16:40   ` zimoun
2020-02-10 19:36     ` Pierre Neidhardt
2020-02-10 23:24       ` zimoun
2020-02-11  6:22         ` Pierre Neidhardt
2020-02-11 14:11           ` Ludovic Courtès
2020-02-11 14:19             ` Pierre Neidhardt
2020-02-11 15:14               ` zimoun
2020-02-11 16:37                 ` Jack Hill
2020-02-11 18:09                   ` zimoun
2020-02-11 19:04                     ` Jack Hill
2020-02-12 13:39                     ` Pierre Neidhardt
2020-02-12 16:30                       ` zimoun
2020-02-13  9:35                         ` zimoun
2020-02-24 16:18                   ` Ludovic Courtès
2020-02-24 16:45                     ` Pierre Neidhardt
2020-02-24 16:59                       ` zimoun
2020-02-24 16:50                     ` zimoun
2020-02-11 15:11             ` zimoun
2020-02-11 15:06           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rqjk6xy.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.