From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Guix search, colors and INSIDE_EMACS Date: Mon, 24 Feb 2020 22:32:09 +0100 Message-ID: <871rqjk6xy.fsf@ambrevar.xyz> References: <87blqeml4w.fsf@ambrevar.xyz> <87tv46qqlf.fsf@elephly.net> <87d0aul354.fsf@ambrevar.xyz> <87pneuqhyo.fsf@elephly.net> <871rr8hwmv.fsf@ambrevar.xyz> <877e0pvdrs.fsf@ambrevar.xyz> <871rqxvdkd.fsf@ambrevar.xyz> <87d0adtzwg.fsf@ambrevar.xyz> <871rqkj6pw.fsf@gnu.org> <875zfwc4up.fsf@ambrevar.xyz> <874kvfg103.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59186) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6LKp-0001QR-LX for guix-devel@gnu.org; Mon, 24 Feb 2020 16:32:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6LKo-0004FW-Ca for guix-devel@gnu.org; Mon, 24 Feb 2020 16:32:15 -0500 In-Reply-To: <874kvfg103.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix Devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Pierre, > > I=E2=80=99m happy to discuss it further (to some extent at least, because= there > are other patches waiting for us to be reviewed :-)), but first, as I > wrote in another message, I think the topic was not consensual and thus > the series wasn=E2=80=99t ready to be pushed. All the points have been addressed and I waited a period of 7 days. Beyond this consideration, it's such a small patch, it does not break anything for anyone, and we can always revert. >> Many command line tools print colors properly in M-x shell. I think >> it's a misfeature to disable them in Emacs; I don't see any benefits. > > I understand the Eshell use case. The shell-mode use case is one I=E2=80= =99m > interested in keeping as-is, that is: disable colors when INSIDE_EMACS, > just like Coreutils, GNU grep, etc. do. But why? Colors used to work in Guix. Now they are gone in Eshell / M-x shell. It seems like a regression to me. >> I find that printing just 1 result to be of little use in general. >> So between printing all results and just 1, I have a preference for >> printing all results. But there are other solutions, see below. > > It=E2=80=99s not printing one result; it=E2=80=99s printing as many resul= ts as can fit > on the screen. It's usually just 1 or 2 results then :p > I understand all this. However, we=E2=80=99re not optimizing just for Es= hell > and shell-mode; I was just fixing a bug that occured in Eshell / M-x shell, without impacting other users. > in fact, I=E2=80=99d argue that Emacs users should just use > Emacs-Guix (we need to add M-x guix-search, actually!). Emacs-Guix is not a drop-in replace for shell commands. For instance, guix search lets the user edit the results in an Eshell buffer. Besides, Emacs-Guix is not really in sync with Guix, e.g. the lack of channel support. > For regular terminals, I think the two options that work well are: > > 1. Print (by default) as much as fits on the screen. > > 2. Automatically start a pager. > > I went with option #1, which was submitted at > . The suggestion actually came > from Bruno Haible: . This is not changed by my patch. > Just to say that there=E2=80=99s already been some thought put into it, a= nd we > have to carry the baggage of these past discussions now! We are, I'm just including further thinking into the process, that is, Emacs Eshell and M-x shell. Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5UQNkACgkQm9z0l6S7 zH8XcggAp8IHDD5M7mk3mTEn+JZSqyHssGYg2gAygNpBJ79ByBRwWdBY4A+Ya2Yc lWNDAWe+xtAhMl06dSXjjYltP14lXKBtT1YOIGFNX98H+cJ/BXaPlCRFrVDKu+Kx mrxIq6Fb7sVHyVImMxnxxRGZnopzg0aO4eiUXQwH7KYsSjcNdN/nYcr2i6C7+jgb kObcrFrlD8Fo459OfPTRsEe8LI+HQB1ZpO7SM8b+NTeawMQ4sigROjqLV83AlBaj ea8cxpwtR4v94Zj+ZuSpMPI6W1YJ4KUxnryeW9PeIH5fbvThwLifi8Q5gOBRdQlP NGhlt6OEjNDv1owwvU5G6v27DbYpXA== =SS+/ -----END PGP SIGNATURE----- --=-=-=--