bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Hullo Hartmut,

I'm strangely unable to build python-piexif:

patching file tests/s_test.py
Hunk #1 FAILED at 9 (different line endings).
Hunk #2 FAILED at 580 (different line endings).
2 out of 2 hunks FAILED -- saving rejects to file 
tests/s_test.py.rej

Indeed:

$ file tests/s_test.py
tests/s_test.py: Python script, ASCII text executable, with CRLF 
line terminators

$ file python-piexif-fix-tests-with-pillow-7.2.pat>
python-piexif-fix-tests-with-pillow-7.2.patch: ASCII text

At least that's what I guess is the problem.

This is worrying since I'd expect all this to be 100% 
reproducible, and it seems to work fine for both you & Ludo'…

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

[Ludovic Courtès]

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> This is worrying since I'd expect all this to be 100% reproducible,
> and it seems to work fine for both you & Ludo'…

Applying the patch also fails for me (I think I didn’t test it when
reviewing Hartmut’s patches.)

Ludo’.

bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

[Hartmut Goebel]

Hi,

Am 16.01.22 um 23:44 schrieb Tobias Geerinckx-Rice:
> This is worrying since I'd expect all this to be 100% reproducible, 
> and it seems to work fine for both you & Ludo'… 

I have to admit that I did not test the patch again after converting the 
line-endings - which Ludo asked for. Changing the line-endings was too 
simple FMPOV - I trusted Ludo's recommendation.

I'll fix this.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

[Hartmut Goebel]

Fixed in af47145e995c9d3d116a60053648b4f35e2ed125

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

bug#53309: Newly-added python-piexif fails to patch source due to CRLF(?)

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hartmut Goebel 写道：
> I have to admit that I did not test the patch again after 
> converting
> the line-endings - which Ludo asked for. Changing the 
> line-endings was
> too simple FMPOV - I trusted Ludo's recommendation.

All good, I'm just glad it's not due to some spooky gremlin 
(similar to the locale orcs that still occasionally haunt our 
lands).

> I'll fix this.

Thanks!

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]