From: zimoun <zimon.toutoune@gmail.com>
To: divoplade <d@divoplade.fr>, Julien Lepiller <julien@lepiller.eu>
Cc: 45133@debbugs.gnu.org
Subject: [bug#45133] Add ocaml reactiveData
Date: Thu, 10 Dec 2020 15:43:44 +0100 [thread overview]
Message-ID: <86pn3hhgbj.fsf@gmail.com> (raw)
In-Reply-To: <e26781478b7664107606e23495b5e07fbaee1116.camel@divoplade.fr>
Hi,
On Thu, 10 Dec 2020 at 15:12, divoplade <d@divoplade.fr> wrote:
> The solution was to delete the Makefile just before the install phase
Cool! That’s what I proposed, sorry if I have not been clear. :-)
> I've tried to reproduce the changes of simon but I'm not sure I
> reproduced the indentation correctly (it's different from what
> etc/indent.el does, but a lot of ocaml packages are not indented
> according to that script).
Ahah! Let use the one of etc/indent.el for the ocaml-reactivedata and
see the other ones later.
> So the last point is about url-fetch vs git-fetch: why do you want to
> use git-fetch?
Well, because OCaml packages currently uses more git-fetch than url-fetch:
--8<---------------cut here---------------start------------->8---
$ cat gnu/packages/ocaml.scm | grep url-fetch | wc -l
69
$ cat gnu/packages/ocaml.scm | grep git-fetch | wc -l
91
--8<---------------cut here---------------end--------------->8---
It is a matter of taste. You can read the thread starting here:
<https://yhetil.org/guix-devel/CAJ3okZ0v3VvmT=eWAVeAQoFqZh4L3H4tUkEJn1-5EXcJgRB_tQ@mail.gmail.com>
The main advantages of git-fetch over url-fetch are, IMHO:
- lint saves to SWH; no SWH fallback with url-fetch
- easy to try any other commit (--with-commit)
- with specified commit–as it is here– avoid the in-place upstream replacement annoyance
I was just sharing my opinion reading your patch after questions on IRC,
and I have no strong opinions since Julien is the one who will review
and push it. :-)
All the best,
simon
next prev parent reply other threads:[~2020-12-10 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 14:58 [bug#45133] Add ocaml reactiveData divoplade
2020-12-09 15:40 ` Julien Lepiller
2020-12-09 17:03 ` divoplade
2020-12-09 17:59 ` zimoun
2020-12-09 18:05 ` divoplade
2020-12-09 18:35 ` zimoun
2020-12-09 19:12 ` Julien Lepiller
2020-12-10 12:41 ` zimoun
2020-12-10 12:49 ` divoplade
2020-12-10 12:42 ` divoplade
2020-12-10 13:53 ` Julien Lepiller
2020-12-10 14:12 ` divoplade
2020-12-10 14:43 ` zimoun [this message]
2020-12-10 14:57 ` divoplade
2020-12-15 14:49 ` bug#45133: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pn3hhgbj.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=45133@debbugs.gnu.org \
--cc=d@divoplade.fr \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.