From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kAIwGqI10l8XZQAA0tVLHw (envelope-from ) for ; Thu, 10 Dec 2020 14:50:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4If/FaI10l/nUwAA1q6Kng (envelope-from ) for ; Thu, 10 Dec 2020 14:50:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CFB5940481 for ; Thu, 10 Dec 2020 14:50:10 +0000 (UTC) Received: from localhost ([::1]:56440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knNGi-0001r6-Um for larch@yhetil.org; Thu, 10 Dec 2020 09:50:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knNDi-0008Ky-7B for guix-patches@gnu.org; Thu, 10 Dec 2020 09:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knNDi-0005nM-0W for guix-patches@gnu.org; Thu, 10 Dec 2020 09:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knNDh-0005sq-S6 for guix-patches@gnu.org; Thu, 10 Dec 2020 09:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45133] Add ocaml reactiveData Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Dec 2020 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45133 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: divoplade , Julien Lepiller Received: via spool by 45133-submit@debbugs.gnu.org id=B45133.160761156622550 (code B ref 45133); Thu, 10 Dec 2020 14:47:01 +0000 Received: (at 45133) by debbugs.gnu.org; 10 Dec 2020 14:46:06 +0000 Received: from localhost ([127.0.0.1]:37330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knNCo-0005rc-Hr for submit@debbugs.gnu.org; Thu, 10 Dec 2020 09:46:06 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knNCn-0005qr-5p for 45133@debbugs.gnu.org; Thu, 10 Dec 2020 09:46:06 -0500 Received: by mail-wr1-f50.google.com with SMTP id t4so5723573wrr.12 for <45133@debbugs.gnu.org>; Thu, 10 Dec 2020 06:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=IRhSikkxcRWTM2GCiH95K3phXAOz9z9B046d24r9L5s=; b=Lj2lvmckUGSh/2XiM8i5qczUPZ13NIHgUBny8RDD43GVC/i+YYL2su6aD4n09fgTtD /l6vS5cAkZP5G4axB/IlOVJFIkqYqHVHuM0nOBOsje02yqW06ijkjhBAuMZsdcmOZ14D lnuYw6eweuMxKXrBVQVtXg1xIazj/5EPple+BlWuBU3T9bU8zd5XDG/xhNFBPRGH+DUV VT+NOrvg7ng5T5Oer2/RnfxdOcPA+Dzf2NTIDkejr735QoB7rNTlIAPjjnsg8yEPJmUD CYfLk26apDWVFKv70240CFCOvtaCNflImQdz2E9TrTjEWRgQsf6/Yn8otG+ZpUGSwT2o oSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=IRhSikkxcRWTM2GCiH95K3phXAOz9z9B046d24r9L5s=; b=Nw9EIlfuveILG9bO+lIa9sHNjTZrSjGXA3mt71ZV/KqYeAm5tMhDK0vkVhHIc9WyC1 tApEbYBYzx4SYYUD6Tqbg2Ph9BzXBEysgSPvIcms0NbFUf7dAztBpVpvb44G6TrzjzkN fzsp4ekRZ1+FTjcOCGCg/5AE+NsnQCZXWjQOO1C0ZhgAPW48/GPKGmnjM34+kU5ht0z1 A49Alab8URXDeYuORvVGke12BefUSyesoMR7qRkgcNkZFiaMpHalb0ye1hfoUv9lPRIF lhoVxbG5XRCB/iPQwhDGI/L2xVca3K26X5y1Dl/t9eMfnUY8lcsSFKFePQMRUCv4lof7 Qrhg== X-Gm-Message-State: AOAM5324ud002I1/3MbquomagNlf9bb0Lc0Io9Eio4cPfhLRXrOw7Uus fwrYoMcJiCd+Qk2VxSRkgjtIeE7mbAk= X-Google-Smtp-Source: ABdhPJz+bnKN7wA1479L+W+l1MvT1of4QydT7KJinJ4rQAjULBdx6tssB33LR6topjapC85aSOH49A== X-Received: by 2002:a5d:678c:: with SMTP id v12mr8974644wru.115.1607611559122; Thu, 10 Dec 2020 06:45:59 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m21sm9669240wml.13.2020.12.10.06.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 06:45:58 -0800 (PST) From: zimoun In-Reply-To: References: <071FCE1F-5CBA-47E3-98B2-952FFFFAE217@lepiller.eu> <874kkuoo75.fsf@gmail.com> <2986b776fa7dd8b813ecc5c3afc32cfce01e3f95.camel@divoplade.fr> <1dcecaea52ad5d96b93fe7ef5675e5f5a52065b9.camel@divoplade.fr> <322C6C39-C571-4871-B3B1-D58D67913EEE@lepiller.eu> Date: Thu, 10 Dec 2020 15:43:44 +0100 Message-ID: <86pn3hhgbj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45133@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=Lj2lvmck; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0CFB5940481 X-Spam-Score: -1.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: VE5ScNRawOYC Hi, On Thu, 10 Dec 2020 at 15:12, divoplade wrote: > The solution was to delete the Makefile just before the install phase Cool! That=E2=80=99s what I proposed, sorry if I have not been clear. :-) > I've tried to reproduce the changes of simon but I'm not sure I > reproduced the indentation correctly (it's different from what > etc/indent.el does, but a lot of ocaml packages are not indented > according to that script). Ahah! Let use the one of etc/indent.el for the ocaml-reactivedata and see the other ones later. > So the last point is about url-fetch vs git-fetch: why do you want to > use git-fetch? Well, because OCaml packages currently uses more git-fetch than url-fetch: --8<---------------cut here---------------start------------->8--- $ cat gnu/packages/ocaml.scm | grep url-fetch | wc -l 69 $ cat gnu/packages/ocaml.scm | grep git-fetch | wc -l 91 --8<---------------cut here---------------end--------------->8--- It is a matter of taste. You can read the thread starting here: The main advantages of git-fetch over url-fetch are, IMHO: - lint saves to SWH; no SWH fallback with url-fetch - easy to try any other commit (--with-commit) - with specified commit=E2=80=93as it is here=E2=80=93 avoid the in-place = upstream replacement annoyance I was just sharing my opinion reading your patch after questions on IRC, and I have no strong opinions since Julien is the one who will review and push it. :-) All the best, simon