From: Julien Lepiller <julien@lepiller.eu>
To: divoplade <d@divoplade.fr>
Cc: 45133-done@debbugs.gnu.org
Subject: bug#45133: Add ocaml reactiveData
Date: Tue, 15 Dec 2020 15:49:56 +0100 [thread overview]
Message-ID: <20201215154956.4350a986@tachikoma.lepiller.eu> (raw)
In-Reply-To: <c4b9aeae0ab049516dbd6d56b0b8f566de141d49.camel@divoplade.fr>
Pushed as 190187326ad7516dd6728eed7bb6ef2d4f92897a.
I made a small number of changes to your patch:
In the commit message, added capitalization (add -> Add) and full
stops, removed spaces at the beginning of the `*` line.
In the patch, added a copyright line for you, added a comment to the
phase where we delete the Makefile, fixed the description (guix lint
should have told you so), and added an upstream-name property so guix
refresh knows where to look for newer versions. In general, it's not
needed because guix-name->opam-name works well, but here we lost
capitalization, so we need to explicitely tell it which name it is.
Thank you!
prev parent reply other threads:[~2020-12-15 14:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 14:58 [bug#45133] Add ocaml reactiveData divoplade
2020-12-09 15:40 ` Julien Lepiller
2020-12-09 17:03 ` divoplade
2020-12-09 17:59 ` zimoun
2020-12-09 18:05 ` divoplade
2020-12-09 18:35 ` zimoun
2020-12-09 19:12 ` Julien Lepiller
2020-12-10 12:41 ` zimoun
2020-12-10 12:49 ` divoplade
2020-12-10 12:42 ` divoplade
2020-12-10 13:53 ` Julien Lepiller
2020-12-10 14:12 ` divoplade
2020-12-10 14:43 ` zimoun
2020-12-10 14:57 ` divoplade
2020-12-15 14:49 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215154956.4350a986@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=45133-done@debbugs.gnu.org \
--cc=d@divoplade.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.