From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QMdVAoNB2mOYUgAAbAwnHQ (envelope-from ) for ; Wed, 01 Feb 2023 11:40:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2KJWAYNB2mNmVQEAG6o9tA (envelope-from ) for ; Wed, 01 Feb 2023 11:40:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF7D63A791 for ; Wed, 1 Feb 2023 11:40:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNA8u-00038n-Sp; Wed, 01 Feb 2023 05:15:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNA8t-000381-6r for guix-patches@gnu.org; Wed, 01 Feb 2023 05:15:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNA8s-0008Ie-P7 for guix-patches@gnu.org; Wed, 01 Feb 2023 05:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNA8s-0007ET-2s for guix-patches@gnu.org; Wed, 01 Feb 2023 05:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Feb 2023 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59078 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Christopher Baines , 59078@debbugs.gnu.org Received: via spool by 59078-submit@debbugs.gnu.org id=B59078.167524649027756 (code B ref 59078); Wed, 01 Feb 2023 10:15:02 +0000 Received: (at 59078) by debbugs.gnu.org; 1 Feb 2023 10:14:50 +0000 Received: from localhost ([127.0.0.1]:56556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNA8f-0007Da-T2 for submit@debbugs.gnu.org; Wed, 01 Feb 2023 05:14:50 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:56059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNA8c-0007Cz-BL for 59078@debbugs.gnu.org; Wed, 01 Feb 2023 05:14:48 -0500 Received: by mail-wm1-f53.google.com with SMTP id q8so12244015wmo.5 for <59078@debbugs.gnu.org>; Wed, 01 Feb 2023 02:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lxxSaUzGsGxDk0oNqhtBfuOtN3RVdc/7LRRYzmWG/AY=; b=MWtHD/LMm9FzYf8nkoIWs+TvdfUH9jG6+LIFMUY57lAdngS/2E00GxG911/IR8S3G9 erqUmKP293xWx3NKUdNjLkPCDaf+8BrBMwdv60KvLQTYx+WnU2LCrWv4Y3dRn8Vh78MU tza3hFTlc3udOSoHAprHiBtXVloZhsXfT2MJTPt8UQIqtVV/37ZOP4zT32dHt7Omd0pG bEjgX0qE7beaOR5dZJWfUhPjHmLsnkfLWDOe4n4iYDdimsiZoAv45QOY7t2Baudow34l mmD9dpjeeEbBSBZ1UadeqTP7Pp8cnFFmfwCV9DkAbohTxzMTOrISuNW4zqz0/J3hZvC5 v8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lxxSaUzGsGxDk0oNqhtBfuOtN3RVdc/7LRRYzmWG/AY=; b=dV86BweAslU7BMeXubbH+scTvHT68ra/AELxTzbCE8uvYCmJsTeSbCMJf9OQdsaZJd AY6KFB/W6xuWOwRnsvzO+WIXwiearmZZFqZu3El2vx7snTkGfMj/WeZN9iIJazsFT6Dd xThzX2KnGTiY9ml7QDAhNiDbT1xYoaWa8CgptnDC39nPqxaVEergC0qlYelb1kyD7/9A qumijeBWS4gGyJMIWE9EJVLkVRUYKLc2Mn+WjkziYqJKAYSktmgp6WJkTarv9HAEokY+ P5+cYbchP8WofqWVCKN2FIYPu1WUpkUSHty0did4obohnB8PVOOZU11eAWqmA/ZFkF5n TXug== X-Gm-Message-State: AO0yUKXYf1XrbslGfWCMUUGY3MOu+ZqRqfczcSD+VqfdknVzf+k5wlNK zluQ3l8OQdp3lF4JRQknWht9Qdc7vT0= X-Google-Smtp-Source: AK7set8IkGS0FLYBL80vlxgoHeXYG4KioTMGKlyAneN2LUkGcaqIn+brjUqeGm34s59d9bTNx87OpQ== X-Received: by 2002:a05:600c:1d05:b0:3dc:57e8:1d10 with SMTP id l5-20020a05600c1d0500b003dc57e81d10mr1445846wms.1.1675246480636; Wed, 01 Feb 2023 02:14:40 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id bg21-20020a05600c3c9500b003db06493ee7sm1374977wmb.47.2023.02.01.02.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 02:14:40 -0800 (PST) From: zimoun In-Reply-To: <87tu06u0iz.fsf@gnu.org> References: <20221106135532.5724-1-mail@cbaines.net> <87k041dui7.fsf@gnu.org> <87bkpau4kl.fsf@cbaines.net> <87h6z1puli.fsf@gnu.org> <86r0y4io7q.fsf@gmail.com> <875ycroom4.fsf_-_@gmail.com> <87tu06u0iz.fsf@gnu.org> Date: Wed, 01 Feb 2023 10:47:08 +0100 Message-ID: <868rhhvhsz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675248002; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lxxSaUzGsGxDk0oNqhtBfuOtN3RVdc/7LRRYzmWG/AY=; b=uvj7pMuuJIgE4z6M2xVvEZK34IABNOzEMGOb2iNDLj15Qv7tu43NUA2FWx+V4MRsGu86yw gCAmlCWOZsoujw0w9GNNPZbthtM49FivNQmQ+P8qgUeUmlVhoX2zmOyOqXNYj8pQy/VYOL DWi4gpxeLmr6XYG0+GMefqZZfhhyn5LMFXF/NpO6ZZaXgXahSg3sUEPuM9gHniSEmTTHtu 0Ept2HoHmf8Ob+jP6LYC3d7aAEPHrmWDsJ6zdz4x7r6HgBkLluyCvg+XDrIHG2q+t/Xl6R tLZB0EcJczk3LLscDWwfN4gR+bWzlBsON/jahmmJGlQg0j3fAx1rD6bvBhYRmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="MWtHD/LM"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675248002; a=rsa-sha256; cv=none; b=Wn2FINX2A2nZBZ4EsoG8Eatwv3g36yPbLL9tA1rermOaJPrfsQWK42mbba9+BMaW51nY9W SrlJHtO/55oeKopZwLQGsSZXZ9h1/pJ/3uTakV0DDbQldcBsiRgTIC+V7bAh7xNTKz8YkL 1z8wE6UKi1sYUr2/eX2KW5+wF2W94YpOshndB9z5uOMOWYStae1DMXpZ/LpgaIyAFKCiZq 88lgbtpn0QCy7ccatjB/WFa4pPfJDGPrmaiWBLtMsYRraatjt8pq3C4c234BH5uctymwj/ ZivfOebac3ysa1xsZG0gbIEBhv9MhIX801JKXfrCE+Cost/bRPfk6K5FXgm6GQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="MWtHD/LM"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Spam-Score: -0.78 X-Migadu-Queue-Id: BF7D63A791 X-Migadu-Spam-Score: -0.78 X-TUID: fwuztkEFHdqA Hi Ludo, On Tue, 31 Jan 2023 at 17:33, Ludovic Court=C3=A8s wrote: > In general, being able to tell which category a checker belongs to, and > then being able to select checkers by categories sounds like a useful > improvement to me. > > I don=E2=80=99t think it solves the problem Christopher initially reported > though (about memory consumption of the =E2=80=98derivation=E2=80=99 chec= ker.) Indeed. My understanding of the proposal is to split some checkers (as derivation) and then group them to have the expected behaviour. You wrote [1]: I meant that it=E2=80=99s important to have a single =E2=80=98deriv= ation=E2=80=99 checker that checks derivations for all the supported systems. Packagers should be able to run =E2=80=98guix lint -c derivation PK= G=E2=80=99 and be confident that it=E2=80=99s fine for all systems. and Chris answered [2]: I think we can still keep that by adding support for grouping lint checkers. So have a derivation group, instead of a single checker. Maybe that'll change the command slightly to 'guix lint -g derivati= on PKG', but I think that can be equivalent. where I try to feed Chris=E2=80=99s proposal. :-) I do not know if it is the correct level but being able to run =E2=80=9Csma= ller=E2=80=9C checkers appears to me worth to try. 1: http://issues.guix.gnu.org/msgid/87h6z1puli.fsf@gnu.org 2: http://issues.guix.gnu.org/msgid/87leocfsnm.fsf@cbaines.net Cheers, simon