From: Maxime Devos <maximedevos@telenet.be>
To: Xinglu Chen <public@yoctocell.xyz>, 53818@debbugs.gnu.org
Subject: [bug#53818] [PATCH v2 5/7] import: Add 'repology' updater.
Date: Mon, 07 Feb 2022 10:50:10 +0100 [thread overview]
Message-ID: <76a550f4fc82de9491b99786e8086d9d9d8c4c72.camel@telenet.be> (raw)
In-Reply-To: <98726379214702d0745f56d9f946e792e803d326.1644224421.git.public@yoctocell.xyz>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
Xinglu Chen schreef op ma 07-02-2022 om 10:07 [+0100]:
> +(define (latest-release package)
> + (mock ((guix import json) json-fetch
> + (lambda* (url #:key cached?)
> + (json-string->scm %test-json)))
> + (repology-latest-release package)))
It would be nice to verify the URL.
FWIW, there's a 'with-http-server' macro.
although it might need to be extended a little, see e.g.
<https://issues.guix.gnu.org/53389>.
Also, you are using 'memoize' in repology-fetch-info,
so the memoisation cache needs to be invalidated
(see e.g. tests/minetest.scm), or not, depending
on how 'repology-fetch-info' is used and tests are written.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-07 10:33 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 11:50 [bug#53818] [PATCH 0/3] Add Repology updater Xinglu Chen
2022-02-06 12:41 ` Maxime Devos
2022-02-06 15:17 ` Xinglu Chen
2022-02-06 13:00 ` [bug#53818] [PATCH 1/3] git-download: Export <git-reference> Xinglu Chen
2022-02-06 13:00 ` [bug#53818] [PATCH 2/3] import: Add 'repology' updater Xinglu Chen
2022-02-06 13:11 ` Maxime Devos
2022-02-06 15:18 ` Xinglu Chen
2022-02-06 13:13 ` Maxime Devos
2022-02-06 15:26 ` Xinglu Chen
2022-02-06 13:13 ` Maxime Devos
2022-02-06 13:17 ` Maxime Devos
2022-02-06 15:32 ` Xinglu Chen
2022-02-06 13:18 ` Maxime Devos
2022-02-06 15:34 ` Xinglu Chen
2022-02-06 15:36 ` Maxime Devos
2022-02-06 13:19 ` Maxime Devos
2022-02-06 13:23 ` Maxime Devos
2022-02-06 15:41 ` Xinglu Chen
2022-02-06 13:23 ` Maxime Devos
2022-02-06 15:42 ` Xinglu Chen
2022-02-06 13:00 ` [bug#53818] [PATCH 3/3] gnu: xorg-server-xwayland: Set 'repology-name' property Xinglu Chen
2022-02-06 14:15 ` Maxime Devos
2022-02-07 9:06 ` [bug#53818] [PATCH v2 0/7] Add Repology updater Xinglu Chen
2022-02-07 9:06 ` [bug#53818] [PATCH v2 1/7] upstream: Sort list of updaters Xinglu Chen
2022-02-07 9:06 ` [bug#53818] [PATCH v2 2/7] http-client: Make 'http-fetch/cached' take '#:headers' argument Xinglu Chen
2022-02-07 9:06 ` [bug#53818] [PATCH v2 3/7] http-client: 'http-fetch/cached' accepts a string or a <uri> Xinglu Chen
2022-02-07 9:07 ` [bug#53818] [PATCH v2 4/7] import: json: Make 'json-fetch' take '#:cached?' argument Xinglu Chen
2022-02-07 9:44 ` Maxime Devos
2022-02-07 9:07 ` [bug#53818] [PATCH v2 5/7] import: Add 'repology' updater Xinglu Chen
2022-02-07 9:45 ` Maxime Devos
2022-02-07 9:50 ` Maxime Devos [this message]
2022-02-08 12:29 ` Xinglu Chen
2022-02-08 12:49 ` Maxime Devos
2022-02-09 12:54 ` Xinglu Chen
2022-02-07 9:07 ` [bug#53818] [PATCH v2 6/7] gnu: xorg-server-xwayland: Set 'repology-name' property Xinglu Chen
2022-02-07 9:07 ` [bug#53818] [PATCH v2 7/7] gnu: xorg-server-xwayland: Prepare for cross-compilation Xinglu Chen
2022-02-09 13:22 ` [bug#53818] [PATCH v3 0/7] Add Repology updater Xinglu Chen
2022-02-09 13:24 ` [bug#53818] [PATCH v3 1/7] upstream: Sort list of updaters Xinglu Chen
2022-02-09 13:24 ` [bug#53818] [PATCH v3 2/7] http-client: Make 'http-fetch/cached' take '#:headers' argument Xinglu Chen
2022-02-09 13:24 ` [bug#53818] [PATCH v3 3/7] http-client: 'http-fetch/cached' accepts a string or a <uri> Xinglu Chen
2022-02-09 13:25 ` [bug#53818] [PATCH v3 4/7] import: json: Make 'json-fetch' take '#:http-fetch' argument Xinglu Chen
2022-02-09 13:25 ` [bug#53818] [PATCH v3 5/7] import: Add 'repology' updater Xinglu Chen
2022-02-09 13:25 ` [bug#53818] [PATCH v3 6/7] gnu: xorg-server-xwayland: Set 'repology-name' property Xinglu Chen
2022-02-09 13:25 ` [bug#53818] [PATCH v3 7/7] gnu: xorg-server-xwayland: Prepare for cross-compilation Xinglu Chen
2022-02-08 22:59 ` [bug#53818] [PATCH 0/3] Add Repology updater Ludovic Courtès
2022-02-09 12:52 ` Xinglu Chen
2022-02-09 14:29 ` Nicolas Goaziou
2022-02-10 18:17 ` Xinglu Chen
2022-02-10 19:30 ` Nicolas Goaziou
2022-02-10 20:49 ` Ludovic Courtès
2022-02-14 10:40 ` Nicolas Goaziou
2022-02-14 16:07 ` Maxime Devos
2022-02-14 16:58 ` Ludovic Courtès
2022-02-14 18:42 ` Nicolas Goaziou
2022-02-15 9:57 ` [bug#53818] Improving updaters and ‘guix refresh’ Ludovic Courtès
2022-02-16 12:43 ` Nicolas Goaziou
2022-02-17 10:35 ` Ludovic Courtès
2022-02-17 11:17 ` zimoun
2022-02-18 10:28 ` Nicolas Goaziou
2022-03-03 21:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a550f4fc82de9491b99786e8086d9d9d8c4c72.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53818@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.