From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: 52283@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludovic.courtes@inria.fr>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#52283] [PATCH 02/10] transformations: Add '--tune'.
Date: Mon, 06 Dec 2021 20:18:51 -0300 [thread overview]
Message-ID: <7364829.rrRS6mQaNJ@popigai> (raw)
In-Reply-To: <20211204204924.15581-2-ludo@gnu.org>
Hello Ludo,
Awesome series! I only have comments about this patch, and then only minor
ones:
Em sábado, 4 de dezembro de 2021, às 17:49:16 -03, Ludovic Courtès
escreveu:
> +Tuned packages are @emph{grafted} onto packages that depend on them
> +(@pxref{Security Updates, grafts}). Thus, using @option{--no-grafts}
> +annihilates the effect of @option{--tune}.
Perhaps this is because English isn’t my first language, but annihilation
seems like a violent and dramatic effect in a package transformation. :-)
Perhaps reword as “cancels”, “invalidates” or "nullifies"?
> +(define (tuned-package p micro-architecture)
> + "Return package P tuned for MICRO-ARCHITECTURE."
> + (define compiler
> + (tuning-compiler micro-architecture))
> +
> + (package
> + (inherit p)
> + (native-inputs
> + ;; Arrange so that COMPILER comes first in $PATH.
> + `(("tuning-compiler" ,compiler)
> + ,@(package-native-inputs p)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments p)
> + ((#:tests? _ #f) #f)))
Perhaps I’m reading this wrong, but it looks like tuned packages don’t run
their testsuites? If so, this is a surprising side-effect and thus it would
be nice to have it mentioned in the manual, possibly also in a comment
here. It would be nice to also mention the rationale for disabling the
tests (not sure whether only in a comment here or if in the manual as
well). I assume it’s for convenience, but I’m not sure.
--
Thanks,
Thiago
next prev parent reply other threads:[~2021-12-06 23:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:34 [bug#52283] [PATCH 00/10] Tuning packages for CPU micro-architectures Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 01/10] Add (guix cpu) Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 02/10] transformations: Add '--tune' Ludovic Courtès
2021-12-06 23:18 ` Thiago Jung Bauermann via Guix-patches via [this message]
2021-12-07 8:04 ` Ludovic Courtès
2021-12-07 10:32 ` zimoun
2021-12-07 14:52 ` Ludovic Courtès
2021-12-07 15:52 ` zimoun
2021-12-09 9:19 ` Ludovic Courtès
2021-12-09 10:35 ` zimoun
2021-12-10 8:49 ` Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 03/10] ci: Add extra jobs for tunable packages Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 04/10] gnu: Add eigen-benchmarks Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 05/10] gnu: Add xsimd-benchmark Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 06/10] gnu: Add xtensor-benchmark Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 07/10] gnu: ceres-solver: Mark as tunable Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 08/10] gnu: Add ceres-solver-benchmarks Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 09/10] gnu: libfive: Mark as tunable Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 10/10] gnu: prusa-slicer: " Ludovic Courtès
2021-12-05 8:37 ` [bug#52283] [PATCH 00/10] Tuning packages for CPU micro-architectures Mathieu Othacehe
2021-12-06 10:38 ` Ludovic Courtès
2021-12-06 12:47 ` zimoun
2021-12-07 8:39 ` Mathieu Othacehe
2021-12-07 9:02 ` Ludovic Courtès
2021-12-06 16:48 ` Ludovic Courtès
2021-12-04 21:11 ` Ludovic Courtès
2021-12-07 9:13 ` Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 00/12] " Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 01/12] Add (guix cpu) Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 02/12] gnu: gcc: Add 'compiler-cpu-architectures' property Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 03/12] gnu: clang: " Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 04/12] transformations: Add '--tune' Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 05/12] ci: Add extra jobs for tunable packages Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 06/12] gnu: Add eigen-benchmarks Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 07/12] gnu: Add xsimd-benchmark Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 08/12] gnu: Add xtensor-benchmark Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 09/12] gnu: ceres-solver: Mark as tunable Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 10/12] gnu: Add ceres-solver-benchmarks Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 11/12] gnu: libfive: Mark as tunable Ludovic Courtès
2021-12-16 17:58 ` [bug#52283] [PATCH v2 12/12] gnu: prusa-slicer: " Ludovic Courtès
2022-01-01 14:59 ` bug#52283: [PATCH 00/10] Tuning packages for CPU micro-architectures Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7364829.rrRS6mQaNJ@popigai \
--to=guix-patches@gnu.org \
--cc=52283@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
--cc=ludo@gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.