all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 52283@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#52283] [PATCH v2 00/12] Tuning packages for CPU micro-architectures
Date: Thu, 16 Dec 2021 18:58:15 +0100	[thread overview]
Message-ID: <20211216175827.2077-1-ludo@gnu.org> (raw)
In-Reply-To: <87lf0wkcam.fsf@gnu.org>

Hello!

Here is v2 of the patch set implementing the ‘--tune’ package
transformation option.  Changes since v1:

  • Compiler packages (gcc, clang, gcc-toolchain, clang-toolchain)
    now declare in a package property the supported CPU names;
    ‘--tune’ verifies, when the package a lowered to a bag, whether
    the target CPU is supported by the compiler and errors out
    if not.

    In theory, ‘--tune’ (with no argument) could detect a CPU
    that the compiler does not support, though that’s unlikely
    since (guix cpu) currently corresponds to what GCC 10 supports.
    I considered doing something fancy that would somehow fall
    back to a less accurate but supported CPU name, but gave up
    out of laziness and fear of complexity.

  • Guix now prints which package is being tuned, like so:

      $ ./pre-inst-env guix shell --tune inspekt3d -- Studio
      guix shell: tuning libfive@0-4.8ca1b86 for CPU skylake

  • Documentation reworded as suggested by Josselin.  It also
    clarifies that a compiler wrapper is used and that tests are
    skipped.

  • Inputs of the new packages were simplified.  \o/
  
Something left as future work is AMD processor identification
in (guix cpu).

Those interested in compiler optimizations can use it to compare
the job made by different compilers:

  guix shell --with-c-toolchain=xtensor-benchmark=clang-toolchain \
    --tune xtensor-benchmark -- benchmark_xtensor

Fun fact:

  guix shell --tune eigen-benchmarks -- benchBlasGemm 240 240 240

now gives me 45 Gflops/s on my CORE i7 (skylake), when pre-merge it
would give 36 Gflops/s.  Same result with:

  --with-c-toolchain=eigen-benchmarks=gcc-toolchain@7

Go figure!

I re-pushed the ‘wip-cpu-tuning’ branch so people can give it a try:

  guix time-machine --branch=wip-cpu-tuning -- \
    shell eigen-benchmarks --tune -- \
    benchBlasGemm 240 240 240

Thoughts?

Ludo’.

Ludovic Courtès (12):
  Add (guix cpu).
  gnu: gcc: Add 'compiler-cpu-architectures' property.
  gnu: clang: Add 'compiler-cpu-architectures' property.
  transformations: Add '--tune'.
  ci: Add extra jobs for tunable packages.
  gnu: Add eigen-benchmarks.
  gnu: Add xsimd-benchmark.
  gnu: Add xtensor-benchmark.
  gnu: ceres-solver: Mark as tunable.
  gnu: Add ceres-solver-benchmarks.
  gnu: libfive: Mark as tunable.
  gnu: prusa-slicer: Mark as tunable.

 Makefile.am                   |   1 +
 doc/guix.texi                 |  61 ++++++++++
 gnu/ci.scm                    |  43 +++++--
 gnu/packages/algebra.scm      |  77 +++++++++++++
 gnu/packages/commencement.scm |   1 +
 gnu/packages/cpp.scm          |  23 ++++
 gnu/packages/engineering.scm  |  10 +-
 gnu/packages/gcc.scm          |  31 +++++-
 gnu/packages/llvm.scm         |  71 +++++++++++-
 gnu/packages/maths.scm        |  48 +++++++-
 guix/cpu.scm                  | 143 ++++++++++++++++++++++++
 guix/transformations.scm      | 204 ++++++++++++++++++++++++++++++++++
 tests/transformations.scm     |  35 ++++++
 13 files changed, 733 insertions(+), 15 deletions(-)
 create mode 100644 guix/cpu.scm


base-commit: e642378df3b0d218e463397883e7bf331f528c6a
-- 
2.33.0





  reply	other threads:[~2021-12-16 17:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04 20:34 [bug#52283] [PATCH 00/10] Tuning packages for CPU micro-architectures Ludovic Courtès
2021-12-04 20:49 ` [bug#52283] [PATCH 01/10] Add (guix cpu) Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 02/10] transformations: Add '--tune' Ludovic Courtès
2021-12-06 23:18     ` Thiago Jung Bauermann via Guix-patches via
2021-12-07  8:04       ` Ludovic Courtès
2021-12-07 10:32         ` zimoun
2021-12-07 14:52           ` Ludovic Courtès
2021-12-07 15:52             ` zimoun
2021-12-09  9:19               ` Ludovic Courtès
2021-12-09 10:35                 ` zimoun
2021-12-10  8:49                   ` Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 03/10] ci: Add extra jobs for tunable packages Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 04/10] gnu: Add eigen-benchmarks Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 05/10] gnu: Add xsimd-benchmark Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 06/10] gnu: Add xtensor-benchmark Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 07/10] gnu: ceres-solver: Mark as tunable Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 08/10] gnu: Add ceres-solver-benchmarks Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 09/10] gnu: libfive: Mark as tunable Ludovic Courtès
2021-12-04 20:49   ` [bug#52283] [PATCH 10/10] gnu: prusa-slicer: " Ludovic Courtès
2021-12-05  8:37   ` [bug#52283] [PATCH 00/10] Tuning packages for CPU micro-architectures Mathieu Othacehe
2021-12-06 10:38     ` Ludovic Courtès
2021-12-06 12:47       ` zimoun
2021-12-07  8:39       ` Mathieu Othacehe
2021-12-07  9:02         ` Ludovic Courtès
2021-12-06 16:48     ` Ludovic Courtès
2021-12-04 21:11 ` Ludovic Courtès
2021-12-07  9:13 ` Ludovic Courtès
2021-12-16 17:58   ` Ludovic Courtès [this message]
2021-12-16 17:58     ` [bug#52283] [PATCH v2 01/12] Add (guix cpu) Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 02/12] gnu: gcc: Add 'compiler-cpu-architectures' property Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 03/12] gnu: clang: " Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 04/12] transformations: Add '--tune' Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 05/12] ci: Add extra jobs for tunable packages Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 06/12] gnu: Add eigen-benchmarks Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 07/12] gnu: Add xsimd-benchmark Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 08/12] gnu: Add xtensor-benchmark Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 09/12] gnu: ceres-solver: Mark as tunable Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 10/12] gnu: Add ceres-solver-benchmarks Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 11/12] gnu: libfive: Mark as tunable Ludovic Courtès
2021-12-16 17:58     ` [bug#52283] [PATCH v2 12/12] gnu: prusa-slicer: " Ludovic Courtès
2022-01-01 14:59     ` bug#52283: [PATCH 00/10] Tuning packages for CPU micro-architectures Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216175827.2077-1-ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=52283@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.