From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yBDyJamarmGd2wAAgWs5BA (envelope-from ) for ; Tue, 07 Dec 2021 00:20:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wPSDIamarmHDYwAAbx9fmQ (envelope-from ) for ; Mon, 06 Dec 2021 23:20:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F12FC0E6 for ; Tue, 7 Dec 2021 00:20:09 +0100 (CET) Received: from localhost ([::1]:58050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muNHD-0001ZT-Ne for larch@yhetil.org; Mon, 06 Dec 2021 18:20:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muNH8-0001Z2-BS for guix-patches@gnu.org; Mon, 06 Dec 2021 18:20:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muNH8-0006Mn-3W for guix-patches@gnu.org; Mon, 06 Dec 2021 18:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muNH7-0006DF-Vg for guix-patches@gnu.org; Mon, 06 Dec 2021 18:20:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52283] [PATCH 02/10] transformations: Add '--tune'. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Dec 2021 23:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52283 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52283@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: 52283@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 52283-submit@debbugs.gnu.org id=B52283.163883274623790 (code B ref 52283); Mon, 06 Dec 2021 23:20:01 +0000 Received: (at 52283) by debbugs.gnu.org; 6 Dec 2021 23:19:06 +0000 Received: from localhost ([127.0.0.1]:35650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muNGE-0006Be-0J for submit@debbugs.gnu.org; Mon, 06 Dec 2021 18:19:06 -0500 Received: from mx.kolabnow.com ([212.103.80.155]:37282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muNGC-0006BA-Mx for 52283@debbugs.gnu.org; Mon, 06 Dec 2021 18:19:05 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id B4AD3DF8; Tue, 7 Dec 2021 00:18:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1638832738; x=1640647139; bh=b2Ptuktensnw2rByD4FX3iaXX3HfRq0Gvtq Qp0JazNY=; b=iQHA0OqSF29P8kcG5+Nfh9CdO+b2jq8wFZ+bXPF/vIgZ1mNU3oi vSnL9FnbCArH0Y2ZYKPnyFZEaRRYIS6ONrE9d9GezNvRX4THbMTHJlvcg/jM7FB2 xyi75Cm0bbTy6qYqd69ge+Aq+Sc+U8q/gGfOh8ay6/EzdiaJG3ADNqu9p8y4U6hs Fh5JYuqtj60elY/R58qdGizU/91p3O07BUtAdBA50X/R37qgloNoDu2V3fo9hafP 5mLumJMiifnASeNs8mL7CQJo1PohY6ApU2kVtiV1dq5lVjc/vSpcSoVPGHQ3+Nre EWcPtrK9W87MDDEY0vbYbUYm83QTgtcqvGVuLAEnZ5igcsJeSld3vPcGVz0Q1bgi soixTrYGiRiu4vaoz92l34wa+gyjZ8ubWjXL8XD6EGY6WJ3i+QsIJpic04KdGD6Q PjSQHyWlmeBOWtpEvM0QD8ysZnmRsO0rN/uEYkkcb/wg6F61POBLB5UtWzEI5thf ecsfV6bsGeFxIrKNjN0wZFVdtddI7DO/If81p01VJRDdFnWSCzLvHwKMzsgSC3+z OZ7EUIEIco4SYYrtO+vMo7c569Ai4uVLDQkyJCIXJwImqOP2/cOuplJ71aBy2W+K WU9ZXGa0Hl3ZOminzQuXgJ5iuIdc04YAZO4PyVazETux8Ihklb/Ta13I= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZAZ6q9mNy0jK; Tue, 7 Dec 2021 00:18:58 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 4587BA30; Tue, 7 Dec 2021 00:18:58 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 140E271A9; Tue, 7 Dec 2021 00:18:56 +0100 (CET) Date: Mon, 06 Dec 2021 20:18:51 -0300 Message-ID: <7364829.rrRS6mQaNJ@popigai> In-Reply-To: <20211204204924.15581-2-ludo@gnu.org> References: <20211204204924.15581-1-ludo@gnu.org> <20211204204924.15581-2-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638832809; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b2Ptuktensnw2rByD4FX3iaXX3HfRq0GvtqQp0JazNY=; b=eC1xzoYiKNwzWTeUPTwLleIQ/Vfw9narEITEaRUyisU2TeAmR65n7Q0xz/OZgEY6/0rNzt aOetRP+xS1WDuK7MpTpZvvLzSOekI8aRw8D4XYKMoR8eQoBEt7bQWp50p+Dn8bMfG1uKqJ 3naqAuFZN8CouCcGxENocApETK7X/7V2gtO1TT1XJxSF3P6LMweE6XuBxOQDURX3tWpznq vx6u64sc83FEpCd/zE2jnmpG4hvXq0uigbhYIs/Ilc+k9OF8H0goJgA0ZrN8vyS/RJrCyO w1hs+GaAKa5vXSKuSm185FuG5HImcn0LLB3awfwaiig2Fa1PI4chgIXQauoxDQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638832809; a=rsa-sha256; cv=none; b=amZGe7bHmTeZoO5Z21V3xbzXht4GyAHOUBgkcDM2YW8W+zPSpKl8+UJry6+LmGS0I02TIf RNM7AxRp2ArzPpCQw5Sp8ev+f6g5vOfTC6MBt1qCm7ztrDpcqwUwxr5qLId9zSM0zzL8yf LqtLMP1CDbsh6gTsLsno8E0jNbLlQnPKegp03KkHGpNFncdelx/Vt2EQZ0KHyeDN6KaUE+ YjVnqhbUrp4uWJIh2k0EHlYPdjpI5MbGvSc1fJ3XHzBnfiRmofaFALa6JJogznqPa6f1kW 5GzRr0aOJBVuihrYt5XYJrxJneC/rzMH2qwq8hd5JNAElqzUoPncfl5A83QKoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=iQHA0OqS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=iQHA0OqS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3F12FC0E6 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: dZLudqKOvW3S Hello Ludo, Awesome series! I only have comments about this patch, and then only minor= =20 ones: Em s=C3=A1bado, 4 de dezembro de 2021, =C3=A0s 17:49:16 -03, Ludovic Court= =C3=A8s=20 escreveu: > +Tuned packages are @emph{grafted} onto packages that depend on them > +(@pxref{Security Updates, grafts}). Thus, using @option{--no-grafts} > +annihilates the effect of @option{--tune}. Perhaps this is because English isn=E2=80=99t my first language, but annihi= lation=20 seems like a violent and dramatic effect in a package transformation. :-) Perhaps reword as =E2=80=9Ccancels=E2=80=9D, =E2=80=9Cinvalidates=E2=80=9D = or "nullifies"? > +(define (tuned-package p micro-architecture) > + "Return package P tuned for MICRO-ARCHITECTURE." > + (define compiler > + (tuning-compiler micro-architecture)) > + > + (package > + (inherit p) > + (native-inputs > + ;; Arrange so that COMPILER comes first in $PATH. > + `(("tuning-compiler" ,compiler) > + ,@(package-native-inputs p))) > + (arguments > + (substitute-keyword-arguments (package-arguments p) > + ((#:tests? _ #f) #f))) Perhaps I=E2=80=99m reading this wrong, but it looks like tuned packages do= n=E2=80=99t run=20 their testsuites? If so, this is a surprising side-effect and thus it would= =20 be nice to have it mentioned in the manual, possibly also in a comment=20 here. It would be nice to also mention the rationale for disabling the=20 tests (not sure whether only in a comment here or if in the manual as=20 well). I assume it=E2=80=99s for convenience, but I=E2=80=99m not sure. =2D-=20 Thanks, Thiago