From: Nils Landt <nils@landt.email>
To: Bruno Victal <mirai@makinata.eu>
Cc: 66557@debbugs.gnu.org
Subject: [bug#66557] [PATCH] home: services: Add goimapnotify service.
Date: Tue, 21 Nov 2023 16:25:21 +0100 (CET) [thread overview]
Message-ID: <656336790.399020.1700580321203@office.mailbox.org> (raw)
In-Reply-To: <d279a547-7f5c-4244-8f78-ad0fb98cbe2c@makinata.eu>
Thank you for the feedback, I'll work on implementing it, hopefully on the weekend.
I've already added a few comments / questions below though.
> Bruno Victal <mirai@makinata.eu> hat am 20.11.2023 18:16 CET ls,
>
> On 2023-10-15 15:01, Nils Landt wrote:
> > This patch adds a home service for generating goimapnotify JSON
> > configuration files.
>
> […]
>
> Not a goimapnotify user but this looks like a daemon application.
> I don't like this design much, I think goimapnotify should be launched and managed
> using shepherd instead of simply exposing these files to the user.
These options can not be given as command line options, they need to be in a config file.
Personally I don't use shepherd, so I won't be contributing shepherd services :)
> > +@item @code{username-cmd} (type: maybe-string-or-file-like)
> > +An executable or script that retrieves your username from
> > +somewhere, we cannot pass arguments to this command from Stdin.
>
> I'd prefer to write it as “stdin” (lowercase) or expand it to “standard input”.
I think this a good change, and I'm completely fine making it. I just want to mention that I copied these docstrings directly from the project's readme. But I see no reason why the author would capitalize it.
> > +(define (list-of-goimapnotify-accounts? lst)
> > + "List is in the form of '((file-name file-like))"
> > + (every (lambda (element)
> > + (match element
> > + ((string ($ <goimapnotify-account>))
> > + #t)
> > + (_ #f)))
> > + lst))
>
> You can replace this with:
> --8<---------------cut here---------------start------------->8---
> (define list-of-goimapnotify-accounts?
> (list-of goimapnotify-account?))
> --8<---------------cut here---------------end--------------->8---
Wouldn't that fail because it expects '(goimapnotify-account goimapnotify-account[...])?
> This looks misindented, the .dir-locals file automatically handles
> this if you are using emacs.
I'm using vim. The code is indented with autoindent, as mentioned on https://guix.gnu.org/manual/devel/en/html_node/Vim-and-NeoVim.html . If this doesn't match the expected indentation as implemented in Emacs, I'd be grateful if you could indent this file before merging.
next prev parent reply other threads:[~2023-11-21 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 14:01 [bug#66557] [PATCH] home: services: Add goimapnotify service Nils Landt
2023-11-02 8:55 ` Ricardo Wurmus
2023-11-20 17:16 ` Bruno Victal
2023-11-21 15:25 ` Nils Landt [this message]
2023-11-28 20:37 ` Bruno Victal
2023-11-21 15:30 ` Nils Landt
2023-11-26 10:31 ` Nils Landt
2023-11-26 11:14 ` Nils Landt
2023-11-29 17:20 ` Bruno Victal
2023-12-03 15:56 ` Nils Landt
2023-12-03 15:53 ` Nils Landt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656336790.399020.1700580321203@office.mailbox.org \
--to=nils@landt.email \
--cc=66557@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.