all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nils Landt <nils@landt.email>
To: "66557@debbugs.gnu.org" <66557@debbugs.gnu.org>
Cc: "rekado@elephly.net" <rekado@elephly.net>,
	"mirai@makinata.eu" <mirai@makinata.eu>
Subject: [bug#66557] [PATCH] home: services: Add goimapnotify service.
Date: Sun, 26 Nov 2023 12:14:20 +0100 (CET)	[thread overview]
Message-ID: <1635724009.68147.1700997260830@office.mailbox.org> (raw)
In-Reply-To: <c9d8798670448a18779e3c24b9b8a88902942936.1697378478.git.nils@landt.email>

Hello,

I have pushed a new version.
Compared to the version you reviewed, I made the following changes:
- docs: Stdin -> stdin
- docs: use file-append for "pass" example
- docs: re-add trailing whitespace
- rework filter + map to use fold instead
- update link to upstream config documentation from master to current commit
- ignore first element in list-of-goimapnotify-accounts?
- add question mark suffix to boolean fields (e.g. tls -> tls?)
- fix "on-new-mail" option in docstring
- remove parentheses around configuration field types

Lastly, some comments on review requests I was unable to implement.

Ricardo:
> So I think it would be better to let these fields accept command lists.
> FILE-APPEND should only join the package value with the file name of the
> executable, but not include any arguments.

I did not understand what this meant. Do you have any examples? I implemented your second suggestion of using file-append for pass instead.

> Could this be (cons (goimapnotify-format-field field-name) value)
> instead?  I don’t think we need this wrapping and unwrapping with G-exp
> syntax.

This results in e.g. ("boxes" . #("INBOX")) , leading to a syntax error in the generated guile script. I'm open to suggestions here.

Bruno:
> This isn't needed, fields whose maybe-values are unset don't call the
> serializing procedures.

combined with

> You can use 'serialize-configuration' instead which accounts for the unset maybe-values.

I put some time into this, but I don't see how serialize-configuration, which returns a gexp including string-append, could be used to turn a configuration record into the format required by guile-json.




  parent reply	other threads:[~2023-11-26 11:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15 14:01 [bug#66557] [PATCH] home: services: Add goimapnotify service Nils Landt
2023-11-02  8:55 ` Ricardo Wurmus
2023-11-20 17:16 ` Bruno Victal
2023-11-21 15:25   ` Nils Landt
2023-11-28 20:37     ` Bruno Victal
2023-11-21 15:30 ` Nils Landt
2023-11-26 10:31 ` Nils Landt
2023-11-26 11:14 ` Nils Landt [this message]
2023-11-29 17:20   ` Bruno Victal
2023-12-03 15:56     ` Nils Landt
2023-12-03 15:53 ` Nils Landt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1635724009.68147.1700997260830@office.mailbox.org \
    --to=nils@landt.email \
    --cc=66557@debbugs.gnu.org \
    --cc=mirai@makinata.eu \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.