From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aLiqESnMXGX7CQAA9RJhRA:P1 (envelope-from ) for ; Tue, 21 Nov 2023 16:26:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aLiqESnMXGX7CQAA9RJhRA (envelope-from ) for ; Tue, 21 Nov 2023 16:26:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1578931CB7 for ; Tue, 21 Nov 2023 16:26:33 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=landt.email header.s=MBO0001 header.b=Ur46iqQY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=landt.email (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700580393; a=rsa-sha256; cv=none; b=qnkriBUP2TaNYk0j3WVDsiXh0UYVmF0L2AyJteIhUL2geEHoYpUJUHfW6zYMs/cEoHWr5/ H/qwoHnsghT/BSM1n+3/KENZ3/I86oJJXi4g1s/xYHJjc9XVE3NGa9uvXeUoXUjixVok2p vdPuX6PZy1aPC9cOVOIk95HF7TWNJ6Fg43gBZ9U7ueKS1L1EzfE1T7iLyj0P2lWrvd+Kec QfGp3RTdJgl8uVrtEyzvq+5j35+nnkRJ9vnmKpAxM6Ef2UkNiV2giOUqbXKifi+aMhEboz poVuwSAAVugfTDl9kU9nvUgTO04RWDP6PPDcthq+EM8EWYei/FeJTNTjrhDlhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=landt.email header.s=MBO0001 header.b=Ur46iqQY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=landt.email (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700580393; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=10DNSqGfqfhZ/xNo8KQ15ThMgRfLIYsnTOdeEpoknvY=; b=SP7hKOrgTCcm6MwZ1hzDgyOt43PENNVTSgCTCgfKdxKVeK4TqWceQl0DLeQ4wYkeH4xmiX hm2+dPHcIp6gc6iT7FnFJUAcB0ZrTtjUDbuoVfi9Tlr1yG4FVFXOk3cANmBUw5vAly0eTn vyqQYLlASD+MljD3po2XOcO4pJJMg+TKzNF7782z0uxSbWhz76p/rUxjlaxdz3H7hIgy5w 9W5PqJmjF+ykHiqdd+IGiJIOXcQ2BdhEMqF8dNFAhwLiwb5MZuuKjdTlz/fYx6PhDWaHgS uZixOzXbiKbl73eN8qunhjTtwNqFMeNs0dQYYho39A6VIYAfsggkWLkHq4JUCw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5Sdc-0007hb-Tp; Tue, 21 Nov 2023 10:26:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5SdU-0007fK-De for guix-patches@gnu.org; Tue, 21 Nov 2023 10:26:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5SdT-00030Y-J5 for guix-patches@gnu.org; Tue, 21 Nov 2023 10:25:59 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r5SdW-0005rL-80 for guix-patches@gnu.org; Tue, 21 Nov 2023 10:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66557] [PATCH] home: services: Add goimapnotify service. Resent-From: Nils Landt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Nov 2023 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66557 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 66557@debbugs.gnu.org Received: via spool by 66557-submit@debbugs.gnu.org id=B66557.170058033522481 (code B ref 66557); Tue, 21 Nov 2023 15:26:02 +0000 Received: (at 66557) by debbugs.gnu.org; 21 Nov 2023 15:25:35 +0000 Received: from localhost ([127.0.0.1]:57240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5Sd4-0005qX-P0 for submit@debbugs.gnu.org; Tue, 21 Nov 2023 10:25:35 -0500 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]:39464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5Sd2-0005qF-P0 for 66557@debbugs.gnu.org; Tue, 21 Nov 2023 10:25:34 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4SZSqj4wtNz9t2C; Tue, 21 Nov 2023 16:25:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landt.email; s=MBO0001; t=1700580321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10DNSqGfqfhZ/xNo8KQ15ThMgRfLIYsnTOdeEpoknvY=; b=Ur46iqQYiiABPZpXZi2UP8g8L6xkpPi7a7n0ZCTo7wVOCNOcK/qJ5MnB2IU6J71itEdTeH WENugjMUX96eMyNXtpnUYHy6797adZhiVSJlRhU8XHDhzzrbKnGyvQgir7iJdmOHtBTs3G qUK6zshlvpv6oZVqcnUjRIFsMxl2YAkRB+tIu3HyshoEClQuhrxTDO13bdVrrXLjMOxrkl bafLSHme6X7updy9ZhvD68qi8347eEBV5QUFdOCs99QQp5Iq9UA29qXlyE1H/xbqdz8fUj 9nBWWgHYGOekBsf5RHw0hYxREuZ8v1KZagT8Z0RQBakCxH16tj84Oer/Qg9ESA== Date: Tue, 21 Nov 2023 16:25:21 +0100 (CET) From: Nils Landt Message-ID: <656336790.399020.1700580321203@office.mailbox.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Rspamd-Queue-Id: 4SZSqj4wtNz9t2C X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 1578931CB7 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.21 X-Spam-Score: -5.21 X-TUID: +eDcXleSxIML Thank you for the feedback, I'll work on implementing it, hopefully on the = weekend.=20 I've already added a few comments / questions below though. > Bruno Victal hat am 20.11.2023 18:16 CET ls, >=20 > On 2023-10-15 15:01, Nils Landt wrote: > > This patch adds a home service for generating goimapnotify JSON > > configuration files. >=20 > [=E2=80=A6] >=20 > Not a goimapnotify user but this looks like a daemon application. > I don't like this design much, I think goimapnotify should be launched an= d managed > using shepherd instead of simply exposing these files to the user. These options can not be given as command line options, they need to be in = a config file. Personally I don't use shepherd, so I won't be contributing shepherd servic= es :) > > +@item @code{username-cmd} (type: maybe-string-or-file-like) > > +An executable or script that retrieves your username from > > +somewhere, we cannot pass arguments to this command from Stdin. >=20 > I'd prefer to write it as =E2=80=9Cstdin=E2=80=9D (lowercase) or expand i= t to =E2=80=9Cstandard input=E2=80=9D. I think this a good change, and I'm completely fine making it. I just want = to mention that I copied these docstrings directly from the project's readm= e. But I see no reason why the author would capitalize it. > > +(define (list-of-goimapnotify-accounts? lst) > > + "List is in the form of '((file-name file-like))" > > + (every (lambda (element) > > + (match element > > + ((string ($ )) > > + #t) > > + (_ #f))) > > + lst)) >=20 > You can replace this with: > --8<---------------cut here---------------start------------->8--- > (define list-of-goimapnotify-accounts? > (list-of goimapnotify-account?)) > --8<---------------cut here---------------end--------------->8--- Wouldn't that fail because it expects '(goimapnotify-account goimapnotify-a= ccount[...])? > This looks misindented, the .dir-locals file automatically handles > this if you are using emacs. I'm using vim. The code is indented with autoindent, as mentioned on https:= //guix.gnu.org/manual/devel/en/html_node/Vim-and-NeoVim.html . If this does= n't match the expected indentation as implemented in Emacs, I'd be grateful= if you could indent this file before merging.