From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0E3mMmTKcmH04gAAgWs5BA (envelope-from ) for ; Fri, 22 Oct 2021 16:27:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WKKLLmTKcmFRAwAA1q6Kng (envelope-from ) for ; Fri, 22 Oct 2021 14:27:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95D02312A6 for ; Fri, 22 Oct 2021 16:27:48 +0200 (CEST) Received: from localhost ([::1]:49092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdvWN-0003lf-P6 for larch@yhetil.org; Fri, 22 Oct 2021 10:27:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdvVe-0002lh-EA for guix-patches@gnu.org; Fri, 22 Oct 2021 10:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdvVe-0003RW-3o for guix-patches@gnu.org; Fri, 22 Oct 2021 10:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdvVd-0006at-SN for guix-patches@gnu.org; Fri, 22 Oct 2021 10:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp. References: <20210724085155.21417-1-i.gankevich@spbu.ru> In-Reply-To: <20210724085155.21417-1-i.gankevich@spbu.ru> Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Oct 2021 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49715 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49715@debbugs.gnu.org Cc: Ivan Gankevich Received: via spool by 49715-submit@debbugs.gnu.org id=B49715.163491278425287 (code B ref 49715); Fri, 22 Oct 2021 14:27:01 +0000 Received: (at 49715) by debbugs.gnu.org; 22 Oct 2021 14:26:24 +0000 Received: from localhost ([127.0.0.1]:33422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdvV2-0006Zn-IF for submit@debbugs.gnu.org; Fri, 22 Oct 2021 10:26:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdvUz-0006ZQ-Ru for 49715@debbugs.gnu.org; Fri, 22 Oct 2021 10:26:22 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 1B714240101 for <49715@debbugs.gnu.org>; Fri, 22 Oct 2021 16:26:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634912775; bh=w21d5qQSkRxlY46m8KYqA+gq5aDK6YX+0PpRdkN/USA=; h=Subject:From:To:Cc:Date:From; b=hGm3YTfIud0kYanYNkqPT3Kp9J04y3zcy0JBfujijm9cEygVv4IWlmWtGENkqVWes lqwQF6dtyb+y3OITn9QYkuI2u5Wn0SrAHPLtlC3vgpk5hxMyZajkcE/F0KntdeGGrY 7FXStJKv6SpPkm5EJ64PGUNDxsndNhpE/7ePiawobR9LBLqPdJv77ZwX7CrJszAmc7 0W5vsk7gvfMyugRsjf4YVq13deExFKjspytCskdLiXxC+yc2fHYj97YU7UtMF0+Vnl F9eXXaFNllAWLnI0KMJtgeFW0nL14KIFUtF5eBTM+TTsxnFuLYIL+ePF4IM92zIiyu DptNfxxccCBEQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HbRVF1rhwz9rxL; Fri, 22 Oct 2021 16:26:12 +0200 (CEST) Message-ID: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> From: Vinicius Monego Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 22 Oct 2021 14:14:15 +0000 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634912868; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=m9yPlTYlx3lQ1EBYu6OeJBYxgLZmvZS6c1ME0ld+Hzc=; b=Z5x++q3tyqmqcCH1d2KWEJpFqPE+ifWtTEajbbWhmyI1jLwUD6KPGPpKVG5rMZAZqg+ksG zDUI/RY+Jy6SNDNsmyPX8T8zm3mDR35mRInwtIqGDCPfyfErqAuXVyo3DXHEn7yVofamNR 1ZX3dJX1saSySj8OXso0knznQOXX58pD+f7pN4BmDbeyZezX295YbYlW5iCAPUPfLSYxV7 uvLYfAY9oqgPzK2IaUQ+JzzBsjqN2FOvur4zoM4kXV5dgRrmrxhTanVv0t9Rfssq6QfNsV 90wHCsBU0I7kwEYQzWjfrZSERQqYap4+poAp23A+rxIthx+BWIeyTwX7lh44cg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634912868; a=rsa-sha256; cv=none; b=iwp72A4UgpNVuc5p6y9ApXGPizzjRCmgvC4BR3R6gZFmGzllPJwyM8S41ysAtcuqELgW1C lY+jejWGlXIQsG1rehXYVOt2X+5ekIAgt+mayXpcRfILQPR8opbmrGY9yjJ2ToKp2peloq 5i/ivT+4U9NvsnkDfi7NVov3IUlE0fIO4UAu6kbx/1euOrV69iqmdJG7DQoujCOpomFluT B99bGXCSBqG+apDJqyfPDVrRXoXBPlKlizVSWelFBPYo5ejzyCU4+0HSyjNhqSmHFSHZfm vHjgCmgwH+TU9PfGLEejfhgLazBWXvRQ25BVZqein4JcO2AVqzSSHOc14/4oSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=hGm3YTfI; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=hGm3YTfI; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 95D02312A6 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: jluLs6dqEINZ Hi, > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable. I built and tested this patch and can confirm it works. A few nitpicks that I have: > + (inputs > + ;; GIMP and its dependencies. > + `(("gimp" ,gimp) > + ("gdk-pixbuf" ,gdk-pixbuf) > + ("cairo" ,cairo) > + ("gegl" ,gegl) > + ,@(package-inputs gmic-qt))) Should be one space below inputs. Also the labeled inputs should be sorted alphabetically. See the gmic-qt package for instance. > + (arguments > + (substitute-keyword-arguments (package-arguments gmic-qt) > + ((#:configure-flags flags) > + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON" > + (string-append "-DGMIC_LIB_PATH=" > + (assoc-ref %build-inputs "gmic") > "/lib"))))) Should be one space below arguments (see gmic-qt-krita for instance). If you're using Emacs, the indentation should be fixed automatically with M-x indent-sexp or indent-region. Vinicius