From: Leo Prikler <leo.prikler@student.tugraz.at>
To: terramorpha@cock.li, 49510@debbugs.gnu.org
Subject: bug#49510: [PATCH] gnu: Add PuTTY.
Date: Mon, 12 Jul 2021 07:42:21 +0200 [thread overview]
Message-ID: <4d1b1727da1000b37adf2285ac5b84c09b0cb438.camel@student.tugraz.at> (raw)
In-Reply-To: <1e2aa5364dc3f358a123e915d79c275e@cock.li>
Hi terramorpha,
your patch is missing the ChangeLog part of the commit message,
see `info '(guix)Submitting Patches'` for more information.
Am Samstag, den 10.07.2021, 15:31 -0400 schrieb terramorpha@cock.li:
> diff --git a/gnu/packages/networking.scm
> b/gnu/packages/networking.scm
> index 19b58501e9..af3082b954 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -4100,3 +4100,37 @@ on hub/switched networks. It is based on
> @acronym{ARP} packets, it will send
> @acronym{ARP} requests and sniff for replies.")
> (home-page "https://github.com/netdiscover-scanner/netdiscover")
> (license license:gpl3+)))
> +
> +(define-public putty
> + (package
> + (name "putty")
> + (version "0.74.0")
> + (source (origin
> + ;; (method url-fetch)
> + (method url-fetch)
> + (uri "http://www.putty.be/0.74/putty-0.74.tar.gz")
You ought to reuse version here, so that people don't need to rewrite
it when the version changes. You can use "version-major+minor" to
access the "0.74" part, but I assume this is one of the versions, that
gets patch added to the tarball if it exists. Such packages too exist
somewhere in Guix, but I haven't found an example in the quick time I'm
typing this reply.
> + (sha256 (base32
> "0zc43g8ycyf712cdrja4k8ih5s3agw1k0nq0jkifdn8xwn4d7mfx"))))
Please watch your line length, it normally shouldn't exceed 80
characters.
> + (arguments
> + `(#:tests?
> + #f
Never let #tests? #f stay uncommented.
> + #:phases (modify-phases %standard-phases
> + (add-before 'configure 'go-into-unix/
> + (lambda _ (begin
> + (chdir "unix")
> + #t))))))
> + (build-system gnu-build-system)
> + (inputs `(("perl" ,perl)
> + ("python" ,python)
> + ("python2" ,python-2.7)
> + ("pkg-config" ,pkg-config)
> + ("gtk+" ,gtk+)))
Your formatting generally looks a bit off. #:phases should go to an
extra line, as should inputs. #:tests? #f OTOH is okay in one line
with the aforementioned comment.
> + (synopsis "A graphical @acronym{SSH} and telnet client")
> + (description
> + "Putty is a powerful terminal client. It supports
> @acronym{SSH},
> telnet,
> +and raw socket connections with good terminal emulation. It
> supports
> public
> +key authentication and Kerberos single-sign-on. It also includes
> command-line
> +@acronym{SFTP} and @acronym{SCP} implementations.")
> + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/"
> )
> + (license (license:non-copyleft
> +
> "https://www.chiark.greenend.org.uk/~sgtatham/putty/licence.html"
> + "The putty license"))))
Putty claims, that this is license:expat and it does look like one.
Regards,
Leo
next prev parent reply other threads:[~2021-07-12 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 19:31 bug#49510: [PATCH] gnu: Add PuTTY terramorpha
2021-07-12 5:42 ` Leo Prikler [this message]
2021-07-13 17:25 ` terramorpha
2021-07-13 17:44 ` Leo Prikler
2021-07-13 20:33 ` terramorpha
[not found] ` <c37956fce8e6c0cbbc97379a4e80b338@cock.li>
2021-07-13 20:49 ` terramorpha
2021-07-15 15:36 ` bug#49510: [PATCH] Justin Veilleux
2021-07-15 19:01 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d1b1727da1000b37adf2285ac5b84c09b0cb438.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49510@debbugs.gnu.org \
--cc=terramorpha@cock.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.