From: Leo Prikler <leo.prikler@student.tugraz.at>
To: terramorpha@cock.li, 49510@debbugs.gnu.org
Subject: bug#49510: [PATCH] gnu: Add PuTTY.
Date: Tue, 13 Jul 2021 19:44:54 +0200 [thread overview]
Message-ID: <bd47da1a915f98ff27c3a71cd9a347ff337f37f2.camel@student.tugraz.at> (raw)
In-Reply-To: <bfb8cf43bc45b941c7209c7fe4fd9f85@cock.li>
Am Dienstag, den 13.07.2021, 13:25 -0400 schrieb terramorpha@cock.li:
> Hi, thank you for the review.
>
> I corrected the version of the package (putty doesn't use
> major.minor.patch, only major.minor), I fixed the lines that were
> over the 80 character limit, re added the check phase, corrected the
> formatting and put in the expat license. However, I do not know what
> you mean by the "ChangeLog part of the commit message", I thought
> that standalone patch didn't have a commit message attached.
> Could you elaborate?
>
> Here is the modified patch.
Please don't send raw diffs and more importantly don't copypaste them
into your mail client (unless you know exactly, that your mail client
behaves in a correct manner, which most don't). Mail clients have a
tendency to mess up whitespace and line lengths, which can and does
break diffs. Instead, use `git format-patch` and attach the generated
patch file or (the following way is preferred) use `git send-email`.
When using format-patch/send-email, the full commit message and
name/email of the committer will be transmitted as well, not just a raw
diff.
Your second patch LGTM, perhaps with a few fixable formatting stuffs,
but I'll have to ask you to resend it, since I can't `git am` it.
Thanks,
Leo
> diff --git a/gnu/packages/networking.scm
> b/gnu/packages/networking.scm
> index 19b58501e9..ce00a016e6 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -4100,3 +4100,38 @@ on hub/switched networks. It is based on
> @acronym{ARP} packets, it will send
> @acronym{ARP} requests and sniff for replies.")
> (home-page "https://github.com/netdiscover-scanner/netdiscover")
> (license license:gpl3+)))
> +
> +(define-public putty
> + (package
> + (name "putty")
> + (version "0.75")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "http://www.putty.be/" version
> + "/putty-" version ".tar.gz"))
> + (sha256
> + (base32
> "1xgrr1fbirw79zafspg2b6crzfmlfw910y79md4r7gnxgq1kn5yk"))))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'go-into-unix/
> + (lambda _ (begin
> + (chdir "unix")
> + #t))))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("perl" ,perl)
> + ("python" ,python)
> + ("python2" ,python-2.7)))
> + (synopsis "Graphical @acronym{SSH} and telnet client")
> + (description
> + "Putty is a powerful terminal client. It supports
> @acronym{SSH},
> telnet,
> +and raw socket connections with good terminal emulation. It
> supports
> public key
> +authentication and Kerberos single-sign-on. It also includes
> command-line
> +@acronym{SFTP} and @acronym{SCP} implementations.")
> + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/"
> )
> + (license license:expat)))
next prev parent reply other threads:[~2021-07-13 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 19:31 bug#49510: [PATCH] gnu: Add PuTTY terramorpha
2021-07-12 5:42 ` Leo Prikler
2021-07-13 17:25 ` terramorpha
2021-07-13 17:44 ` Leo Prikler [this message]
2021-07-13 20:33 ` terramorpha
[not found] ` <c37956fce8e6c0cbbc97379a4e80b338@cock.li>
2021-07-13 20:49 ` terramorpha
2021-07-15 15:36 ` bug#49510: [PATCH] Justin Veilleux
2021-07-15 19:01 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd47da1a915f98ff27c3a71cd9a347ff337f37f2.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=49510@debbugs.gnu.org \
--cc=terramorpha@cock.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.