From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oNJ9BX7W62AJegAAgWs5BA (envelope-from ) for ; Mon, 12 Jul 2021 07:43:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0FZVAX7W62CNEQAAB5/wlQ (envelope-from ) for ; Mon, 12 Jul 2021 05:43:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F1074D67 for ; Mon, 12 Jul 2021 07:43:25 +0200 (CEST) Received: from localhost ([::1]:39340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2oiv-0000Ci-UW for larch@yhetil.org; Mon, 12 Jul 2021 01:43:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2oid-00008Y-T2 for bug-guix@gnu.org; Mon, 12 Jul 2021 01:43:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2oic-0001QC-Ae for bug-guix@gnu.org; Mon, 12 Jul 2021 01:43:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2oic-0003sA-AC for bug-guix@gnu.org; Mon, 12 Jul 2021 01:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#49510: [PATCH] gnu: Add PuTTY. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 12 Jul 2021 05:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49510 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: terramorpha@cock.li, 49510@debbugs.gnu.org Received: via spool by 49510-submit@debbugs.gnu.org id=B49510.162606855214848 (code B ref 49510); Mon, 12 Jul 2021 05:43:02 +0000 Received: (at 49510) by debbugs.gnu.org; 12 Jul 2021 05:42:32 +0000 Received: from localhost ([127.0.0.1]:36327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2oi8-0003rQ-1S for submit@debbugs.gnu.org; Mon, 12 Jul 2021 01:42:32 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:54331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2oi2-0003rD-TY for 49510@debbugs.gnu.org; Mon, 12 Jul 2021 01:42:30 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GNXhv19xCz1LBRv; Mon, 12 Jul 2021 07:42:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GNXhv19xCz1LBRv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626068543; bh=gjoqD5/LuO8rHnNDeQvaOop0hWmle7kVEE83C4+uYh8=; h=Subject:From:To:Date:In-Reply-To:References:From; b=YUbXE/4sDhOWzNZ5L3aeem2lyBGh7z4yB8QDAlziDK9fPwGyKFDCMoMNCNCjff4IQ yIbCIl9sxzvr3u7Yw8eTtHXB/MSQJAxsd0/edXTwik70SAZVWZ5gpWlAGkdJm1U4zY Z2768dkfODAM8RLGCkb+iAiweKfN2he9m/KGVvTw= Message-ID: <4d1b1727da1000b37adf2285ac5b84c09b0cb438.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 12 Jul 2021 07:42:21 +0200 In-Reply-To: <1e2aa5364dc3f358a123e915d79c275e@cock.li> References: <1e2aa5364dc3f358a123e915d79c275e@cock.li> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626068605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gjoqD5/LuO8rHnNDeQvaOop0hWmle7kVEE83C4+uYh8=; b=nJOxxFTxBDN0sb9d2pF+jgzUeOWPTwTonidnAeIIHfy3QdkG2gNcg/cvhZh1rRbZZpUK7e 4uuJGt3P4FltHuWH6SeQbEI722Z9bMI106fsPy9G3NGqUcvnBxAXTj0HzJrRgfVmfjJLl3 TTb/rQsamaKI8cZchkB350zFl0/reJD1DRbMR0nc8VvlVytLEpsmJ5VPdD7bG8/Q0kBZk9 VxkroSkw+etScfyi1czNhEtV0XxDHQkEqYHuX3O8/nQfMXQ/DgujXV+52daA41x7tgfqKD 19KDCNmCNBOzbkSKT8Q5CdGijSv/lJaGfG8EbeThUyZT39F6Yz3BqvcnAjSL4A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626068605; a=rsa-sha256; cv=none; b=JsuXUSMey41R0R6kxlBtzKoumyTf+xArxpJCwe5zQQ4HBjU5TjBCoXLW1qB2TA42+rhLIt ReGCPUcmzuUFHw4rIYVEyovVSeQpjWvTnhfED03WWERVabH4RjmZCzww+NZfm6W05pN7td HgqYUtx25D6JYKvugV+2AZsXTMhACQcTic6KLMLDxfYtxofDvjQ+zrBQbxHbmIcO2g++ef OMZB/3dzI1CYBCHtuWYPUJQZFgD4YmT+Bw+nFUNZIBLVukkbagX55QN4DOKiKkX6ZchXZg BqZ6qRq8xFg9V93qpUD7/QzM5HuY9dwQxLXCq0Ln1U7YSB2UbtNNiR5zLjA7vA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="YUbXE/4s"; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="YUbXE/4s"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 1F1074D67 X-Spam-Score: -1.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4/Of+EuC2t2Z Hi terramorpha, your patch is missing the ChangeLog part of the commit message, see `info '(guix)Submitting Patches'` for more information. Am Samstag, den 10.07.2021, 15:31 -0400 schrieb terramorpha@cock.li: > diff --git a/gnu/packages/networking.scm > b/gnu/packages/networking.scm > index 19b58501e9..af3082b954 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -4100,3 +4100,37 @@ on hub/switched networks. It is based on > @acronym{ARP} packets, it will send > @acronym{ARP} requests and sniff for replies.") > (home-page "https://github.com/netdiscover-scanner/netdiscover") > (license license:gpl3+))) > + > +(define-public putty > + (package > + (name "putty") > + (version "0.74.0") > + (source (origin > + ;; (method url-fetch) > + (method url-fetch) > + (uri "http://www.putty.be/0.74/putty-0.74.tar.gz") You ought to reuse version here, so that people don't need to rewrite it when the version changes. You can use "version-major+minor" to access the "0.74" part, but I assume this is one of the versions, that gets patch added to the tarball if it exists. Such packages too exist somewhere in Guix, but I haven't found an example in the quick time I'm typing this reply. > + (sha256 (base32 > "0zc43g8ycyf712cdrja4k8ih5s3agw1k0nq0jkifdn8xwn4d7mfx")))) Please watch your line length, it normally shouldn't exceed 80 characters. > + (arguments > + `(#:tests? > + #f Never let #tests? #f stay uncommented. > + #:phases (modify-phases %standard-phases > + (add-before 'configure 'go-into-unix/ > + (lambda _ (begin > + (chdir "unix") > + #t)))))) > + (build-system gnu-build-system) > + (inputs `(("perl" ,perl) > + ("python" ,python) > + ("python2" ,python-2.7) > + ("pkg-config" ,pkg-config) > + ("gtk+" ,gtk+))) Your formatting generally looks a bit off. #:phases should go to an extra line, as should inputs. #:tests? #f OTOH is okay in one line with the aforementioned comment. > + (synopsis "A graphical @acronym{SSH} and telnet client") > + (description > + "Putty is a powerful terminal client. It supports > @acronym{SSH}, > telnet, > +and raw socket connections with good terminal emulation. It > supports > public > +key authentication and Kerberos single-sign-on. It also includes > command-line > +@acronym{SFTP} and @acronym{SCP} implementations.") > + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/" > ) > + (license (license:non-copyleft > + > "https://www.chiark.greenend.org.uk/~sgtatham/putty/licence.html" > + "The putty license")))) Putty claims, that this is license:expat and it does look like one. Regards, Leo