From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38085) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFjVT-0004SK-W4 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFjVS-0003iU-Ja for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFjVS-0003iK-F7 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFjVS-0000Zh-AO for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:02 -0400 Subject: [bug#39786] [PATCH] Add dragonfly-reverb. Resent-Message-ID: Message-ID: <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org> From: Alexandros Theodotou Date: Sat, 21 Mar 2020 19:09:48 +0000 In-Reply-To: <877dzd8xly.fsf@nicolasgoaziou.fr> References: <877dzd8xly.fsf@nicolasgoaziou.fr> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-WcvPSxsVV70vTMN8UtGF" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 39786@debbugs.gnu.org --=-WcvPSxsVV70vTMN8UtGF Content-Type: multipart/mixed; boundary="=-AW8hzv1Xn6CykRDM3FGs" --=-AW8hzv1Xn6CykRDM3FGs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the feedback. Attaching the updated patch. I also removed some unneeded dependencies. Thanks, Alex 2020-03-21 (=E5=9C=9F) =E3=81=AE 17:46 +0100 =E3=81=AB Nicolas Goaziou =E3= =81=95=E3=82=93=E3=81=AF=E6=9B=B8=E3=81=8D=E3=81=BE=E3=81=97=E3=81=9F: > Hello, >=20 > Alexandros Theodotou writes: >=20 > > This patch adds dragonfly reverb, a popular reverb plugin. >=20 > Thank you! >=20 > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (bin (string-append out "/bin")) > > + (vst (string-append out "/lib/vst")) > > + (lv2 (string-append out "/lib/lv2"))) > > + (mkdir-p bin) > > + (mkdir-p vst) > > + (mkdir-p lv2) > > + > > + ;; Install VST > > + (for-each > > + (lambda (file) > > + (install-file file vst)) > > + (find-files "bin" "\\-vst.so$")) >=20 > Since you use `install-file' you don't need to `mkdir-p' beforehand, > i.e., you can drop (mkdir-p vst) above. >=20 > > + ;; Install standalone > > + (install-file "bin/DragonflyRoomReverb" bin) > > + (install-file "bin/DragonflyHallReverb" bin) >=20 > Ditto, you can drop (mkdir-p bin). >=20 > > + #t)))))) > > + (inputs > > + `(("jack" ,jack-1) > > + ("libx11" ,libx11) > > + ("mesa" ,mesa))) > > + (native-inputs > > + `(("lv2" ,lv2) > > + ("pkg-config" ,pkg-config))) > > + (synopsis "Concert hall reverb and room reverb effects") > > + (description > > + "Dragonfly Reverb is a bundle of two free audio effects: a > > concert > > +hall reverb and a room reverb. Both are available as VST and LV2 > > plugins, >=20 > You need to add two spaces after full stops. >=20 > Could you send an updated patch? >=20 > Regards, >=20 --=-AW8hzv1Xn6CykRDM3FGs Content-Disposition: attachment; filename="0001-gnu-Add-dragonfly-reverb.patch" Content-Type: text/x-patch; name="0001-gnu-Add-dragonfly-reverb.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxOTQxNDBkM2JiMzRkZjM2OWM1ODU5NjhjNWVlMmM5M2E0YjQxZjE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kcm9zIFRoZW9kb3RvdSA8YWxleEB6cnl0aG0ub3Jn PgpEYXRlOiBUdWUsIDI1IEZlYiAyMDIwIDE1OjE3OjEwICswMDAwClN1YmplY3Q6IFtQQVRDSF0g Z251OiBBZGQgZHJhZ29uZmx5LXJldmVyYgoKKiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIChkcmFn b25mbHktcmV2ZXJiKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9tdXNpYy5zY20g fCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBj aGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL211c2lj LnNjbSBiL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KaW5kZXggMTZlNjk4NDBkZi4uMWJkZDkwNWY3 NyAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL211c2ljLnNjbQorKysgYi9nbnUvcGFja2FnZXMv bXVzaWMuc2NtCkBAIC01MTg5LDMgKzUxODksNTUgQEAgZmVhdHVyZWZ1bCBhbmQgZWFzeSB0byB1 c2UuICBJdCBvZmZlcnMgdW5saW1pdGVkIGF1dG9tYXRpb24gb3B0aW9ucywgTFYyCiBwbHVnaW4g c3VwcG9ydCwgSkFDSyBzdXBwb3J0IGFuZCBjaG9yZCBhc3Npc3RhbmNlLiIpCiAgICAoaG9tZS1w YWdlICJodHRwczovL3d3dy56cnl0aG0ub3JnIikKICAgIChsaWNlbnNlIGxpY2Vuc2U6YWdwbDMr KSkpCisKKyhkZWZpbmUtcHVibGljIGRyYWdvbmZseS1yZXZlcmIKKyAgKHBhY2thZ2UKKyAgICAo bmFtZSAiZHJhZ29uZmx5LXJldmVyYiIpCisgICAgKHZlcnNpb24gIjIuMC4wIikKKyAgICAoc291 cmNlCisgICAgICAob3JpZ2luCisgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAo dXJpCisgICAgICAgICAgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICh1cmwgImh0dHBzOi8v Z2l0aHViLmNvbS9taWNoYWVsd2lsbGlzL2RyYWdvbmZseS1yZXZlcmIuZ2l0IikKKyAgICAgICAg ICAgIChjb21taXQgdmVyc2lvbikKKyAgICAgICAgICAgIDs7IGJ1bmRsZXMgYSBzcGVjaWZpYyBj b21taXQgb2YgdGhlIERJU1RSSE8gcGx1Z2luIGZyYW1ld29yaworICAgICAgICAgICAgKHJlY3Vy c2l2ZT8gI3QpKSkKKyAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNp b24pKQorICAgICAgICAoc2hhMjU2CisgICAgICAgICAgKGJhc2UzMiAiMXFyYnY0a2s1djZ5bng0 MjRoMWk1NHFqMHc4djZ2cHc4MWI3NTlqYXd4dnp6cHJwZ3E3MiIpKSkpCisgICAgKGJ1aWxkLXN5 c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgYCgjOnRlc3RzPyAj ZiA7IG5vIGNoZWNrIHRhcmdldAorICAgICAgICM6bWFrZS1mbGFncyAobGlzdCAiQ0M9Z2NjIikK KyAgICAgICAjOnBoYXNlcworICAgICAgIChtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMK KyAgICAgICAgIChkZWxldGUgJ2NvbmZpZ3VyZSkgOyBubyBjb25maWd1cmUgdGFyZ2V0CisgICAg ICAgICAocmVwbGFjZSAnaW5zdGFsbCA7IG5vIGluc3RhbGwgdGFyZ2V0CisgICAgICAgICAgIChs YW1iZGEqICgjOmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAg ICAgICAgKGxldCogKChvdXQgICAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAgICAgICAg ICAgICAgICAgICAoYmluICAgKHN0cmluZy1hcHBlbmQgb3V0ICIvYmluIikpCisgICAgICAgICAg ICAgICAgICAgIChsdjIgICAoc3RyaW5nLWFwcGVuZCBvdXQgIi9saWIvbHYyIikpKQorICAgICAg ICAgICAgICAgOzsgSW5zdGFsbCBMVjIKKyAgICAgICAgICAgICAgIChmb3ItZWFjaAorICAgICAg ICAgICAgICAgICAobGFtYmRhIChmaWxlKQorICAgICAgICAgICAgICAgICAgIChjb3B5LXJlY3Vy c2l2ZWx5IGZpbGUgKHN0cmluZy1hcHBlbmQgbHYyICIvIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGJhc2VuYW1lIGZpbGUpKSkpCisg ICAgICAgICAgICAgICAgIChmaW5kLWZpbGVzICJiaW4iICJcXC5sdjIkIiAjOmRpcmVjdG9yaWVz PyAjdCkpCisgICAgICAgICAgICAgICA7OyBJbnN0YWxsIHN0YW5kYWxvbmUKKyAgICAgICAgICAg ICAgIChpbnN0YWxsLWZpbGUgImJpbi9EcmFnb25mbHlSb29tUmV2ZXJiIiBiaW4pCisgICAgICAg ICAgICAgICAoaW5zdGFsbC1maWxlICJiaW4vRHJhZ29uZmx5SGFsbFJldmVyYiIgYmluKQorICAg ICAgICAgICAgICAgI3QpKSkpKSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJqYWNrIiAsamFjay0x KQorICAgICAgICgibGlieDExIiAsbGlieDExKQorICAgICAgICgibWVzYSIgLG1lc2EpKSkKKyAg ICAobmF0aXZlLWlucHV0cworICAgICBgKCgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpKSkKKyAg ICAoc3lub3BzaXMgIkNvbmNlcnQgaGFsbCByZXZlcmIgYW5kIHJvb20gcmV2ZXJiIGVmZmVjdHMi KQorICAgIChkZXNjcmlwdGlvbgorICAgICAiRHJhZ29uZmx5IFJldmVyYiBpcyBhIGJ1bmRsZSBv ZiB0d28gZnJlZSBhdWRpbyBlZmZlY3RzOiBhIGNvbmNlcnQKK2hhbGwgcmV2ZXJiIGFuZCBhIHJv b20gcmV2ZXJiLiAgQm90aCBhcmUgYXZhaWxhYmxlIGFzIExWMiBwbHVnaW5zIGFzIHdlbGwKK2Fz IEpBQ0sgc3RhbmRhbG9uZSBhcHBsaWNhdGlvbnMuIikKKyAgICAoaG9tZS1wYWdlICJodHRwczov L21pY2hhZWx3aWxsaXMuZ2l0aHViLmlvL2RyYWdvbmZseS1yZXZlcmIvIikKKyAgICAobGljZW5z ZSBsaWNlbnNlOmdwbDMrKSkpCi0tIAoyLjI1LjEKCg== --=-AW8hzv1Xn6CykRDM3FGs-- --=-WcvPSxsVV70vTMN8UtGF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl52ZnwACgkQAi6uQjE9 cPPpHgf/eVNdAyAnRQHkB4IgUMsHSvystU8IZRbycnDpa0tBgW8scmT5MVzlD5bi XKHiMxOEB91Vnh8VPrzDN1GuQhc739uqiM/UDYoOfrhhC5Qdn6gMoRS9kYBG24Hf 1Tx/JHLJUZXIwuq14TJUbSstogjksBWo4n4KCrjSZ5yNE0ug9iBpqKesMfVcHPMm +QH1ap/Y4kxDfByd0hfHjXfPYLWOG+xwWPvz0cz9itlIG2fwPTE8i0BDgK2rQ9fM hhGOVr+jsWMlGS4EDz7GC1w1sAJ03jw2nNTGeYhRpyEz9UruujcUKauZmQLTUZE4 cE4QLFX61o0bzfxDVkFGlUSg1SIvNA== =2GMS -----END PGP SIGNATURE----- --=-WcvPSxsVV70vTMN8UtGF--