* [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
@ 2021-11-21 17:41 Liliana Marie Prikler
2022-09-09 16:19 ` bug#52022: " Liliana Marie Prikler
0 siblings, 1 reply; 2+ messages in thread
From: Liliana Marie Prikler @ 2021-11-21 17:41 UTC (permalink / raw)
To: 52022
When using this gst-plugins/selection without setting configure-flags, the
existing flags are simply inherited. This leads to an issue with
unquote-splicing when looking at quoted lists, e.g. as used by
gst-plugins-bad.
* gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-flags]:
Only splice user-provided configure-flags, simply unquote those from existing
packages.
Reported-by: unmatched-paren, nckx (IRC)
---
gnu/packages/gstreamer.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 2927055240..f7d0808b98 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -924,13 +924,15 @@ (define-public gst-plugins/selection
(package/inherit pkg
(arguments
(substitute-keyword-arguments (package-arguments pkg)
- ((#:configure-flags flags `(,@(or configure-flags '())))
+ ((#:configure-flags flags ''())
`(append
(list
,@(map (lambda (plugin)
(string-append "-D" plugin "=enabled"))
plugins))
- (list ,@(or configure-flags flags))))
+ ,(if configure-flags
+ `(list ,@configure-flags)
+ flags)))
((#:phases phases)
`(modify-phases ,phases
(add-after 'unpack 'disable-auto-plugins
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#52022: [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
2021-11-21 17:41 [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is Liliana Marie Prikler
@ 2022-09-09 16:19 ` Liliana Marie Prikler
0 siblings, 0 replies; 2+ messages in thread
From: Liliana Marie Prikler @ 2022-09-09 16:19 UTC (permalink / raw)
To: 52022-done
Am Sonntag, dem 21.11.2021 um 18:41 +0100 schrieb Liliana Marie
Prikler:
> When using this gst-plugins/selection without setting configure-
> flags, the
> existing flags are simply inherited. This leads to an issue with
> unquote-splicing when looking at quoted lists, e.g. as used by
> gst-plugins-bad.
>
> * gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-
> flags]:
> Only splice user-provided configure-flags, simply unquote those from
> existing
> packages.
>
> Reported-by: unmatched-paren, nckx (IRC)
This patch appears rather outdated and has been superseded by one I
applied to staging. Thus closing.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-09 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-21 17:41 [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is Liliana Marie Prikler
2022-09-09 16:19 ` bug#52022: " Liliana Marie Prikler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.