From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: 52022@debbugs.gnu.org
Subject: [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
Date: Sun, 21 Nov 2021 18:41:28 +0100 [thread overview]
Message-ID: <3521e930d03c2eb55ee37074565d4218a28c73ad.camel@gmail.com> (raw)
When using this gst-plugins/selection without setting configure-flags, the
existing flags are simply inherited. This leads to an issue with
unquote-splicing when looking at quoted lists, e.g. as used by
gst-plugins-bad.
* gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-flags]:
Only splice user-provided configure-flags, simply unquote those from existing
packages.
Reported-by: unmatched-paren, nckx (IRC)
---
gnu/packages/gstreamer.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 2927055240..f7d0808b98 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -924,13 +924,15 @@ (define-public gst-plugins/selection
(package/inherit pkg
(arguments
(substitute-keyword-arguments (package-arguments pkg)
- ((#:configure-flags flags `(,@(or configure-flags '())))
+ ((#:configure-flags flags ''())
`(append
(list
,@(map (lambda (plugin)
(string-append "-D" plugin "=enabled"))
plugins))
- (list ,@(or configure-flags flags))))
+ ,(if configure-flags
+ `(list ,@configure-flags)
+ flags)))
((#:phases phases)
`(modify-phases ,phases
(add-after 'unpack 'disable-auto-plugins
--
2.34.0
next reply other threads:[~2021-11-21 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 17:41 Liliana Marie Prikler [this message]
2022-09-09 16:19 ` bug#52022: [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3521e930d03c2eb55ee37074565d4218a28c73ad.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=52022@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.