* [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group
@ 2022-11-12 18:53 EuAndreh via Guix-patches via
2022-11-17 12:11 ` Christopher Baines
0 siblings, 1 reply; 2+ messages in thread
From: EuAndreh via Guix-patches via @ 2022-11-12 18:53 UTC (permalink / raw)
To: 59223; +Cc: EuAndreh
The default value for <gitolite-configuration> has "git" for both the
values of the user and the group, as costumary, which means that unless
someone uses a custom configuration and chooses different strings for
user and group, this wouldn't show up.
* gnu/services/version-control.scm (gitolite-accounts): Use the correct
variable for the name of a (user-group ...).
---
I did a "git grep user-group gnu/services/" and looked at the returned
entries. After a quick cursory look, either all the entries had a
hard-coded string value, or picked the correct variable for the group
name. So I think this one is a one-off :)
This surfaced after a debugging session with mirai on IRC earlier today.
gnu/services/version-control.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm
index b6b78e504e..86d40bdbe3 100644
--- a/gnu/services/version-control.scm
+++ b/gnu/services/version-control.scm
@@ -313,7 +313,7 @@ (define gitolite-accounts
(($ <gitolite-configuration> package user group home-directory
rc-file admin-pubkey)
;; User group and account to run Gitolite.
- (list (user-group (name user) (system? #t))
+ (list (user-group (name group) (system? #t))
(user-account
(name user)
(group group)
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group
2022-11-12 18:53 [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group EuAndreh via Guix-patches via
@ 2022-11-17 12:11 ` Christopher Baines
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2022-11-17 12:11 UTC (permalink / raw)
To: EuAndreh; +Cc: 59223-done, 59223
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
EuAndreh via Guix-patches via <guix-patches@gnu.org> writes:
> The default value for <gitolite-configuration> has "git" for both the
> values of the user and the group, as costumary, which means that unless
> someone uses a custom configuration and chooses different strings for
> user and group, this wouldn't show up.
>
> * gnu/services/version-control.scm (gitolite-accounts): Use the correct
> variable for the name of a (user-group ...).
> ---
>
> I did a "git grep user-group gnu/services/" and looked at the returned
> entries. After a quick cursory look, either all the entries had a
> hard-coded string value, or picked the correct variable for the group
> name. So I think this one is a one-off :)
>
> This surfaced after a debugging session with mirai on IRC earlier today.
>
> gnu/services/version-control.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm
> index b6b78e504e..86d40bdbe3 100644
> --- a/gnu/services/version-control.scm
> +++ b/gnu/services/version-control.scm
> @@ -313,7 +313,7 @@ (define gitolite-accounts
> (($ <gitolite-configuration> package user group home-directory
> rc-file admin-pubkey)
> ;; User group and account to run Gitolite.
> - (list (user-group (name user) (system? #t))
> + (list (user-group (name group) (system? #t))
> (user-account
> (name user)
> (group group)
Good spot! I've pushed this to master as
35ef5fca0ac997680e47942e25f403fb3ec54c7d.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 18:53 [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group EuAndreh via Guix-patches via
2022-11-17 12:11 ` Christopher Baines
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.