all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: EuAndreh via Guix-patches via <guix-patches@gnu.org>
To: 59223@debbugs.gnu.org
Cc: EuAndreh <eu@euandre.org>
Subject: [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group
Date: Sat, 12 Nov 2022 15:53:21 -0300	[thread overview]
Message-ID: <20221112185321.17566-1-eu@euandre.org> (raw)

The default value for <gitolite-configuration> has "git" for both the
values of the user and the group, as costumary, which means that unless
someone uses a custom configuration and chooses different strings for
user and group, this wouldn't show up.

* gnu/services/version-control.scm (gitolite-accounts): Use the correct
  variable for the name of a (user-group ...).
---

I did a "git grep user-group gnu/services/" and looked at the returned
entries.  After a quick cursory look, either all the entries had a
hard-coded string value, or picked the correct variable for the group
name.  So I think this one is a one-off :)

This surfaced after a debugging session with mirai on IRC earlier today.

 gnu/services/version-control.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm
index b6b78e504e..86d40bdbe3 100644
--- a/gnu/services/version-control.scm
+++ b/gnu/services/version-control.scm
@@ -313,7 +313,7 @@ (define gitolite-accounts
     (($ <gitolite-configuration> package user group home-directory
                                  rc-file admin-pubkey)
      ;; User group and account to run Gitolite.
-     (list (user-group (name user) (system? #t))
+     (list (user-group (name group) (system? #t))
            (user-account
             (name user)
             (group group)
-- 
2.38.1





             reply	other threads:[~2022-11-12 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 18:53 EuAndreh via Guix-patches via [this message]
2022-11-17 12:11 ` [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112185321.17566-1-eu@euandre.org \
    --to=guix-patches@gnu.org \
    --cc=59223@debbugs.gnu.org \
    --cc=eu@euandre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.