all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#57913] [PATCH] gnu: Add java-argparse4j.
@ 2022-09-18 17:17 Artyom V. Poptsov
  2022-09-18 18:35 ` Julien Lepiller
  0 siblings, 1 reply; 4+ messages in thread
From: Artyom V. Poptsov @ 2022-09-18 17:17 UTC (permalink / raw)
  To: 57913


[-- Attachment #1.1: Type: text/plain, Size: 38 bytes --]

Hello,

this patch adds "argparse4j".

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-java-argparse4j.patch --]
[-- Type: text/x-diff, Size: 2472 bytes --]

From d4f3e93b9fd322dfc9c71d7251cdf8c8b838a6f5 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Sun, 18 Sep 2022 20:14:28 +0300
Subject: [PATCH] gnu: Add java-argparse4j.

* gnu/packages/java.scm (java-argparse4j): New variable.
---
 gnu/packages/java.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index c25a330c2a..2afc6f89ca 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -13965,6 +13965,44 @@ (define-public java-args4j
 parse command line options/arguments in your CUI application.")
     (license license:expat)))
 
+(define-public java-argparse4j
+  (package
+    (name "java-argparse4j")
+    (version "0.9.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/argparse4j/argparse4j")
+                    (commit (string-append "argparse4j-" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1i0j3zs1ln48n0g8a90vqbv6528mcswhzys6252yp0c8w1ai64fb"))))
+    (build-system ant-build-system)
+    (arguments
+     (list #:jar-name "java-argparse4j.jar"
+           #:source-dir "main/src/main/"
+           #:test-dir "main/src/test/"
+           #:jdk openjdk11
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'copy-resources
+                 (lambda _
+                   ;; XXX: argparse4j expects input files for argument parser
+                   ;; tests to be in "target" diretory.
+                   (copy-recursively "main/src/test/resources"
+                                     "target/test-classes")
+                   (copy-recursively "main/src/main/resources"
+                                     "build/classes")))
+               (replace 'install
+                 (install-from-pom "pom.xml")))))
+    (inputs (list maven-enforcer-plugin))
+    (home-page "https://argparse4j.github.io/")
+    (synopsis "Java command-line argument parser library")
+    (description "Argparse4j is a command line argument parser library for
+Java based on Python's @code{argparse} module.")
+    (license license:expat)))
+
 (define-public java-metadata-extractor
   (package
     (name "java-metadata-extractor")
-- 
2.34.1


[-- Attachment #1.3: Type: text/plain, Size: 364 bytes --]


Thanks,

- Artyom

References:
1. Java port of Python's famous argparse command-line argument parser.
   <https://github.com/argparse4j/argparse4j>

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#57913] [PATCH] gnu: Add java-argparse4j.
  2022-09-18 17:17 [bug#57913] [PATCH] gnu: Add java-argparse4j Artyom V. Poptsov
@ 2022-09-18 18:35 ` Julien Lepiller
  2022-09-18 18:45   ` Artyom V. Poptsov
  0 siblings, 1 reply; 4+ messages in thread
From: Julien Lepiller @ 2022-09-18 18:35 UTC (permalink / raw)
  To: Artyom V. Poptsov, 57913

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

This looks good from a distance, but I'm not sure you need maven-enforcer-plugin. Since you're using the ant-build-system, I don't think the plugin has a chance to run?

Le 18 septembre 2022 19:17:30 GMT+02:00, "Artyom V. Poptsov" <poptsov.artyom@gmail.com> a écrit :
>Hello,
>
>this patch adds "argparse4j".

[-- Attachment #2: Type: text/html, Size: 579 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#57913] [PATCH] gnu: Add java-argparse4j.
  2022-09-18 18:35 ` Julien Lepiller
@ 2022-09-18 18:45   ` Artyom V. Poptsov
  2022-09-19 13:52     ` bug#57913: " Julien Lepiller
  0 siblings, 1 reply; 4+ messages in thread
From: Artyom V. Poptsov @ 2022-09-18 18:45 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: 57913


[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]

Hello Julien,

thank you for the patch review.

> This looks good from a distance, but I'm not sure you need
> maven-enforcer-plugin. Since you're using the ant-build-system, I
> don't think the plugin has a chance to run?

Good catch.  It seems that "java-argparse4j" builds fine w/o
"maven-enforcer-plugin".  I removed this dependency and added
"java-junit" instead as it is required for the tests.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-java-argparse4j.patch --]
[-- Type: text/x-diff, Size: 2379 bytes --]

From c96118bb654a6120614c363b9ff3e37ac9162b06 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Sun, 18 Sep 2022 20:14:28 +0300
Subject: [PATCH] gnu: Add java-argparse4j.

* gnu/packages/java.scm (java-argparse4j): New variable.
---
 gnu/packages/java.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index c25a330c2a..e4814d1acb 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -13965,6 +13965,41 @@ (define-public java-args4j
 parse command line options/arguments in your CUI application.")
     (license license:expat)))
 
+(define-public java-argparse4j
+  (package
+    (name "java-argparse4j")
+    (version "0.9.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/argparse4j/argparse4j")
+                    (commit (string-append "argparse4j-" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1i0j3zs1ln48n0g8a90vqbv6528mcswhzys6252yp0c8w1ai64fb"))))
+    (build-system ant-build-system)
+    (arguments
+     (list #:jar-name "java-argparse4j.jar"
+           #:source-dir "main/src/main/"
+           #:test-dir "main/src/test/"
+           #:jdk openjdk11
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'copy-resources
+                          (lambda _
+                            (copy-recursively "main/src/test/resources"
+                                              "target/test-classes")
+                            (copy-recursively "main/src/main/resources"
+                                              "build/classes")))
+                        (replace 'install
+                          (install-from-pom "pom.xml")))))
+    (inputs (list java-junit))
+    (home-page "https://argparse4j.github.io/")
+    (synopsis "Java command-line argument parser library")
+    (description "Argparse4j is a command line argument parser library for
+Java based on Python's @code{argparse} module.")
+    (license license:expat)))
+
 (define-public java-metadata-extractor
   (package
     (name "java-metadata-extractor")
-- 
2.34.1


[-- Attachment #1.3: Type: text/plain, Size: 219 bytes --]


- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#57913: [PATCH] gnu: Add java-argparse4j.
  2022-09-18 18:45   ` Artyom V. Poptsov
@ 2022-09-19 13:52     ` Julien Lepiller
  0 siblings, 0 replies; 4+ messages in thread
From: Julien Lepiller @ 2022-09-19 13:52 UTC (permalink / raw)
  To: Artyom V. Poptsov; +Cc: 57913-done

Le Sun, 18 Sep 2022 21:45:16 +0300,
"Artyom V. Poptsov" <poptsov.artyom@gmail.com> a écrit :

> Hello Julien,
> 
> thank you for the patch review.
> 
> > This looks good from a distance, but I'm not sure you need
> > maven-enforcer-plugin. Since you're using the ant-build-system, I
> > don't think the plugin has a chance to run?  
> 
> Good catch.  It seems that "java-argparse4j" builds fine w/o
> "maven-enforcer-plugin".  I removed this dependency and added
> "java-junit" instead as it is required for the tests.

Thanks for the patch, pushed to master as
72fe3c0a35f04a6616c17228953a20861ce9b690.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-19 13:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-18 17:17 [bug#57913] [PATCH] gnu: Add java-argparse4j Artyom V. Poptsov
2022-09-18 18:35 ` Julien Lepiller
2022-09-18 18:45   ` Artyom V. Poptsov
2022-09-19 13:52     ` bug#57913: " Julien Lepiller

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.