all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: 57913-done@debbugs.gnu.org
Subject: bug#57913: [PATCH] gnu: Add java-argparse4j.
Date: Mon, 19 Sep 2022 15:52:49 +0200	[thread overview]
Message-ID: <20220919155249.45fd9867@sybil.lepiller.eu> (raw)
In-Reply-To: <878rmgo72b.fsf@gmail.com>

Le Sun, 18 Sep 2022 21:45:16 +0300,
"Artyom V. Poptsov" <poptsov.artyom@gmail.com> a écrit :

> Hello Julien,
> 
> thank you for the patch review.
> 
> > This looks good from a distance, but I'm not sure you need
> > maven-enforcer-plugin. Since you're using the ant-build-system, I
> > don't think the plugin has a chance to run?  
> 
> Good catch.  It seems that "java-argparse4j" builds fine w/o
> "maven-enforcer-plugin".  I removed this dependency and added
> "java-junit" instead as it is required for the tests.

Thanks for the patch, pushed to master as
72fe3c0a35f04a6616c17228953a20861ce9b690.




      reply	other threads:[~2022-09-19 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 17:17 [bug#57913] [PATCH] gnu: Add java-argparse4j Artyom V. Poptsov
2022-09-18 18:35 ` Julien Lepiller
2022-09-18 18:45   ` Artyom V. Poptsov
2022-09-19 13:52     ` Julien Lepiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919155249.45fd9867@sybil.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=57913-done@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.