[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[burning2007]

From: Anthony <anthony@example.com>

Hi, folks!

This patch adds chromium-web-store browser extension. Although I would like to
use Guix as well for installing chromium extensions, this is currently too
cumbersome. I've tried to "pack" a couple of extensions, some did work, some didn't.
So, I decided to fallback to Chrome Web Store for now. This chromium-web-store is
only missing part to do that.

P.S. A package built from this definition will be named `chromium-web-store-chromium`
due to the way `(make-chromium-extension ...)` names produced "extension packages".

Anthony (1):
  gnu: browser-extensions: add chromium-web-store

 gnu/packages/browser-extensions.scm | 35 +++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

-- 
2.35.3

[bug#55790] [PATCH 1/1] gnu: browser-extensions: add chromium-web-store

[burning2007]

From: Anthony <anthony@example.com>

---
 gnu/packages/browser-extensions.scm | 35 +++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/browser-extensions.scm b/gnu/packages/browser-extensions.scm
index f305552076..a413da8beb 100644
--- a/gnu/packages/browser-extensions.scm
+++ b/gnu/packages/browser-extensions.scm
@@ -109,3 +109,38 @@ (define ublock-origin
 
 (define-public ublock-origin/chromium
   (make-chromium-extension ublock-origin "chromium"))
+
+(define chromium-web-store
+  (package
+    (name "chromium-web-store")
+    (version "1.4.4.3")
+    (home-page "https://github.com/NeverDecaf/chromium-web-store")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "17jp05dpd8lk8k7fi56jdbhiisx4ajylr6kax01mzfkwfhkd0q9d"))))
+    (build-system copy-build-system)
+    (outputs '("chromium"))
+    (arguments
+      '(#:phases
+        (modify-phases %standard-phases
+          (replace 'install
+            (lambda* (#:key outputs #:allow-other-keys)
+              (copy-recursively "src" (assoc-ref outputs "chromium")))))))
+    (synopsis "Allows adding extensions from chrome web store on ungoogled-chromium")
+    (description "This extension brings the following functionality to
+ungoogled-chromium (and other forks that lack web store support):
+@itemize
+@item Allows installing extensions directly from chrome web store.
+@item Automatically checks for updates to your installed extensions and displays
+them on the badge.
+@end itemize")
+    (license license:expat)))
+
+(define-public chromium-web-store/chromium
+  (make-chromium-extension chromium-web-store "chromium"))
-- 
2.35.3

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[Liliana Marie Prikler]

Am Samstag, dem 04.06.2022 um 03:02 +0200 schrieb burning2007@ya.ru:
> From: Anthony <anthony@example.com>
> 
> Hi, folks!
> 
> This patch adds chromium-web-store browser extension. Although I would
> like to use Guix as well for installing chromium extensions, this is
> currently too cumbersome. I've tried to "pack" a couple of extensions,
> some did work, some didn't.
Do submit those that work.

> So, I decided to fallback to Chrome Web Store for now. This chromium-
> web-store is only missing part to do that.
You can do that, but as for the inclusion in Guix, please refer to the
FSDG [1], particularly "The system should have no repositories for
nonfree software and no specific recipes for installation of particular
nonfree programs. Nor should the distribution refer to third-party
repositories that are not committed to only including free software;
even if they only have free software today, that may not be true
tomorrow."  Our importer infrastructure is already bending that rule;
there's no need to break it.

Cheers

https://www.gnu.org/distros/free-system-distribution-guidelines.html

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[burning2007]

[-- Attachment #1: Type: text/html, Size: 644 bytes --]

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[burning2007]

[-- Attachment #1: Type: text/html, Size: 394 bytes --]

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

[Removed anthony@example.com from CC because it's not a valid e-mail address]

burning2007@ya.ru schreef op za 04-06-2022 om 14:30 [+0300]:
> > refer to the FSDG [1], particularly "... no specific recipes for
> > installation of particular nonfree programs ..."
>  
> Does it mean that a package proposed for inclusion shouldn't provide
> a way to install other software from external "repository",

External repositories are ok I think, no need to remove pip from Python
or ContentDB from Minetest or channels or "guix build -f" from Guix or
cabal.

>  like Chrome Web Store?

Chrome Web Store is not just an external repository, it's a mostly non-
free repository (in contrast to, say, pypi, ContentDB), see my e-mail.

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 43 bytes --]

* see my e-mail -> see my previous e-mail

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#55790] [PATCH 0/1] Add chromium-web-store extension

[Skyler Ferris via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

Hi all,

It looks like there's a disagreement between Liliana and Maxime which was never fully addressed, so it's not clear if this will ever be merge-able.

My take is that Maxime's example of pip is relevant because the [pypi terms of use](https://pypi.org/policy/terms-of-use/) only requires that a royalty-free license is present, and non-free licenses can be royalty-free (I am not a lawyer). However, based on Liliana's interpretation of the FSDG the conclusion is "pip should not be included" rather than "the webstore should be included". Of course, removing pip is likely to cause problems for people as pip is a widely used method of managing python code. I do not know if any of the people in this conversation so far are legal experts and I would want to have a high level of confidence before proposing such a controversial change.

Considering that this email came from an address that cannot be valid, I think it is also fair to be concerned that this email might have been sent in bad faith with the intent of creating conflict and disrupting the project. Since we don't have any reason to think that including pip is a violation of the FSDG other than presumably amateur analysis, pip is a high-profile package so it's not likely to have been overlooked, and the only person who has expressed interest in including the webstore has gone out of their way to obfuscate their identity, I think it would be fair to simply close this issue with no further discussion. But I do not feel comfortable taking that action unilaterally considering the sensitivity of the matters discussed.

Regards,
Skyler

[-- Attachment #2: Type: text/html, Size: 2020 bytes --]