From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 50833@debbugs.gnu.org
Subject: [bug#50833] [PATCH] gnu: Add bower.
Date: Tue, 28 Sep 2021 21:12:20 -0400 [thread overview]
Message-ID: <20210928211220.GB21136@gac.attlocal.net> (raw)
In-Reply-To: <864ka6vnkv.fsf@mgsn.dev>
On Sun, 26 Sep 2021 18:01:20 -0700 Sarah Morgensen <iskarian@mgsn.dev> wrote:
Hi Sarah, thanks for all the feedback! It is much appreciated that you took
the time to do that.
> (invoke "make" "-C" "tests")
I added this.
> or maybe even avoid the custom phase with test-target:
>
> #:test-target "--directory=tests"
This one didn't work out for me.
> It might be helpful to also install bower.conf.sample to "/share/bower",
> so we have an example config file.
Added this request.
> If it's not possible to 'substitute*' those values, 'wrap-program' could
> be used to add the correct directories to PATH, but that can introduce
> other issues.
I'll have to wrap my head around this one a bit more to understand what is needed.
It looks like the mercury code does not call the binaries directly.
I might be wrong. I have to take a closer look. Do you happen to have
some places in the code where you see the binaries being called in a way that
requires wrapping the path?
I updated the description :)
Below is the updated patch.
all best
next prev parent reply other threads:[~2021-09-29 1:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 23:08 [bug#50833] Add bower (it's not what you're thinking) jgart via Guix-patches via
2021-09-26 23:11 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-09-27 1:01 ` Sarah Morgensen
2021-09-29 1:12 ` jgart via Guix-patches via [this message]
2021-10-01 2:11 ` Sarah Morgensen
2021-10-01 3:31 ` jgart via Guix-patches via
2021-10-02 7:58 ` jgart via Guix-patches via
2021-10-25 4:32 ` jgart via Guix-patches via
2021-10-25 12:25 ` [bug#50833] Add bower (it's not what you're thinking) Ludovic Courtès
2022-04-20 21:07 ` [bug#50833] [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer
2022-05-05 14:31 ` jgart via Guix-patches via
2022-07-07 18:01 ` Maxim Cournoyer
2022-07-08 0:23 ` jgart via Guix-patches via
2022-07-08 10:33 ` Munyoki Kilyungi
2022-07-08 18:47 ` jgart via Guix-patches via
2022-07-08 19:42 ` jgart via Guix-patches via
2022-07-14 8:54 ` Munyoki Kilyungi
2022-07-11 16:09 ` Maxim Cournoyer
2022-07-15 1:50 ` jgart via Guix-patches via
2021-09-29 1:12 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-10-01 3:31 ` jgart via Guix-patches via
2022-07-20 5:18 ` [bug#50833] [PATCH v2] " jgart via Guix-patches via
2022-07-20 11:59 ` Maxime Devos
2022-07-24 17:45 ` jgart via Guix-patches via
2022-08-21 6:53 ` [bug#50833] [PATCH v3] " jgart via Guix-patches via
2022-09-02 14:05 ` bug#50833: [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928211220.GB21136@gac.attlocal.net \
--to=guix-patches@gnu.org \
--cc=50833@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.