From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MGjOIKm9U2E2vAAAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 03:13:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +E1hHKm9U2FXKAAAbx9fmQ (envelope-from ) for ; Wed, 29 Sep 2021 01:13:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C07C78B0 for ; Wed, 29 Sep 2021 03:13:13 +0200 (CEST) Received: from localhost ([::1]:49890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVO9o-0008Tk-7O for larch@yhetil.org; Tue, 28 Sep 2021 21:13:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVO9e-0008TD-GN for guix-patches@gnu.org; Tue, 28 Sep 2021 21:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVO9e-0007Ny-97 for guix-patches@gnu.org; Tue, 28 Sep 2021 21:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVO9e-0006Jx-5B for guix-patches@gnu.org; Tue, 28 Sep 2021 21:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50833] [PATCH] gnu: Add bower. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 01:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50833 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Sarah Morgensen Cc: 50833@debbugs.gnu.org Received: via spool by 50833-submit@debbugs.gnu.org id=B50833.163287795324245 (code B ref 50833); Wed, 29 Sep 2021 01:13:02 +0000 Received: (at 50833) by debbugs.gnu.org; 29 Sep 2021 01:12:33 +0000 Received: from localhost ([127.0.0.1]:47333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVO9B-0006Iz-1n for submit@debbugs.gnu.org; Tue, 28 Sep 2021 21:12:33 -0400 Received: from mx1.dismail.de ([78.46.223.134]:7310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVO98-0006Ij-VQ for 50833@debbugs.gnu.org; Tue, 28 Sep 2021 21:12:31 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 0df38307; Wed, 29 Sep 2021 03:12:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=mHYJN9Btqay8UGuDDNCS4l+qN9Yn0ib6vzf4Lw5pwpA=; b=d9w EIW+3HUIfmfYJATCfKD8XRduUm7/KbsBK9V4TN5cCb41IlTByCCX+rYi+QArbTc1 qdwP1Cp4YdQnz40JSNufQRaO7+3WiwvZMm+wLMybTm6Vj+ilX8LxSQKzJNXIRQ5Z ZrsY+3oM0FJvszZ3QzlXGWkCWg3cJ6Vucswait2S6Po2R/vI4Ja9TW0nKz6QGTf3 kuSMfzyE4hW4YQjGLso63VTa/yRD+4R5ngeQqYMxQYQ+3YMeqpvp9427aFMjYY07 I+gkVJuuyvch3nADgxMzuAV+44Ds8iq6oz2pOQgglYbRWL6qa/WtyMOIosVS9XLv TIQo0qV+lVioBB5MEuA== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id d40b52ea; Wed, 29 Sep 2021 03:12:23 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 38b9cdce; Wed, 29 Sep 2021 03:12:23 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 0444077e (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 29 Sep 2021 03:12:22 +0200 (CEST) Date: Tue, 28 Sep 2021 21:12:20 -0400 Message-ID: <20210928211220.GB21136@gac.attlocal.net> In-Reply-To: <864ka6vnkv.fsf@mgsn.dev> References: <20210926190836.GB8410@gac.attlocal.net> <20210926231145.18651-1-jgart@dismail.de> <864ka6vnkv.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 5C07C78B0 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: qrUBQKKV0qqv On Sun, 26 Sep 2021 18:01:20 -0700 Sarah Morgensen wrote: Hi Sarah, thanks for all the feedback! It is much appreciated that you took the time to do that. > (invoke "make" "-C" "tests") I added this. > or maybe even avoid the custom phase with test-target: > > #:test-target "--directory=tests" This one didn't work out for me. > It might be helpful to also install bower.conf.sample to "/share/bower", > so we have an example config file. Added this request. > If it's not possible to 'substitute*' those values, 'wrap-program' could > be used to add the correct directories to PATH, but that can introduce > other issues. I'll have to wrap my head around this one a bit more to understand what is needed. It looks like the mercury code does not call the binaries directly. I might be wrong. I have to take a closer look. Do you happen to have some places in the code where you see the binaries being called in a way that requires wrapping the path? I updated the description :) Below is the updated patch. all best